New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 818520 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression

Blocking:
issue 758397



Sign in to add a comment

Minus in the size in Data Saver

Project Member Reported by mar...@mwiacek.com, Mar 4 2018

Issue description

Device name:s7

From "Settings > About Chrome"
Application version:66.0.3361.0
Operating system:7

Data saver stats are showing number with "-".

In which situation it can happen?
 
Screenshot_20180304-214126.png
68.6 KB View Download
Screenshot_20180304-214123.png
57.9 KB View Download
Labels: Needs-triage-Mobile
Cc: pnangunoori@chromium.org
Components: Internals>Network>DataUse Internals>Plugins>Flash
Labels: Needs-Feedback Triaged-Mobile
Tested on Samsung S6 Android 6.0.1 and Samsung J7 Android 7.0.0 using the latest Canary #67.0.3363.3 and not able to observe the negative values with '-' before the values.

marcin@ -- Thanks for reporting the issue. Could you please share the logs related to this issue. 

Requesting dev team to take a look into this issue.

Thanks in advance!
Components: -Internals>Plugins>Flash Internals>Network>DataProxy
Labels: -Pri-2 -Needs-Feedback -Arch-x86_64 -Needs-triage-Mobile M-65 Pri-1
Owner: rajendrant@chromium.org
Status: Assigned (was: Unconfirmed)
Thank you for reporting this. This seems to be a bug in our code.

Assigning to rajendrant@ since it's related to data usage and site breakdown. The fix should be merged back to M-65.
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f8f470d2e182759b8f505925a6ae9073d3befa9

commit 0f8f470d2e182759b8f505925a6ae9073d3befa9
Author: rajendrant <rajendrant@chromium.org>
Date: Thu Mar 08 01:41:06 2018

Fix overflow in data saver remaining sites data usage

Bug:  818520 
Change-Id: I6a5c98239f05caf3499ac6eb5de520160ae1bed0
Reviewed-on: https://chromium-review.googlesource.com/953202
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541680}
[modify] https://crrev.com/0f8f470d2e182759b8f505925a6ae9073d3befa9/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionSiteBreakdownView.java

Labels: Merge-Request-65
This is a simple fix to merge.
Project Member

Comment 7 by sheriffbot@chromium.org, Mar 8 2018

Labels: -Merge-Request-65 Merge-Review-65 Hotlist-Merge-Review
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -M-65 -Merge-Review-65 Merge-Review-66
Sorry, I meant merge to M-66.

Comment 9 by cmasso@google.com, Mar 8 2018

Please verify in Canary

Comment 10 by mar...@mwiacek.com, Mar 11 2018

still not enough / not fixed
Screenshot_20180310-133943.png
486 KB View Download

Comment 11 by mar...@mwiacek.com, Mar 11 2018

Screenshot_20180310-134047.png
119 KB View Download

Comment 12 by cmasso@google.com, Mar 12 2018

Labels: -Hotlist-Merge-Review -Merge-Review-66 Merge-Approved-66

Comment 13 by cmasso@google.com, Mar 13 2018

Please merge this change as soon as possible
Project Member

Comment 14 by sheriffbot@chromium.org, Mar 16 2018

Cc: cmasso@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Thanks Robert. I will remove.

Looks like a different CL has added that cast.
https://chromium-review.googlesource.com/953181
Project Member

Comment 17 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c51a0eb99240cd68c7a5a5235330ec4c8f1cd98d

commit c51a0eb99240cd68c7a5a5235330ec4c8f1cd98d
Author: rajendrant <rajendrant@chromium.org>
Date: Mon Mar 19 20:59:10 2018

Fix int cast in data saver remaining sites data usage

Bug:  818520 
Change-Id: Id9a9c289a29ab9b1ccef5eff4f0019bb47363866
Reviewed-on: https://chromium-review.googlesource.com/969452
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544154}
[modify] https://crrev.com/c51a0eb99240cd68c7a5a5235330ec4c8f1cd98d/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionSiteBreakdownView.java

Project Member

Comment 18 by sheriffbot@chromium.org, Mar 20 2018

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Blocking: 758397
Project Member

Comment 20 by bugdroid1@chromium.org, Mar 20 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6bf131cc74a8f0d9da053aaf7aff9a414f80b552

commit 6bf131cc74a8f0d9da053aaf7aff9a414f80b552
Author: rajendrant <rajendrant@chromium.org>
Date: Tue Mar 20 21:33:50 2018

Fix overflow in data saver remaining sites data usage

Bug:  818520 
Change-Id: I6a5c98239f05caf3499ac6eb5de520160ae1bed0
Reviewed-on: https://chromium-review.googlesource.com/953202
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: rajendrant <rajendrant@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#541680}(cherry picked from commit 0f8f470d2e182759b8f505925a6ae9073d3befa9)
Reviewed-on: https://chromium-review.googlesource.com/972301
Reviewed-by: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#356}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/6bf131cc74a8f0d9da053aaf7aff9a414f80b552/chrome/android/java/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionSiteBreakdownView.java

Status: Fixed (was: Started)
Verified in latest canary.

Sign in to add a comment