[regression] Node icon doesn't display in DevTools when a debuggable Node is spawned
Reported by
christo...@delicious-insights.com,
Mar 4 2018
|
|||||||||
Issue descriptionChrome Version : 64.0.3282.140 OS Version: OS X 10.13.3 URLs (if applicable) : What steps will reproduce the problem? 1. Open any URL in Chrome 2. Open the DevTools 3. On the same machine, launch a debuggable Node, e.g. `node --inspect` What is the expected result? It should show the Node debugger icon in the DevTools header bar almost instantly once a debuggable Node is spawned. What happens instead of that? No Node debugger icon shows in the DevTools header bar. Now we have to use `about:inspect` URLs to see the Node instance (Remote Devices drawer tab won't show these, btw, which seems a bit inconsistent) Please provide any additional information below. Attach a screenshot if possible. UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.140 Safari/537.36
,
Mar 5 2018
christophe@ Thanks for the issue. Tried testing this issue on Mac OS 10.12.6 and Windows 10 on the reported version 64.0.3282.140 and the latest Canary 67.0.3361.0 by following the below steps. 1. Launched Chrome and navigated to https://nodejs.org/en/docs/inspector as shown in the attached screen shot in Comment #0. 2. Added the extension 'Node.js V8 --inspector Manager (NiM)'. 3. Opened New tab -> Devtools and clicked on the extension icon. Couldn't observe any Debuggable node. Attached is the screen cast for reference. Request you to please check and confirm if anything is missed from our end in triaging the issue. Also request you to provide a screen cast of the steps followed to reproduce the issue which will help in better understanding. Thanks..
,
Mar 5 2018
Hey Susan@, I'm not sure we're in sync here. 1. Do you have a running Node instance on the machine you tried this in? As in, did you open a terminal and run `node --inspect` in there? It doesn't seem so, which is why you'd not see any. 2. Why do you need this extension? The expected behavior is native to Chrome, w/o extension. That extension is "option 2", it's just there to auto-open the Node-specific DevTools upon detecting a debuggable Node. See https://youtu.be/g17Iven-t3E?t=42s for an example. Best,
,
Mar 5 2018
Thank you for providing more feedback. Adding the requester to the cc list. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 5 2018
I can confirm this regression
,
Mar 5 2018
,
Mar 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f7f668f9ac80a68eb388891b1d958a85aa990c2 commit 9f7f668f9ac80a68eb388891b1d958a85aa990c2 Author: Pavel Feldman <pfeldman@chromium.org> Date: Wed Mar 07 19:58:05 2018 DevTools: Node icon doesn't display in DevTools when a debuggable Node is spawned Bug: 818508 Change-Id: Ifec83109163e18c1e358ada8a1be477b98f3e931 Reviewed-on: https://chromium-review.googlesource.com/952266 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#541535} [modify] https://crrev.com/9f7f668f9ac80a68eb388891b1d958a85aa990c2/third_party/WebKit/Source/devtools/front_end/inspector_main/InspectorMain.js
,
Mar 8 2018
Tested this issue on Mac OS 10.13.3 on the reported version 64.0.3282.140 and latest Canary 67.0.3365.0 as per comment #3. Able to reproduce this issue on the reported version 62.0.3202.94 and the issue is fixed on the latest Canary 67.0.3365.0. On installing Node and running node instance, can observe the debugger icon in Devtools. Attached is the screen shot and the test file for reference. Hence adding TE verified labels as the fix is working as intended. Thanks..
,
Mar 8 2018
// correction in comment #8. Able to reproduce this issue on the reported version 64.0.3282.140 and the issue is fixed on the latest Canary 67.0.3365.0.
,
Mar 8 2018
Astounding job everyone! Thank you!
,
Mar 20 2018
,
Mar 20 2018
The bug is marked as P3 or Feature. It should not be merged as M66 is in beta. Please contact the approriate milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 20 2018
I don't actually need to merge into M66, it is already there - added that marker by mistake. |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by sindhu.chelamcherla@chromium.org
, Mar 4 2018Labels: Needs-Triage-M64