New issue
Advanced search Search tips

Issue 818508 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

[regression] Node icon doesn't display in DevTools when a debuggable Node is spawned

Reported by christo...@delicious-insights.com, Mar 4 2018

Issue description

Chrome Version : 64.0.3282.140
OS Version: OS X 10.13.3
URLs (if applicable) :

What steps will reproduce the problem?

1. Open any URL in Chrome
2. Open the DevTools
3. On the same machine, launch a debuggable Node, e.g. `node --inspect`

What is the expected result?

It should show the Node debugger icon in the DevTools header bar almost instantly once a debuggable Node is spawned.

What happens instead of that?

No Node debugger icon shows in the DevTools header bar.

Now we have to use `about:inspect` URLs to see the Node instance (Remote Devices drawer tab won't show these, btw, which seems a bit inconsistent)

Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.140 Safari/537.36
 
Screen Shot 2018-03-04 at 15.26.22.png
257 KB View Download
Components: Platform>DevTools
Labels: Needs-Triage-M64
Cc: susan.boorgula@chromium.org
Labels: Triaged-ET Needs-Feedback
christophe@ Thanks for the issue.

Tried testing this issue on Mac OS 10.12.6 and Windows 10 on the reported version 64.0.3282.140 and the latest Canary 67.0.3361.0 by following the below steps.

1. Launched Chrome and navigated to https://nodejs.org/en/docs/inspector as shown in the attached screen shot in Comment #0.
2. Added the extension 'Node.js V8 --inspector Manager (NiM)'.
3. Opened New tab -> Devtools and clicked on the extension icon.
Couldn't observe any Debuggable node.
Attached is the screen cast for reference.

Request you to please check and confirm if anything is missed from our end in triaging the issue.

Also request you to provide a screen cast of the steps followed to reproduce the issue which will help in better understanding.

Thanks..
818508.mp4
1.7 MB View Download
Hey Susan@,

I'm not sure we're in sync here.

1. Do you have a running Node instance on the machine you tried this in? As in, did you open a terminal and run `node --inspect` in there? It doesn't seem so, which is why you'd not see any.

2. Why do you need this extension? The expected behavior is native to Chrome, w/o extension. That extension is "option 2", it's just there to auto-open the Node-specific DevTools upon detecting a debuggable Node. See https://youtu.be/g17Iven-t3E?t=42s for an example.

Best,
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 5 2018

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: dgozman@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: [regression] Node icon doesn't display in DevTools when a debuggable Node is spawned (was: Node debugger icon doesn't show up anymore in DevTools header bar when a debuggable Node is spawned)
I can confirm this regression
Cc: dgozman@chromium.org
Owner: pfeldman@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f7f668f9ac80a68eb388891b1d958a85aa990c2

commit 9f7f668f9ac80a68eb388891b1d958a85aa990c2
Author: Pavel Feldman <pfeldman@chromium.org>
Date: Wed Mar 07 19:58:05 2018

DevTools: Node icon doesn't display in DevTools when a debuggable Node is spawned

Bug:  818508 
Change-Id: Ifec83109163e18c1e358ada8a1be477b98f3e931
Reviewed-on: https://chromium-review.googlesource.com/952266
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541535}
[modify] https://crrev.com/9f7f668f9ac80a68eb388891b1d958a85aa990c2/third_party/WebKit/Source/devtools/front_end/inspector_main/InspectorMain.js

Labels: TE-Verified-M67 TE-Verified-67.0.3365.0
Tested this issue on Mac OS 10.13.3 on the reported version 64.0.3282.140 and latest Canary 67.0.3365.0 as per comment #3.
Able to reproduce this issue on the reported version 62.0.3202.94 and the issue is fixed on the latest Canary 67.0.3365.0.

On installing Node and running node instance, can observe the debugger icon in Devtools.
Attached is the screen shot and the test file for reference.

Hence adding TE verified labels as the fix is working as intended.

Thanks..
818508.png
60.9 KB View Download
// correction in comment #8.
Able to reproduce this issue on the reported version 64.0.3282.140 and the issue is fixed on the latest Canary 67.0.3365.0.
Astounding job everyone! Thank you!
Labels: Merge-Request-66
Status: Fixed (was: Assigned)
Project Member

Comment 12 by sheriffbot@chromium.org, Mar 20 2018

Labels: -Merge-Request-66 Merge-Reject-66 Hotlist-Merge-Reject
The bug is marked as P3 or Feature. It should not be merged as M66 is in beta. 
Please contact the approriate milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Reject -Merge-Reject-66
I don't actually need to merge into M66, it is already there - added that marker by mistake.

Sign in to add a comment