New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 818451 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Task
Q2



Sign in to add a comment

Make keyboard work for tab grid

Project Member Reported by edchin@chromium.org, Mar 3 2018

Issue description

Make keyboard work for tab grid


 
Cc: cma...@chromium.org
Labels: -Type-Bug medium Type-Task

Comment 3 by edchin@chromium.org, Mar 15 2018

Labels: Q2 S-Tab-Grid-Polish
Labels: -Pri-2 Pri-0
Project Member

Comment 5 by sheriffbot@chromium.org, Apr 10 2018

Pri-0 bugs are critical regressions or serious emergencies, and this bug has not been updated in three days. Could you please provide an update, or adjust the priority to a more appropriate level if applicable?

If a fix is in active development, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by marq@chromium.org, Apr 16 2018

Labels: Disable-Nags

Comment 7 by edchin@chromium.org, Jun 26 2018

Status: Started (was: Assigned)

Comment 8 by edchin@chromium.org, Jun 27 2018

CL in-flight.

Comment 9 by edchin@chromium.org, Jun 27 2018

Labels: -Pri-0 Pri-1
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c670dc802bbe691ffef1790b26f50881684d73f

commit 2c670dc802bbe691ffef1790b26f50881684d73f
Author: edchin <edchin@chromium.org>
Date: Wed Jun 27 16:48:47 2018

[ios] Keyboard shortcuts in tab grid

This CL adds keyboard shortcuts related to opening tabs to the tab grid.
- Command + n = open new (regular) tab
- Command + Shift + n = open new incognito tab
- Command + t = open new tab in current window

Bug:  818451 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iae029bf53f5a2d71c2fe569b6481ee9eeec98ef0
Reviewed-on: https://chromium-review.googlesource.com/1116257
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570805}
[modify] https://crrev.com/2c670dc802bbe691ffef1790b26f50881684d73f/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm

Verified the three shortcuts from tab grid and working correctly.
Device: iPad Pro 10.5"
iOS: 11.4.1
M69.0.3480.0 canary.
Labels: Proj-UIRefresh
Is there more than needs to happen here?
Labels: M-69
With the remaining cmd-t issue tracked in  crbug.com/805106 , can this be closed?
Status: Fixed (was: Started)
Labels: UIRefresh-NoMerge

Sign in to add a comment