New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 818406 link

Starred by 1 user
Status: Verified
Owner:
xixuan@chromium.org
Closed: Mar 2018
Cc:
█ pho...@chromium.org
dgarr...@chromium.org
█ nxia@chromium.org
pprabhu@chromium.org
█ bhthompson@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Manifest updates for infra/test_analyzer failing M66 branch

Project Member Reported by josa...@chromium.org, Mar 3 2018 
M66 branch point 10452.0.0 not able to branch due manifest (full.xml) dependencies on infra/test_analyzer 

Error output 
o https://chromium.googlesource.com/chromiumos/infra/test_analyzer
 ! [remote rejected] 41da080c56284d0d12ec081b069262deee3d0148 -> release-R66-10452.B (prohibited by Gerrit: create not permitted for refs/heads/release-R66-10452.B)
error: failed to push some refs to 'https://chromium.googlesource.com/chromiumos/infra/test_analyzer'

cwd=/usr/local/google/home/josafat/myrepos/trybot-internal/infra/test_analyzer
Traceback (most recent call last):
  File "/usr/local/google/home/josafat/myrepos/tot/chromite/lib/parallel.py", line 602, in TaskRunner
    task(*x, **task_kwargs)
  File "/usr/local/google/home/josafat/myrepos/tot/chromite/lib/parallel.py", line 800, in <lambda>
    fn = lambda idx, task_args: out_queue.put((idx, task(*task_args)))
  File "/usr/local/google/home/josafat/myrepos/tot/chromite/cbuildbot/stages/branch_stages.py", line 233, in _ProcessCheckout
    force=self._run.options.force_create)
  File "/usr/local/google/home/josafat/myrepos/tot/chromite/cbuildbot/stages/branch_stages.py", line 143, in _CopyBranch
    force=force)
  File "/usr/local/google/home/josafat/myrepos/tot/chromite/cbuildbot/stages/branch_stages.py", line 74, in _RunPush
    skip=self.skip_remote_push)
  File "/usr/local/google/home/josafat/myrepos/tot/chromite/lib/git.py", line 1258, in GitPush
    RunGit(git_repo, cmd, retry=retry, capture_output=capture_output, **kwargs)
  File "/usr/local/google/home/josafat/myrepos/tot/chromite/lib/git.py", line 829, in RunGit
    ['git'] + cmd, **kwargs)
  File "/usr/local/google/home/josafat/myrepos/tot/chromite/lib/retry_util.py", line 115, in GenericRetry
    ret = functor(*args, **kwargs)
  File "/usr/local/google/home/josafat/myrepos/tot/chromite/lib/cros_build_lib.py", line 623, in RunCommand
    raise RunCommandError(msg, cmd_result)
RunCommandError: return code: 1; command: git push cros 41da080c56284d0d12ec081b069262deee3d0148:refs/heads/release-R66-10452.B --force
remote: Processing changes: refs: 1, done
To https://chromium.googlesource.com/chromiumos/infra/test_analyzer
 ! [remote rejected] 41da080c56284d0d12ec081b069262deee3d0148 -> release-R66-10452.B (prohibited by Gerrit: create not permitted for refs/heads/release-R66-10452.B)
error: failed to push some refs to 'https://chromium.googlesource.com/chromiumos/infra/test_analyzer'

I suspect this is due test_analyzer added to full.xml but infra/test_analyzer not merged 

- Manifest CL -> 
infra/test_analyzer CL -> https://chromium-review.googlesource.com/#/c/chromiumos/infra/test_analyzer/+/944621/ -- (Merged) 

- test_analyzer -> https://chromium-review.googlesource.com/#/c/chromiumos/infra/test_analyzer/+/944621/  -- (Pending)

Not sure there is a clean way to solve (align the reference) for the manifest so we can branch, maybe hacking the manifest to remove the reference or change branch point 

Xiyuan/Don to see if any other alternatives

Comment 1 by xiy...@chromium.org, Mar 3 2018

Owner: xixuan@chromium.org
Think it is xixuan@ :)

Comment 2 by josa...@chromium.org, Mar 3 2018

Cc: pho...@chromium.org
right, adding Paul too

Comment 5 by nxia@chromium.org, Mar 3 2018 

I think it's because the repo was added to manifest but not configured correctly, so the 'git push' failed with permission exceptions. 
to solve this, either revert the CLs in #4 and fix the repo config later, or fix the repo config so that 'git push' won't fail with permission failures.

Comment 6 by bhthompson@google.com, Mar 3 2018 

When this repo was created it was not given the proper permission set, it inherits from All-projects and not chromiumos.

I have corrected this so it should now be manipulable by the builders and branching tools. I suspect branching will work now.

Comment 7 by xixuan@chromium.org, Mar 3 2018 

Re #6, thanks a lot Bernie! Could you show me how to set the proper permission for it?

Comment 8 by bhthompson@google.com, Mar 3 2018 

Sure, after the project/repo is created you need to go to the access page for the project/repo.

https://chromium-review.googlesource.com/#/admin/projects/chromiumos/infra/test_analyzer,access

This needs to be set to chromiumos on this Gerrit instance, on the chrome-internal Gerrit this needs to be set to chromeos. This provides ACL separation between OS specific and other git repos (e.g. browser stuff), the default ACL of all projects appears to be insufficient for our infrastructure.

Comment 9 by xixuan@chromium.org, Mar 13 2018

Status: Verified (was: Assigned)
Re #8, Thanks!

Close this bug since it's verified.
►

Sign in to add a comment