Starting in M64 Smart Lock does not log in when hitting Enter |
|||
Issue descriptionWorks fine in M63, regression started in M64 What steps will reproduce the problem? (1) Enable Smart Lock (2) Lock screen (3) Try to unlock by hitting enter when the icon is green What is the expected result? Unlocks What happens instead? Says wrong password (works if you tap the image with the mouse or finger)
,
Apr 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3bc4da52338572d88e2e608068ee6e6f483faa0 commit f3bc4da52338572d88e2e608068ee6e6f483faa0 Author: James Hawkins <jhawkins@chromium.org> Date: Mon Apr 16 17:16:30 2018 ash Login screen: Fix a regression with SmartLock login. In previous implementations of the login screen, a user with SmartLock enabled could press return with an empty password field in order to authenticate. This behavior appears to not have been carried over in the newer Views implementation. The fix is to special case the auth attempt and divert the attempt to the SmartLock flow in the case where the user has tap-to-unlock and the password field is empty. R=xiyuan@chromium.org Bug: 818400 Test: LoginAuthUserViewUnittest.PressReturnWithTapToUnlockEnabled Change-Id: I1ecaba0d285fd43b231ca8028c19b0682f073b77 Reviewed-on: https://chromium-review.googlesource.com/1013398 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#551016} [modify] https://crrev.com/f3bc4da52338572d88e2e608068ee6e6f483faa0/ash/login/ui/login_auth_user_view.cc [modify] https://crrev.com/f3bc4da52338572d88e2e608068ee6e6f483faa0/ash/login/ui/login_auth_user_view_unittest.cc
,
Apr 16 2018
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f3bc4da52338572d88e2e608068ee6e6f483faa0 commit f3bc4da52338572d88e2e608068ee6e6f483faa0 Author: James Hawkins <jhawkins@chromium.org> Date: Mon Apr 16 17:16:30 2018 ash Login screen: Fix a regression with SmartLock login. In previous implementations of the login screen, a user with SmartLock enabled could press return with an empty password field in order to authenticate. This behavior appears to not have been carried over in the newer Views implementation. The fix is to special case the auth attempt and divert the attempt to the SmartLock flow in the case where the user has tap-to-unlock and the password field is empty. R=xiyuan@chromium.org Bug: 818400 Test: LoginAuthUserViewUnittest.PressReturnWithTapToUnlockEnabled Change-Id: I1ecaba0d285fd43b231ca8028c19b0682f073b77 Reviewed-on: https://chromium-review.googlesource.com/1013398 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#551016} [modify] https://crrev.com/f3bc4da52338572d88e2e608068ee6e6f483faa0/ash/login/ui/login_auth_user_view.cc [modify] https://crrev.com/f3bc4da52338572d88e2e608068ee6e6f483faa0/ash/login/ui/login_auth_user_view_unittest.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by jhawkins@chromium.org
, Apr 14 2018Status: Started (was: Untriaged)