New issue
Advanced search Search tips

Issue 818397 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Harmonize Cocoa ExtensionPopup with Views ExtensionPopup

Project Member Reported by robliao@chromium.org, Mar 3 2018

Issue description

ExtensionPopup in Cocoa shows only after the popup has a chance to layout. The Views version shows up much before that and often resizes.

This issue covers this harmonization as well as tests that need to be updated as a result of the change in when the views ExtensionPopup appears.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/627439f728a706d765ace0ef07f7cf4e033ee6fb

commit 627439f728a706d765ace0ef07f7cf4e033ee6fb
Author: Robert Liao <robliao@chromium.org>
Date: Wed Mar 07 23:12:27 2018

Rename browser_action_test_util_views_mac.mm to browser_action_test_util_views_cocoa.mm

This allows browser_action_test_util_views_mac.mm to be used in the
future for shared code between Mac Views and Aura Views.

BUG=818397

Change-Id: I3c0937216233ffbbe1933ad3cbb423da1010feb2
Reviewed-on: https://chromium-review.googlesource.com/953245
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541632}
[modify] https://crrev.com/627439f728a706d765ace0ef07f7cf4e033ee6fb/chrome/browser/ui/BUILD.gn
[rename] https://crrev.com/627439f728a706d765ace0ef07f7cf4e033ee6fb/chrome/browser/ui/cocoa/extensions/browser_action_test_util_views_cocoa.mm

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 9 2018

Labels: Proj-MacViews
Labels: Group-Views_Regressions_from_Cocoa

Sign in to add a comment