Chrome crashes if you try to set a url for a folder through an extension
Reported by
gabr...@gsdb.net,
Mar 3 2018
|
|||||||||
Issue description
UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.167 Safari/537.36
Steps to reproduce the problem:
1. Use the chrome.bookmarks API to create a folder and store its id;
2. Try to change its url to anything (even though this does not make sense).
3. Chrome crashes
Code:
chrome.bookmarks.create({title: 'empty folder'}, function(bookmark) {
var id = bookmark.id;
chrome.bookmarks.update(id, {url: 'https://example.com'}, function() {
});
});
** Crashes **
What is the expected behavior?
Throw an exception
What went wrong?
Chrome crashes on Linux (segfault) and hangs on Windows/macOS
Did this work before? No
Does this work in other browsers? Yes
Chrome version: 64.0.3282.167 Channel: n/a
OS Version: Ubuntu 16.04.3
Flash Version:
Tested with:
Chrome 49.0.2623.112 on Windows XP [!]
Chrome Stable 64.0.3282.167 on Ubuntu 16.04.3
Chrome Dev 66.0.3346.8 on Ubuntu 16.04.3
Chrome 63.0.3239.108 on macOS 10.12
Canary 66.0.3359.0 on Windows 7
,
Mar 4 2018
,
Mar 5 2018
Able to reproduce this issue on latest stable 64.0.3282.186, on latest beta 65.0.3325.106 and latest canary 66.0.3361.0 using Ubuntu 14.04, Windows 10 and Mac 10.13.3. i.e; On clicking on button chrome becomes and then crashes. This issue is seen from M-60. Hence considering this issue as Non-Regression and marking as Untriaged. Thanks!
,
Mar 9 2018
Istiaque: Seems you have delved into Bookmarks code before. Can you take this?
,
Mar 9 2018
I'll take a look when I get a chance, since this involves a crash, no good. Feel free to steal it if anyone's interested (right away).
,
Mar 10 2018
,
Mar 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75b56e53721c0ee6ee1f1854ad6ee4449540e4de commit 75b56e53721c0ee6ee1f1854ad6ee4449540e4de Author: Istiaque Ahmed <lazyboy@chromium.org> Date: Mon Mar 12 05:30:49 2018 [Extensions/Bookmarks]: Do not attempt to set URL of a folder. Bug: 818395 Change-Id: I794bd2ebabceab3724ca6e2ff6f9b93578f1cf84 Reviewed-on: https://chromium-review.googlesource.com/957976 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542425} [modify] https://crrev.com/75b56e53721c0ee6ee1f1854ad6ee4449540e4de/chrome/browser/extensions/api/bookmarks/bookmark_api_constants.cc [modify] https://crrev.com/75b56e53721c0ee6ee1f1854ad6ee4449540e4de/chrome/browser/extensions/api/bookmarks/bookmark_api_constants.h [modify] https://crrev.com/75b56e53721c0ee6ee1f1854ad6ee4449540e4de/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc [add] https://crrev.com/75b56e53721c0ee6ee1f1854ad6ee4449540e4de/chrome/browser/extensions/api/bookmarks/bookmarks_api_unittest.cc [modify] https://crrev.com/75b56e53721c0ee6ee1f1854ad6ee4449540e4de/chrome/test/BUILD.gn
,
Mar 12 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 Deleted