New issue
Advanced search Search tips

Issue 818387 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"http/tests/webfont/slow-loading.html" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Mar 3 2018

Issue description

"http/tests/webfont/slow-loading.html" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyLwsSBUZsYWtlIiRodHRwL3Rlc3RzL3dlYmZvbnQvc2xvdy1sb2FkaW5nLmh0bWwM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Components: Blink>WebFonts
Labels: -Sheriff-Chromium
Cc: ksakamoto@chromium.org
Owner: toyoshim@chromium.org
Status: Started (was: Untriaged)
This test needs 5 seconds to finish, and timeout was set to 6 seconds.
I took some examples from failed tests, and all failure cases were due to timeout.

Probably, we need to adjust timeout values in the test.

Will send a CL to ksakamoto for a review.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f18ed2cbb970994851aee07953b00a4ef6c7e6b

commit 6f18ed2cbb970994851aee07953b00a4ef6c7e6b
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Sat Mar 10 02:15:25 2018

WebFonts: adjust test timing to mitigate flakiness

Current slow-loading.html requires at least 5 seconds to finish.
This may easily exceeds 6 seconds timeout of LayoutTests.

To stabilize the test, let me change the result check timing from
5 seconds to 4 seconds.

Bug:  818387 
Change-Id: Id6b9b62c8bda3187850b71c57b3895ebca524bf2
Reviewed-on: https://chromium-review.googlesource.com/956828
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542318}
[modify] https://crrev.com/6f18ed2cbb970994851aee07953b00a4ef6c7e6b/third_party/WebKit/LayoutTests/http/tests/webfont/slow-loading-expected.html
[modify] https://crrev.com/6f18ed2cbb970994851aee07953b00a4ef6c7e6b/third_party/WebKit/LayoutTests/http/tests/webfont/slow-loading.html

Status: Fixed (was: Started)
no failure for two days.

Sign in to add a comment