WebVR presentation promise flakily resolves during DON in WAA |
||||
Issue descriptionWebVrTransitionTest#testPresentationPromiseUnresolvedDuringDon__WebappActivity is quite flaky according to https://test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&testType=chrome_public_test_vr_apk-pixelxl-ddview-nougat-donenabled. The issue is that a significant portion of the time, the promise is resolving while we're in the DON flow, which shouldn't ever happen. This seems to be isolated to webapps - ChromeTabbedActivity and CustomTabActivity function as expected.
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/548b44e18f8f6d640fa4e722ce45a349e7f256d2 commit 548b44e18f8f6d640fa4e722ce45a349e7f256d2 Author: bsheedy <bsheedy@chromium.org> Date: Wed Jun 13 18:04:39 2018 Ensure VR tests start outside of VR Causes all VR tests to check if any VR-related activities are in the foreground before starting, and if so, background them and wait for VrCore to think that it's no longer in VR. This addresses two known areas of flakiness: testPresentationPromisedUnresolvedDuringDon* tests and testTrustedIntentAllowsAutoPresent, and potentially reduces flakiness elsewhere. Bug: 818369 Change-Id: I7629bce1541cba961cf5dccf19b7c9aa29b500af Reviewed-on: https://chromium-review.googlesource.com/1098394 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#566912} [modify] https://crrev.com/548b44e18f8f6d640fa4e722ce45a349e7f256d2/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/rules/ChromeTabbedActivityVrTestRule.java [modify] https://crrev.com/548b44e18f8f6d640fa4e722ce45a349e7f256d2/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/rules/CustomTabActivityVrTestRule.java [modify] https://crrev.com/548b44e18f8f6d640fa4e722ce45a349e7f256d2/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/rules/WebappActivityVrTestRule.java [modify] https://crrev.com/548b44e18f8f6d640fa4e722ce45a349e7f256d2/chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/util/VrTestRuleUtils.java
,
Jun 13 2018
,
Jul 4
,
Aug 29
|
||||
►
Sign in to add a comment |
||||
Comment 1 by ericde@google.com
, May 18 2018