New issue
Advanced search Search tips

Issue 818366 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Chrome OS OOBE: Update sync disclosure after UI review.

Project Member Reported by alemate@chromium.org, Mar 3 2018

Issue description

Nee to update screen to match the new mocks.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 3 2018

Labels: Merge-Request-66
Status: Fixed (was: Started)
Project Member

Comment 3 by sheriffbot@chromium.org, Mar 4 2018

Labels: -Merge-Request-66 Merge-Review-66 Hotlist-Merge-Review
This bug requires manual review: There is .grd file changes and we are only 43 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-66 Merge-Approved-66
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 6 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c26212a5bbee3a659bcd7f816e293f17f364dccf

commit c26212a5bbee3a659bcd7f816e293f17f364dccf
Author: Alexander Alekseev <alemate@chromium.org>
Date: Tue Mar 06 21:26:13 2018

Chrome OS OOBE: Update Sync settings screen after UI review.

This Cl doesn't include the bindings, only the UI.

TBR=alemate@chromium.org

(cherry picked from commit 3eaeb8ca9f14ccc7e4b99fd5f46f7211c7c984ad)

Bug:  818366 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4d07d68700e60e31a1b1260b48ea40c511c27be3
Reviewed-on: https://chromium-review.googlesource.com/947567
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#540734}
Reviewed-on: https://chromium-review.googlesource.com/952102
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#39}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/c26212a5bbee3a659bcd7f816e293f17f364dccf/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/c26212a5bbee3a659bcd7f816e293f17f364dccf/chrome/browser/chromeos/login/screens/sync_consent_screen.cc
[modify] https://crrev.com/c26212a5bbee3a659bcd7f816e293f17f364dccf/chrome/browser/resources/chromeos/login/sync_consent.css
[modify] https://crrev.com/c26212a5bbee3a659bcd7f816e293f17f364dccf/chrome/browser/resources/chromeos/login/sync_consent.html
[modify] https://crrev.com/c26212a5bbee3a659bcd7f816e293f17f364dccf/chrome/browser/resources/chromeos/login/sync_consent.js
[modify] https://crrev.com/c26212a5bbee3a659bcd7f816e293f17f364dccf/chrome/browser/ui/webui/chromeos/login/sync_consent_screen_handler.cc

Status: Verified (was: Fixed)
10452.54.0, 66.0.3359.102 beta-channel

Sign in to add a comment