Test on large screen fails mus_unit_test but passes on normal sized screen |
||||
Issue descriptionI've got two similar tests that are passing unit_tests, one is passing mus_unit_tests, but one fails mus_unit_tests. The difference is screen size -- the second one is a large display. Could you help me figure out why the second is failing? Test change here: https://chromium-review.googlesource.com/c/chromium/src/+/947210/2/chrome/browser/chromeos/accessibility/select_to_speak_event_rewriter_unittest.cc: Note that two similar tests are changed in the same way. Example failure: https://ci.chromium.org/buildbot/tryserver.chromium.chromiumos/linux-chromeos-rel/72020: Only one of those tests actually fails. And they both pass unit_tests.
,
Mar 20 2018
,
Mar 28 2018
,
Mar 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a8351c261c234c106733e2a595e99def0460d2f9 commit a8351c261c234c106733e2a595e99def0460d2f9 Author: Scott Violet <sky@chromium.org> Date: Wed Mar 28 22:43:36 2018 chromeos: gets SelectToSpeakEventRewriterTest working with mus This test installs an EventHandler and asserts that events are received. The test also triggers resizing a WindowTreeClient, resulting in holding some events, and the test failing. Disable holding events so the test works with mus. BUG= 818362 TEST=test only change Change-Id: I1093faa1fc48f59954d9352c9a972e24272754e8 Reviewed-on: https://chromium-review.googlesource.com/983010 Reviewed-by: Fady Samuel <fsamuel@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#546632} [modify] https://crrev.com/a8351c261c234c106733e2a595e99def0460d2f9/chrome/browser/chromeos/accessibility/select_to_speak_event_rewriter_unittest.cc
,
Mar 28 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by sky@chromium.org
, Mar 20 2018Labels: -Pri-3 M-67 Pri-2