catmullings@ - could you PTAL?  My first bisecting attempt pointed at your r530015 as the culprit.  I'll try running the bisect again to double check in a few minutes.

+abdulsyed@ in case this turns out to be a M65 blocker - please triage.

+govind for M65.

We're planning to cut M65 Stable RC on Monday morning. Is this M65 stable blocker? 

I run another bisect (with slightly different starting range) and it also came back pointing at  https://chromium.googlesource.com/chromium/src/+log/1a7bde518aeb8c80190401a79b11020a38c087e8..4d546d6ecc0e621a0d08f804a9e25c4427055740.  This increases my confidence that this has regressed after r530015

RE: #c4

I don't the exact criteria for considering something a stable blocker, but let me try to evaluate what I think we know:

- Users of the stable version of Hangouts Chrome Extension (but not Hangouts Chrome App) will see an extra window (with NTP) opened after their machine comes out of sleep (sometimes? always? - not sure...).

- This bug is not limited to Site Isolation:
    ToT with isolate-origins: repro
    ToT with no site isolation: repro
    65.0.3325.106 with isolate-origins: repro
    65.0.3325.106 with no site isolation: repro
    64.0.3282.186 with isolate-origins: no repro

rdevlin.cronin@ - could you PTAL from extensions side (I hear that catmullings@ might no longer work on Chrome).

Thanks for the investigation, lukasza@!

catmullings@ is no longer on the team, so I'll take this one over.

r530015 was fixing a relatively low-priority bug (794472), so if this is a big concern, I'd prefer to revert r530015 on 65 and 66 and reland it with the fix, rather than try to merge a fix back.

Re severity, the hangouts extension is reasonably popular, so if we can avoid regressing on stable, it'd probably be worthwhile.  I don't think this would warrant a respin of stable, though.

If the revert patches cleanly, should we go through with it?  Or deem it too late in the release process to merge?

If  r530015 is safe revert to merge to M65/M66, pls try to land the revert in trunk. If revert looks good in canary, then pls request a merge to M65 and M66 on Monday morning. Thank you.

Tagging as "RBS" for tracking purpose.

On it!

Thank you!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f16ef54406c24f856c79546dcef4937ce580b696

commit f16ef54406c24f856c79546dcef4937ce580b696
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Sat Mar 03 02:15:37 2018

Revert "Extensions: Navigate to default chrome page on extension unload"

This reverts commit 4d546d6ecc0e621a0d08f804a9e25c4427055740.

Reason for revert: this patch caused a bug where we leave extraneous
windows around when coming out of sleep.

TBR=sky@chromium.org (c/b/ui/browser - clean revert)

Bug:  818351 
Change-Id: I3cf6d60a4588b36619dc4e461c3b8cf29722d6cd
Reviewed-on: https://chromium-review.googlesource.com/947473
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540720}
[delete] https://crrev.com/6c632568255e604b8f76d1e1df59b81868d3e580/chrome/browser/extensions/extension_web_ui_browsertest.cc
[modify] https://crrev.com/f16ef54406c24f856c79546dcef4937ce580b696/chrome/browser/ui/browser.cc
[modify] https://crrev.com/f16ef54406c24f856c79546dcef4937ce580b696/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/f16ef54406c24f856c79546dcef4937ce580b696/chrome/test/BUILD.gn

Pls use 67.0.3360.0 or higher to verify this bug. Thank you.

The NextAction date has arrived: 2018-03-05

Tested this issue on Debian Rodate using chrome-67.0.3362.0 as per below steps:
Steps:
-----
1.Installed Hangouts Chrome *extension*  with this id:
 nckgahadagoaajjgafhacjanaoiihapd
2.Navigated to Chrome://extensions & search for hangouts & click on details option
Observe the version of the installed extension reported on chrome://extensions: 2018.123.418.2
3.Sign-in with test account
4.Navigated to chrome://extensions,
5.Inspect element & type below in consol
chrome.runtime.reload()
6.Focus the main extension window and typed the following keyboard inputs: Ctrl + Shift + (Up, Up, Down, Down, Lelf, Right, Lelf, Right,)
no output observed & not observed any other windows to proceed

Please clarify the remaining steps to proceed further.

Thanks in advance..!

I haven't earlier tried reproing the problem on Windows, so first of all, I confirmed that I am able to repro the problem on Windows, in Chrome Beta - 65.0.3325.106.  I reproed the problem by executing |chrome.runtime.reload()| in the extensions background page (option 3.1 from the original repro steps).  I have not tried the keyboard chord (i.e. option 3.2).

Commit f16ef544... initially landed in 67.0.3360.0.  Therefore, it is expected that (as pointed out in #c16) the problem doesn't repro in 67.0.3362.0.  I can confirm that I get no repro in 67.0.3362.0 Canary on Windows.  Based on this I think we can mark the bug as fixed and request a merge to M65 and M66.


RE: #c16: Please clarify the remaining steps to proceed further.

I am not sure how I can help / what needs clarification.  I can consistently repro in 65.0.3325.106 using the original repro steps (using the 3.1 option;  I have not tried the 3.2 option) - please let me know if the repro steps don't work and don't expose the bug *before* 67.0.3360.0.  FWIW, I think the results in #c16 confirm that the fix from #c12 worked fine and got rid of the bug.

This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

This bug requires manual review: We are only 0 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Verified that this is fixed on the latest canary.  Requesting merge to 66, 65.

This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

This bug requires manual review: We are only 0 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Thank you Devlin and  lukasza@.
Approving merge to M65 branch 3325 and  M66 branch 3359 based on comments #17 and #22. 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/68d200043754cf9e431b0c5e34d8760cae5ab640

commit 68d200043754cf9e431b0c5e34d8760cae5ab640
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Mon Mar 05 17:47:16 2018

Revert "Extensions: Navigate to default chrome page on extension unload"

This reverts commit 4d546d6ecc0e621a0d08f804a9e25c4427055740.

Reason for revert: this patch caused a bug where we leave extraneous
windows around when coming out of sleep.

TBR=rdevlin.cronin@chromium.org, sky@chromium.org (c/b/ui/browser - clean revert)

(cherry picked from commit f16ef54406c24f856c79546dcef4937ce580b696)

Bug:  818351 
Change-Id: I3cf6d60a4588b36619dc4e461c3b8cf29722d6cd
Reviewed-on: https://chromium-review.googlesource.com/947473
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#540720}
Reviewed-on: https://chromium-review.googlesource.com/949306
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#658}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[delete] https://crrev.com/017a8bd1bab7b24d44113b7a6c65ca4adbfa3172/chrome/browser/extensions/extension_web_ui_browsertest.cc
[modify] https://crrev.com/68d200043754cf9e431b0c5e34d8760cae5ab640/chrome/browser/ui/browser.cc
[modify] https://crrev.com/68d200043754cf9e431b0c5e34d8760cae5ab640/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/68d200043754cf9e431b0c5e34d8760cae5ab640/chrome/test/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af8fa3a0071bf435021c6acbbb081f11f6b96691

commit af8fa3a0071bf435021c6acbbb081f11f6b96691
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Mon Mar 05 17:51:22 2018

Revert "Extensions: Navigate to default chrome page on extension unload"

This reverts commit 4d546d6ecc0e621a0d08f804a9e25c4427055740.

Reason for revert: this patch caused a bug where we leave extraneous
windows around when coming out of sleep.

TBR=rdevlin.cronin@chromium.org, sky@chromium.org (c/b/ui/browser - clean revert)

(cherry picked from commit f16ef54406c24f856c79546dcef4937ce580b696)

Bug:  818351 
Change-Id: I3cf6d60a4588b36619dc4e461c3b8cf29722d6cd
Reviewed-on: https://chromium-review.googlesource.com/947473
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#540720}
Reviewed-on: https://chromium-review.googlesource.com/949307
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#13}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[delete] https://crrev.com/ac163c647d2e3771e215e8a03f14d8e04ece02d6/chrome/browser/extensions/extension_web_ui_browsertest.cc
[modify] https://crrev.com/af8fa3a0071bf435021c6acbbb081f11f6b96691/chrome/browser/ui/browser.cc
[modify] https://crrev.com/af8fa3a0071bf435021c6acbbb081f11f6b96691/chrome/browser/ui/browser_browsertest.cc
[modify] https://crrev.com/af8fa3a0071bf435021c6acbbb081f11f6b96691/chrome/test/BUILD.gn