New issue
Advanced search Search tips

Issue 818330 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

compositor-touch-hit-rects-fullscreen-video-controls.html isn't guarding against regression

Project Member Reported by bokan@chromium.org, Mar 2 2018

Issue description

Chrome Version       : 66.0.3355.0

this test is a not a good guard against the regression from  issue 372314 . Since the document layer is detached we don't actually check that we correctly calculate the touch rects on the video controls. It appears that the media player has since been modified to not require touch handlers and the expectation reflects that. As such, this test can't tell the difference between the controls not having touch handlers and Blink failing to calculate touch handler rects.

The test should be replaced by one that actually tries to use the media player controls via simulated touches and confirms it affects the video.
 

Comment 1 by bokan@chromium.org, Mar 8 2018

Status: Available (was: Untriaged)

Sign in to add a comment