New issue
Advanced search Search tips

Issue 818329 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

[Select-to-Speak] When large mouse cursor is enabled, or on some devices, mouse doesn't move when dragging focus rect in STS

Project Member Reported by katie@chromium.org, Mar 2 2018

Issue description

Potentially due to eventrewriter change from December
 

Comment 1 by katie@chromium.org, Mar 2 2018

Cc: lpalmaro@chromium.org
Labels: Merge-Request-66 M66
This bug probably started in M65 and is certainly in M66+.
Labels: ReleaseBlock-Stable M-66 M-65
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f6ebbb1d897c9ead6e241195f8604b412bb4b17

commit 8f6ebbb1d897c9ead6e241195f8604b412bb4b17
Author: Katie D <katie@chromium.org>
Date: Sat Mar 03 01:55:28 2018

Fix compatibility between Select-to-Speak and large mouse cursor.

The event rewriter needs to allow mouse movement events to pass even
when those events are used by Select-to-Speak. It should only cancel
mouse click events used by Select-to-Speak.

Another solution would be to re-write all used "drag" events to be
simply "move" events, which may reduce the likelyhood that these
events will be used by any other part of Chrome / Chrome OS besides
Select-to-Speak and drawing the mouse.

This bug also impacted some devices (like snappy) even without
large mouse cursor on.

Note: The additional "drag" and "move" events were manually tested
and do not appear to cause any behavior problems on tabs, the
launcher, system windows, etc.

Bug:  818329 
Change-Id: I466a15a0f7a5ba0abe4f082a9cfb9b59760d690c
Reviewed-on: https://chromium-review.googlesource.com/947210
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540714}
[modify] https://crrev.com/8f6ebbb1d897c9ead6e241195f8604b412bb4b17/chrome/browser/chromeos/accessibility/select_to_speak_event_rewriter.cc
[modify] https://crrev.com/8f6ebbb1d897c9ead6e241195f8604b412bb4b17/chrome/browser/chromeos/accessibility/select_to_speak_event_rewriter_unittest.cc

Comment 4 by katydek@google.com, Mar 3 2018

Labels: -M65 -M66 Merge-Request-65
Project Member

Comment 5 by sheriffbot@chromium.org, Mar 3 2018

Labels: -Merge-Request-65 Merge-Review-65 Hotlist-Merge-Review
This bug requires manual review: We are only 2 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, Mar 4 2018

Labels: -Merge-Request-66 Merge-Approved-66 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
I like the update but my Google processor is stopping suddenly

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 5 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac163c647d2e3771e215e8a03f14d8e04ece02d6

commit ac163c647d2e3771e215e8a03f14d8e04ece02d6
Author: Katie D <katie@chromium.org>
Date: Mon Mar 05 17:36:43 2018

Merge to M66: Fix compatibility between Select-to-Speak and large mouse cursor.

The event rewriter needs to allow mouse movement events to pass even
when those events are used by Select-to-Speak. It should only cancel
mouse click events used by Select-to-Speak.

Another solution would be to re-write all used "drag" events to be
simply "move" events, which may reduce the likelyhood that these
events will be used by any other part of Chrome / Chrome OS besides
Select-to-Speak and drawing the mouse.

This bug also impacted some devices (like snappy) even without
large mouse cursor on.

Note: The additional "drag" and "move" events were manually tested
and do not appear to cause any behavior problems on tabs, the
launcher, system windows, etc.

TBR=dmazzoni@chromium.org

Bug:  818329 
Change-Id: I466a15a0f7a5ba0abe4f082a9cfb9b59760d690c
Reviewed-on: https://chromium-review.googlesource.com/947210
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#540714}(cherry picked from commit 8f6ebbb1d897c9ead6e241195f8604b412bb4b17)
Reviewed-on: https://chromium-review.googlesource.com/949079
Reviewed-by: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#12}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/ac163c647d2e3771e215e8a03f14d8e04ece02d6/chrome/browser/chromeos/accessibility/select_to_speak_event_rewriter.cc
[modify] https://crrev.com/ac163c647d2e3771e215e8a03f14d8e04ece02d6/chrome/browser/chromeos/accessibility/select_to_speak_event_rewriter_unittest.cc

Labels: -Hotlist-Merge-Review -Merge-Review-65 Merge-Approved-65
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 5 2018

Labels: -merge-approved-65 merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a269719d5ad444bbbf46eb32cf685e715a08742

commit 9a269719d5ad444bbbf46eb32cf685e715a08742
Author: Katie D <katie@chromium.org>
Date: Mon Mar 05 18:53:35 2018

Merge to M65: Fix compatibility between Select-to-Speak and large mouse cursor.

The event rewriter needs to allow mouse movement events to pass even
when those events are used by Select-to-Speak. It should only cancel
mouse click events used by Select-to-Speak.

Another solution would be to re-write all used "drag" events to be
simply "move" events, which may reduce the likelyhood that these
events will be used by any other part of Chrome / Chrome OS besides
Select-to-Speak and drawing the mouse.

This bug also impacted some devices (like snappy) even without
large mouse cursor on.

Note: The additional "drag" and "move" events were manually tested
and do not appear to cause any behavior problems on tabs, the
launcher, system windows, etc.

TBR=dmazzoni@chromium.org

Bug:  818329 
Change-Id: I466a15a0f7a5ba0abe4f082a9cfb9b59760d690c
Reviewed-on: https://chromium-review.googlesource.com/947210
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#540714}(cherry picked from commit 8f6ebbb1d897c9ead6e241195f8604b412bb4b17)
Reviewed-on: https://chromium-review.googlesource.com/949542
Reviewed-by: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#661}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/9a269719d5ad444bbbf46eb32cf685e715a08742/chrome/browser/chromeos/accessibility/select_to_speak_event_rewriter.cc
[modify] https://crrev.com/9a269719d5ad444bbbf46eb32cf685e715a08742/chrome/browser/chromeos/accessibility/select_to_speak_event_rewriter_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment