New issue
Advanced search Search tips

Issue 818303 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Support webauthn appid extension

Project Member Reported by agl@chromium.org, Mar 2 2018

Issue description

In order to support registrations made with the U2F protocol via webauth, we need to support the appid extension[1]

[1] https://w3c.github.io/webauthn/#sctn-appid-extension
 
Cc: kpaulhamus@chromium.org
 Issue 733033  has been merged into this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6722a71904b3b16209d57650e9dc29d2ea3d7b01

commit 6722a71904b3b16209d57650e9dc29d2ea3d7b01
Author: Adam Langley <agl@chromium.org>
Date: Wed Mar 07 01:27:24 2018

webauthn: implement getClientExtensionResults

The results of client extensions, after some discussion, have settled on
being a dictionary returned by a callback on the
|PublicKeyCredential|[1].

This change implements that callback and plumbs through the results of
the |appid| extension[2], since that's the only extension that we
currently implement.

[1] https://w3c.github.io/webauthn/#iface-pkcredential
[2] https://w3c.github.io/webauthn/#sctn-appid-extension

Bug:  818303 
Change-Id: Ie7963229cc74fa209cb1c61d00e0ff63e361ace3
Reviewed-on: https://chromium-review.googlesource.com/946732
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541257}
[modify] https://crrev.com/6722a71904b3b16209d57650e9dc29d2ea3d7b01/content/browser/webauth/authenticator_impl.cc
[modify] https://crrev.com/6722a71904b3b16209d57650e9dc29d2ea3d7b01/content/browser/webauth/authenticator_impl.h
[modify] https://crrev.com/6722a71904b3b16209d57650e9dc29d2ea3d7b01/third_party/WebKit/LayoutTests/external/wpt/webauthn/interfaces.https-expected.txt
[modify] https://crrev.com/6722a71904b3b16209d57650e9dc29d2ea3d7b01/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[add] https://crrev.com/6722a71904b3b16209d57650e9dc29d2ea3d7b01/third_party/WebKit/Source/modules/credentialmanager/AuthenticationExtensionsClientOutputs.idl
[modify] https://crrev.com/6722a71904b3b16209d57650e9dc29d2ea3d7b01/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp
[modify] https://crrev.com/6722a71904b3b16209d57650e9dc29d2ea3d7b01/third_party/WebKit/Source/modules/credentialmanager/PublicKeyCredential.cpp
[modify] https://crrev.com/6722a71904b3b16209d57650e9dc29d2ea3d7b01/third_party/WebKit/Source/modules/credentialmanager/PublicKeyCredential.h
[modify] https://crrev.com/6722a71904b3b16209d57650e9dc29d2ea3d7b01/third_party/WebKit/Source/modules/credentialmanager/PublicKeyCredential.idl
[modify] https://crrev.com/6722a71904b3b16209d57650e9dc29d2ea3d7b01/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/6722a71904b3b16209d57650e9dc29d2ea3d7b01/third_party/WebKit/public/platform/modules/webauth/authenticator.mojom

Comment 3 by agl@chromium.org, Mar 7 2018

Status: Fixed (was: Assigned)

Sign in to add a comment