New issue
Advanced search Search tips

Issue 818279 link

Starred by 2 users
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Jun 2018
Cc:
calamity@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 738611



Sign in to add a comment

Polymer2 migration: Eliminate type extensions

Project Member Reported by dpa...@chromium.org, Mar 2 2018 
Per Polymer 2 migration guide, type extensions are no longer supported, see https://www.polymer-project.org/2.0/docs/upgrade#remove-type-extension-elements.

Currently in Chromium the following elements leverage type extensions.

cr-action-menu (extends dialog)                                                                                                                                                                                              
cr-dialog (extends dialog)
cr-drawer (extends dialog)
cr-lazy-render (extends template)
cr-link-row  (extends button)

Comment 1 by dpa...@chromium.org, Mar 2 2018

Blocking: 738611

Comment 2 by dpa...@chromium.org, Mar 2 2018

Cc: calamity@chromium.org
@calamity: Do you have any cycles to help with cr-action-menu case?

I started a proof-of-concept CL that changes cr-action-menu to not use type extensions anymore, at https://chromium-review.googlesource.com/c/chromium/src/+/944163.

The CL only attempts to migrate a single action menu occurrence (the one at chrome://settings/searchEngines), and to fix the cr-action-menu tests to pass.

The tests that are failing are currently marked with a dummy test2() function.

Comment 3 by dpa...@chromium.org, Mar 2 2018 

FYI, cr-drawer candidate CL is at https://chromium-review.googlesource.com/c/chromium/src/+/947041/.

Comment 4 by calamity@chromium.org, Mar 7 2018

Owner: calamity@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e0123fecd6c5aefda58930e9416b17120a300bb

commit 0e0123fecd6c5aefda58930e9416b17120a300bb
Author: dpapad <dpapad@chromium.org>
Date: Wed Mar 07 04:11:38 2018

WebUI Polymer 2 migration: Convert <cr-drawer> to a <dialog> wrapper.

Polymer2 does not support HTML element extensions, so all such elements need to
be converted to wrappers.

Bug:  818279 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I142f0ac1a6e36824a829ab27b949e9be1373eefe
Reviewed-on: https://chromium-review.googlesource.com/947041
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541319}
[modify] https://crrev.com/0e0123fecd6c5aefda58930e9416b17120a300bb/chrome/browser/resources/md_extensions/manager.html
[modify] https://crrev.com/0e0123fecd6c5aefda58930e9416b17120a300bb/chrome/browser/resources/md_history/app.html
[modify] https://crrev.com/0e0123fecd6c5aefda58930e9416b17120a300bb/chrome/browser/resources/settings/settings_ui/settings_ui.html
[modify] https://crrev.com/0e0123fecd6c5aefda58930e9416b17120a300bb/chrome/test/data/webui/cr_elements/cr_drawer_tests.js
[modify] https://crrev.com/0e0123fecd6c5aefda58930e9416b17120a300bb/chrome/test/data/webui/cr_elements/cr_elements_browsertest.js
[modify] https://crrev.com/0e0123fecd6c5aefda58930e9416b17120a300bb/ui/webui/resources/cr_elements/cr_drawer/cr_drawer.html
[modify] https://crrev.com/0e0123fecd6c5aefda58930e9416b17120a300bb/ui/webui/resources/cr_elements/cr_drawer/cr_drawer.js
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42944a0ed387ac5ada7af465cc20655aad417d19

commit 42944a0ed387ac5ada7af465cc20655aad417d19
Author: Christopher Lam <calamity@chromium.org>
Date: Fri Mar 16 04:11:24 2018

WebUI Polymer 2 migration: Convert cr-action-menu to a <dialog> wrapper.

Polymer2 does not support HTML element extensions, so all such elements need to
be converted to wrappers.

Based on https://chromium-review.googlesource.com/c/chromium/src/+/944163.

Bug:  818279 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie4bd5b2ff7d6339fb32982b0fc25103eb10f8965
Reviewed-on: https://chromium-review.googlesource.com/951667
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543616}
[modify] https://crrev.com/42944a0ed387ac5ada7af465cc20655aad417d19/chrome/browser/resources/md_bookmarks/command_manager.html
[modify] https://crrev.com/42944a0ed387ac5ada7af465cc20655aad417d19/chrome/browser/resources/md_bookmarks/command_manager.js
[modify] https://crrev.com/42944a0ed387ac5ada7af465cc20655aad417d19/chrome/browser/resources/md_downloads/toolbar.html
[modify] https://crrev.com/42944a0ed387ac5ada7af465cc20655aad417d19/chrome/browser/resources/md_history/history_list.html
[modify] https://crrev.com/42944a0ed387ac5ada7af465cc20655aad417d19/chrome/browser/resources/md_history/synced_device_manager.html
[modify] https://crrev.com/42944a0ed387ac5ada7af465cc20655aad417d19/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html
[modify] https://crrev.com/42944a0ed387ac5ada7af465cc20655aad417d19/chrome/browser/resources/settings/internet_page/internet_known_networks_page.html
[modify] https://crrev.com/42944a0ed387ac5ada7af465cc20655aad417d19/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/42944a0ed387ac5ada7af465cc20655aad417d19/chrome/browser/resources/settings/on_startup_page/startup_url_entry.html
[modify] https://crrev.com/42944a0ed387ac5ada7af465cc20655aad417d19/chrome/browser/resources/settings/on_startup_page/startup_url_entry.js
[modify] https://crrev.com/42944a0ed387ac5ada7af465cc20655aad417d19/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html
[modify] https://crrev.com/42944a0ed387ac5ada7af465cc20655aad417d19/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/42944a0ed387ac5ada7af465cc20655aad417d19/chrome/browser/resources/settings/people_page/sync_account_control.html
[modify] https://crrev.com/42944a0ed387ac5ada7af465cc20655aad417d19/chrome/browser/resources/settings/printing_page/cups_printers_list.html
[modify] https://crrev.com/42944a0ed387ac5ada7af465cc20655aad417d19/chrome/browser/resources/settings/printing_page/cups_printers_list.js
[modify] https://crrev.com/42944a0ed387ac5ada7af465cc20655aad417d19/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html
[modify] https://crrev.com/42944a0ed387ac5ada7af465cc20655aad417d19/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js
[modify] https://crrev.com/42944a0ed387ac5ada7af465cc20655aad417d19/chrome/browser/resources/settings/search_engines_page/search_engine_entry.html
[modify] https://crrev.com/42944a0ed387ac5ada7af465cc20655aad417d19/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js
[modify] https://crrev.com/42944a0ed387ac5ada7af465cc20655aad417d19/chrome/browser/resources/settings/site_settings/protocol_handlers.html
[modify] https://crrev.com/42944a0ed387ac5ada7af465cc20655aad417d19/chrome/browser/resources/settings/site_settings/protocol_handlers.js
[modify] https://crrev.com/42944a0ed387ac5ada7af465cc20655aad417d19/chrome/browser/resources/settings/site_settings/site_list.html
[modify] https://crrev.com/42944a0ed387ac5ada7af465cc20655aad417d19/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/42944a0ed387ac5ada7af465cc20655aad417d19/chrome/browser/resources/settings/site_settings/usb_devices.html
[modify] https://crrev.com/42944a0ed387ac5ada7af465cc20655aad417d19/chrome/browser/resources/settings/site_settings/usb_devices.js
[modify] https://crrev.com/42944a0ed387ac5ada7af465cc20655aad417d19/chrome/test/data/webui/cr_elements/cr_action_menu_test.js
[modify] https://crrev.com/42944a0ed387ac5ada7af465cc20655aad417d19/chrome/test/data/webui/settings/protocol_handlers_tests.js
[modify] https://crrev.com/42944a0ed387ac5ada7af465cc20655aad417d19/chrome/test/data/webui/settings/search_engines_page_test.js
[modify] https://crrev.com/42944a0ed387ac5ada7af465cc20655aad417d19/chrome/test/data/webui/settings/site_list_tests.js
[modify] https://crrev.com/42944a0ed387ac5ada7af465cc20655aad417d19/chrome/test/data/webui/settings/startup_urls_page_test.js
[modify] https://crrev.com/42944a0ed387ac5ada7af465cc20655aad417d19/chrome/test/data/webui/settings/usb_devices_tests.js
[modify] https://crrev.com/42944a0ed387ac5ada7af465cc20655aad417d19/ui/webui/resources/cr_components/certificate_manager/certificate_subentry.html
[modify] https://crrev.com/42944a0ed387ac5ada7af465cc20655aad417d19/ui/webui/resources/cr_components/certificate_manager/certificate_subentry.js
[modify] https://crrev.com/42944a0ed387ac5ada7af465cc20655aad417d19/ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.html
[modify] https://crrev.com/42944a0ed387ac5ada7af465cc20655aad417d19/ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.js

Comment 7 by dpa...@chromium.org, Mar 20 2018

Owner: ----
Status: Available (was: Assigned)
Status update

[DONE]
cr-drawer
cr-action-menu

[Remaining]
cr-dialog
cr-lazy-render
cr-link-row

@calamity: Re-marking this bug as available. If you start working on any of these (maybe cr-lazy-render maybe?), please mention it here to avoid duplicate work.

Comment 8 by dpa...@chromium.org, Mar 20 2018 

FYI started work on cr-link-row.
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 22 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a37b38ca929d0b6a45572f87aa8ed434de144d6a

commit a37b38ca929d0b6a45572f87aa8ed434de144d6a
Author: dpapad <dpapad@chromium.org>
Date: Thu Mar 22 00:04:48 2018

WebUI Polymer 2 migration: Convert <button is=cr-link-row> to a <button> wrapper.

Polymer2 does not support HTML element extensions, so all such elements need to
be converted to wrappers.

Bug:  818279 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1cb05f71bff45f04e5ca5f5e64489813d8db7136
Reviewed-on: https://chromium-review.googlesource.com/972332
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544912}
[modify] https://crrev.com/a37b38ca929d0b6a45572f87aa8ed434de144d6a/chrome/browser/resources/md_extensions/detail_view.html
[modify] https://crrev.com/a37b38ca929d0b6a45572f87aa8ed434de144d6a/chrome/browser/resources/settings/appearance_page/appearance_page.html
[modify] https://crrev.com/a37b38ca929d0b6a45572f87aa8ed434de144d6a/chrome/browser/resources/settings/device_page/display.html
[modify] https://crrev.com/a37b38ca929d0b6a45572f87aa8ed434de144d6a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html
[modify] https://crrev.com/a37b38ca929d0b6a45572f87aa8ed434de144d6a/ui/webui/resources/cr_elements/cr_link_row/cr_link_row.html
[modify] https://crrev.com/a37b38ca929d0b6a45572f87aa8ed434de144d6a/ui/webui/resources/cr_elements/cr_link_row/cr_link_row.js

Comment 10 by calamity@chromium.org, Mar 22 2018 

I'll take a gander a cr-lazy-rander.

Comment 11 by dpa...@chromium.org, Mar 22 2018 

Thanks. I'll start looking at cr-dialog, which I expect to be the most complex case.
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44cb654993a3556da0fa2567c711e7b5db517aac

commit 44cb654993a3556da0fa2567c711e7b5db517aac
Author: Christopher Lam <calamity@chromium.org>
Date: Tue Mar 27 04:39:15 2018

WebUI Polymer 2 migration: Remove cr-lazy-render type extension.

This CL upgrades cr-lazy-render for compatibility with Polymer 2. It
does this by using a slot for a <template> from the light DOM which
gets templatized since the cr-lazy-render element itself can no longer
be a <template>.

This means that all clients need to wrap their light DOM in <template>
tags.

Bug:  818279 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ieaed7cb2f9422557aed0c3a388939b17b5825245
Reviewed-on: https://chromium-review.googlesource.com/977203
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546012}
[modify] https://crrev.com/44cb654993a3556da0fa2567c711e7b5db517aac/chrome/browser/resources/md_bookmarks/command_manager.html
[modify] https://crrev.com/44cb654993a3556da0fa2567c711e7b5db517aac/chrome/browser/resources/md_extensions/manager.html
[modify] https://crrev.com/44cb654993a3556da0fa2567c711e7b5db517aac/chrome/browser/resources/md_extensions/view_manager.js
[modify] https://crrev.com/44cb654993a3556da0fa2567c711e7b5db517aac/chrome/browser/resources/md_history/app.html
[modify] https://crrev.com/44cb654993a3556da0fa2567c711e7b5db517aac/chrome/browser/resources/md_history/history_list.html
[modify] https://crrev.com/44cb654993a3556da0fa2567c711e7b5db517aac/chrome/browser/resources/md_history/synced_device_manager.html
[modify] https://crrev.com/44cb654993a3556da0fa2567c711e7b5db517aac/chrome/browser/resources/print_preview/new/advanced_options_settings.html
[modify] https://crrev.com/44cb654993a3556da0fa2567c711e7b5db517aac/chrome/browser/resources/print_preview/new/destination_settings.html
[modify] https://crrev.com/44cb654993a3556da0fa2567c711e7b5db517aac/chrome/browser/resources/settings/languages_page/languages_page.html
[modify] https://crrev.com/44cb654993a3556da0fa2567c711e7b5db517aac/chrome/browser/resources/settings/on_startup_page/startup_url_entry.html
[modify] https://crrev.com/44cb654993a3556da0fa2567c711e7b5db517aac/chrome/browser/resources/settings/reset_page/reset_page.html
[modify] https://crrev.com/44cb654993a3556da0fa2567c711e7b5db517aac/chrome/test/data/webui/cr_elements/cr_lazy_render_tests.js
[modify] https://crrev.com/44cb654993a3556da0fa2567c711e7b5db517aac/ui/webui/resources/cr_components/certificate_manager/certificate_subentry.html
[modify] https://crrev.com/44cb654993a3556da0fa2567c711e7b5db517aac/ui/webui/resources/cr_elements/cr_lazy_render/cr_lazy_render.html
[modify] https://crrev.com/44cb654993a3556da0fa2567c711e7b5db517aac/ui/webui/resources/cr_elements/cr_lazy_render/cr_lazy_render.js
Project Member

Comment 13 by bugdroid1@chromium.org, Apr 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5442982ebaeaeac309d5bea01a9127216a889eb

commit a5442982ebaeaeac309d5bea01a9127216a889eb
Author: dpapad <dpapad@chromium.org>
Date: Tue Apr 03 23:11:10 2018

WebUI Polymer 2 migration: Convert <dialog is=cr-dialog> to a <dialog> wrapper.

Polymer2 does not support HTML element extensions, so all such elements need to
be converted to wrappers.

 - Introduced a new --cr-dialog-native CSS mixin, such that users of <cr-dialog>
   can still style the inner native <dialog>. Before, this was not necessary,
   since <cr-dialog> itself was a <dialog>, and not a wrapper. Update all such
   cases to use the mixin.
 - Introduced a public getNative() method to expose the internal <dialog>, which
   is necessary in a few cases (both tests and prod).
 - Mirrored <dialog>'s |open| attribute such  that it updates synchronously as soon
   a dialog is opened or closed. This matches the internal <dialog>'s behavior.
 - Updated tests as necessary (and did a significant amount of manual sanity
   checking).

Bug:  818279 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I4fb35237d3ea3fa3dbb8ef4602036a4783f1e896
Reviewed-on: https://chromium-review.googlesource.com/976394
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547860}
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/chromeos/emulator/audio_settings.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/chromeos/emulator/bluetooth_settings.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/chromeos/internet_config_dialog/internet_config_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/chromeos/login/offline_ad_login.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/chromeos/login/offline_gaia.css
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/chromeos/login/offline_gaia.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/chromeos/login/saml_confirm_password.css
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/chromeos/login/saml_confirm_password.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/md_bookmarks/command_manager.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/md_bookmarks/edit_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/md_extensions/compiled_resources2.gyp
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/md_extensions/install_warnings_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/md_extensions/kiosk_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/md_extensions/load_error.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/md_extensions/load_error.js
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/md_extensions/options_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/md_extensions/options_dialog.js
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/md_extensions/pack_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/md_extensions/pack_dialog_alert.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/md_extensions/pack_dialog_alert.js
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/md_history/history_list.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/md_user_manager/error_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/md_user_manager/import_supervised_user.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/pdf/elements/viewer-error-screen/viewer-error-screen.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/pdf/elements/viewer-password-screen/viewer-password-screen.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/print_preview/new/advanced_settings_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/print_preview/new/destination_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/print_preview/new/search_dialog_css.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/settings/about_page/channel_switcher_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/settings/about_page/update_warning_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/settings/android_apps_page/android_apps_subpage.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/settings/clear_browsing_data_dialog/history_deletion_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/settings/device_page/display_overscan_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/settings/device_page/drive_cache_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/settings/internet_page/internet_config.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/settings/internet_page/network_proxy_section.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/settings/internet_page/tether_connection_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/settings/languages_page/add_languages_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/settings/on_startup_page/startup_url_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/settings/passwords_and_forms_page/passwords_export_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/settings/people_page/import_data_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/settings/people_page/password_prompt_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/settings/people_page/setup_fingerprint_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/settings/people_page/setup_pin_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/settings/people_page/users_add_user_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/settings/reset_page/powerwash_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/settings/reset_page/reset_profile_banner.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/settings/site_settings/add_site_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/settings/site_settings/edit_exception_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/settings/site_settings/site_data.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/browser/resources/settings/site_settings/site_details.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/test/data/webui/cr_elements/cr_dialog_test.js
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/test/data/webui/extensions/extension_load_error_test.js
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/test/data/webui/extensions/extension_options_dialog_test.js
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/test/data/webui/extensions/extension_pack_dialog_test.js
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/ui/webui/resources/cr_components/certificate_manager/ca_trust_edit_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/ui/webui/resources/cr_components/certificate_manager/certificate_delete_confirmation_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/ui/webui/resources/cr_components/certificate_manager/certificate_password_decryption_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/ui/webui/resources/cr_components/certificate_manager/certificate_password_encryption_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/ui/webui/resources/cr_components/certificate_manager/certificates_error_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/ui/webui/resources/cr_components/chromeos/bluetooth_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/ui/webui/resources/cr_components/chromeos/network/network_siminfo.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
[modify] https://crrev.com/a5442982ebaeaeac309d5bea01a9127216a889eb/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0243ee06ddba0b3735d8908e18419978f638c6c8

commit 0243ee06ddba0b3735d8908e18419978f638c6c8
Author: Takashi Sakamoto <tasak@google.com>
Date: Wed Apr 04 08:44:48 2018

Revert "WebUI Polymer 2 migration: Convert <dialog is=cr-dialog> to a <dialog> wrapper."

This reverts commit a5442982ebaeaeac309d5bea01a9127216a889eb.

Reason for revert: 
Causes browser_tests failing on chromium.chromiumos/linux-chromeos-dbg

failures:
CrSettingsAndroidAppsPageTest.All
CrSettingsFingerprintListTest.All

https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2Flinux-chromeos-dbg%2F5028%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FCrSettingsAndroidAppsPageTest.All%2F0
AssertionError: expected undefined to be false
    at Function.assert.isFalse (file:///b/s/w/ir/third_party/chaijs/chai.js:2459:31)
    at assertFalse (file:///b/s/w/ir/chrome/test/data/webui/test_api.js:862:17)
    at Context.<anonymous> (file:///b/s/w/ir/chrome/test/data/webui/settings/android_apps_page_test.js:125:7)
", source: file:///b/s/w/ir/chrome/test/data/webui/mocha_adapter.js (48)
[1113:1113:0403/172824.531829:ERROR:web_ui_test_handler.cc(82)] Test Errors: 1/9 tests had failed assertions.
[1113:1113:0403/172824.531924:ERROR:web_ui_browser_test.cc(475)] CONDITION FAILURE: encountered javascript console error(s):
[1113:1113:0403/172824.531950:ERROR:web_ui_browser_test.cc(477)] JS ERROR: '[1113:1113:0403/172824.017897:ERROR:CONSOLE(48)] "Mocha test failed: AndroidAppsPageTests SubPage Disable
AssertionError: expected undefined to be false
    at Function.assert.isFalse (file:///b/s/w/ir/third_party/chaijs/chai.js:2459:31)
    at assertFalse (file:///b/s/w/ir/chrome/test/data/webui/test_api.js:862:17)
    at Context.<anonymous> (file:///b/s/w/ir/chrome/test/data/webui/settings/android_apps_page_test.js:125:7)
", source: file:///b/s/w/ir/chrome/test/data/webui/mocha_adapter.js (48)
'
[1113:1113:0403/172824.531980:ERROR:web_ui_browser_test.cc(479)] JS call assumed failed, because JS console error(s) found.
gen/chrome/test/data/webui/settings/cr_settings_browsertest-gen.cc:2866: Failure
Value of: RunJavascriptTestF( true, "CrSettingsAndroidAppsPageTest", "All")
  Actual: false
Expected: true


Original change's description:
> WebUI Polymer 2 migration: Convert <dialog is=cr-dialog> to a <dialog> wrapper.
> 
> Polymer2 does not support HTML element extensions, so all such elements need to
> be converted to wrappers.
> 
>  - Introduced a new --cr-dialog-native CSS mixin, such that users of <cr-dialog>
>    can still style the inner native <dialog>. Before, this was not necessary,
>    since <cr-dialog> itself was a <dialog>, and not a wrapper. Update all such
>    cases to use the mixin.
>  - Introduced a public getNative() method to expose the internal <dialog>, which
>    is necessary in a few cases (both tests and prod).
>  - Mirrored <dialog>'s |open| attribute such  that it updates synchronously as soon
>    a dialog is opened or closed. This matches the internal <dialog>'s behavior.
>  - Updated tests as necessary (and did a significant amount of manual sanity
>    checking).
> 
> Bug:  818279 
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I4fb35237d3ea3fa3dbb8ef4602036a4783f1e896
> Reviewed-on: https://chromium-review.googlesource.com/976394
> Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
> Reviewed-by: Scott Chen <scottchen@chromium.org>
> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#547860}

TBR=stevenjb@chromium.org,dpapad@chromium.org,rbpotter@chromium.org,scottchen@chromium.org

Change-Id: If9454d64d28b600267dc8fa4a18151dce71fe722
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  818279 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/994439
Reviewed-by: Takashi Sakamoto <tasak@google.com>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#548009}
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/chromeos/emulator/audio_settings.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/chromeos/emulator/bluetooth_settings.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/chromeos/internet_config_dialog/internet_config_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/chromeos/login/offline_ad_login.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/chromeos/login/offline_gaia.css
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/chromeos/login/offline_gaia.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/chromeos/login/saml_confirm_password.css
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/chromeos/login/saml_confirm_password.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/md_bookmarks/command_manager.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/md_bookmarks/edit_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/md_extensions/compiled_resources2.gyp
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/md_extensions/install_warnings_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/md_extensions/kiosk_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/md_extensions/load_error.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/md_extensions/load_error.js
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/md_extensions/options_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/md_extensions/options_dialog.js
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/md_extensions/pack_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/md_extensions/pack_dialog_alert.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/md_extensions/pack_dialog_alert.js
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/md_history/history_list.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/md_user_manager/error_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/md_user_manager/import_supervised_user.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/pdf/elements/viewer-error-screen/viewer-error-screen.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/pdf/elements/viewer-password-screen/viewer-password-screen.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/print_preview/new/advanced_settings_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/print_preview/new/destination_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/print_preview/new/search_dialog_css.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/settings/about_page/channel_switcher_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/settings/about_page/update_warning_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/settings/android_apps_page/android_apps_subpage.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/settings/clear_browsing_data_dialog/history_deletion_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/settings/device_page/display_overscan_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/settings/device_page/drive_cache_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/settings/internet_page/internet_config.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/settings/internet_page/network_proxy_section.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/settings/internet_page/tether_connection_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/settings/languages_page/add_languages_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/settings/on_startup_page/startup_url_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/settings/passwords_and_forms_page/passwords_export_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/settings/people_page/import_data_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/settings/people_page/password_prompt_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/settings/people_page/setup_fingerprint_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/settings/people_page/setup_pin_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/settings/people_page/users_add_user_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/settings/reset_page/powerwash_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/settings/reset_page/reset_profile_banner.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/settings/site_settings/add_site_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/settings/site_settings/edit_exception_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/settings/site_settings/site_data.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/browser/resources/settings/site_settings/site_details.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/test/data/webui/cr_elements/cr_dialog_test.js
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/test/data/webui/extensions/extension_load_error_test.js
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/test/data/webui/extensions/extension_options_dialog_test.js
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/test/data/webui/extensions/extension_pack_dialog_test.js
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/ui/webui/resources/cr_components/certificate_manager/ca_trust_edit_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/ui/webui/resources/cr_components/certificate_manager/certificate_delete_confirmation_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/ui/webui/resources/cr_components/certificate_manager/certificate_password_decryption_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/ui/webui/resources/cr_components/certificate_manager/certificate_password_encryption_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/ui/webui/resources/cr_components/certificate_manager/certificates_error_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/ui/webui/resources/cr_components/chromeos/bluetooth_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/ui/webui/resources/cr_components/chromeos/network/network_siminfo.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
[modify] https://crrev.com/0243ee06ddba0b3735d8908e18419978f638c6c8/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js
Project Member

Comment 15 by bugdroid1@chromium.org, Apr 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/772513f5e161afc7886df4af817fbeae5e3b5b23

commit 772513f5e161afc7886df4af817fbeae5e3b5b23
Author: Demetrios Papadopoulos <dpapad@chromium.org>
Date: Sat Apr 07 00:14:35 2018

WebUI Polymer 2 migration: Convert <dialog is=cr-dialog> to a <dialog> wrapper (reland).

Reland of https://chromium-review.googlesource.com/c/chromium/src/+/976394.

Polymer2 does not support HTML element extensions, so all such elements need to
be converted to wrappers.

 - Introduced a new --cr-dialog-native CSS mixin, such that users of <cr-dialog>
   can still style the inner native <dialog>. Before, this was not necessary,
   since <cr-dialog> itself was a <dialog>, and not a wrapper. Update all such
   cases to use the mixin.
 - Introduced a public getNative() method to expose the internal <dialog>, which
   is necessary in a few cases (both tests and prod).
 - Mirrored <dialog>'s |open| attribute such  that it updates synchronously as soon
   a dialog is opened or closed. This matches the internal <dialog>'s behavior.
 - Updated tests as necessary (and did a significant amount of manual sanity
   checking).

Bug:  818279 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie3262dac5bd11645e99be38f57656274d34bdf41
Reviewed-on: https://chromium-review.googlesource.com/996952
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548986}
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/chromeos/emulator/audio_settings.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/chromeos/emulator/bluetooth_settings.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/chromeos/internet_config_dialog/internet_config_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/chromeos/login/offline_ad_login.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/chromeos/login/offline_gaia.css
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/chromeos/login/offline_gaia.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/chromeos/login/saml_confirm_password.css
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/chromeos/login/saml_confirm_password.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/md_bookmarks/command_manager.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/md_bookmarks/edit_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/md_extensions/compiled_resources2.gyp
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/md_extensions/install_warnings_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/md_extensions/kiosk_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/md_extensions/load_error.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/md_extensions/load_error.js
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/md_extensions/options_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/md_extensions/options_dialog.js
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/md_extensions/pack_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/md_extensions/pack_dialog_alert.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/md_extensions/pack_dialog_alert.js
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/md_history/history_list.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/md_user_manager/error_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/md_user_manager/import_supervised_user.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/pdf/elements/viewer-error-screen/viewer-error-screen.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/pdf/elements/viewer-password-screen/viewer-password-screen.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/print_preview/new/advanced_settings_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/print_preview/new/destination_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/print_preview/new/search_dialog_css.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/settings/about_page/channel_switcher_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/settings/about_page/update_warning_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/settings/android_apps_page/android_apps_subpage.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/settings/clear_browsing_data_dialog/history_deletion_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/settings/device_page/display_overscan_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/settings/device_page/drive_cache_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/settings/internet_page/internet_config.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/settings/internet_page/network_proxy_section.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/settings/internet_page/tether_connection_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/settings/languages_page/add_languages_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/settings/on_startup_page/startup_url_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/settings/passwords_and_forms_page/address_edit_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/settings/passwords_and_forms_page/credit_card_edit_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/settings/passwords_and_forms_page/password_edit_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/settings/passwords_and_forms_page/passwords_export_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/settings/people_page/easy_unlock_turn_off_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/settings/people_page/import_data_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/settings/people_page/password_prompt_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/settings/people_page/setup_fingerprint_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/settings/people_page/setup_pin_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/settings/people_page/users_add_user_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/settings/privacy_page/privacy_page.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/settings/reset_page/powerwash_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/settings/reset_page/reset_profile_banner.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/settings/site_settings/add_site_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/settings/site_settings/edit_exception_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/settings/site_settings/site_data.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/browser/resources/settings/site_settings/site_details.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/test/data/webui/cr_elements/cr_dialog_test.js
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/test/data/webui/extensions/extension_load_error_test.js
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/test/data/webui/extensions/extension_options_dialog_test.js
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/test/data/webui/extensions/extension_pack_dialog_test.js
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/ui/webui/resources/cr_components/certificate_manager/ca_trust_edit_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/ui/webui/resources/cr_components/certificate_manager/certificate_delete_confirmation_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/ui/webui/resources/cr_components/certificate_manager/certificate_password_decryption_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/ui/webui/resources/cr_components/certificate_manager/certificate_password_encryption_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/ui/webui/resources/cr_components/certificate_manager/certificates_error_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/ui/webui/resources/cr_components/chromeos/bluetooth_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/ui/webui/resources/cr_components/chromeos/network/network_siminfo.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
[modify] https://crrev.com/772513f5e161afc7886df4af817fbeae5e3b5b23/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js

Comment 16 by dpa...@chromium.org, Apr 9 2018 

Summary so far:
calamity@ converted cr-action-menu, cr-lazy-render.
dpapad@ converted cr-dialog, cr-drawer, cr-link-row.

I've just found one more element that needs to be converted, settings-idle-load, [1]. I believe this is the last one.

[1] https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/controls/settings_idle_load.js?l=13
Project Member

Comment 17 by bugdroid1@chromium.org, Apr 16 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0c6f89b58b03c45ebbf1c6abfbe34639f56b2f3

commit e0c6f89b58b03c45ebbf1c6abfbe34639f56b2f3
Author: Bailey Berro <baileyberro@chromium.org>
Date: Mon Apr 16 19:31:06 2018

Update addSmbShareDialog to use cr-dialog

This change applies the migration of crrev.com/c/976394 to the
addSmbShareDialog.

Bug:  818279 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic40afe345c38d4e776afb15f7e0fdb761f6906c0
Reviewed-on: https://chromium-review.googlesource.com/1003632
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551074}
[modify] https://crrev.com/e0c6f89b58b03c45ebbf1c6abfbe34639f56b2f3/chrome/browser/resources/settings/downloads_page/add_smb_share_dialog.html
Project Member

Comment 18 by bugdroid1@chromium.org, Apr 17 2018

Labels: merge-merged-testbranch
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0c6f89b58b03c45ebbf1c6abfbe34639f56b2f3

commit e0c6f89b58b03c45ebbf1c6abfbe34639f56b2f3
Author: Bailey Berro <baileyberro@chromium.org>
Date: Mon Apr 16 19:31:06 2018

Update addSmbShareDialog to use cr-dialog

This change applies the migration of crrev.com/c/976394 to the
addSmbShareDialog.

Bug:  818279 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic40afe345c38d4e776afb15f7e0fdb761f6906c0
Reviewed-on: https://chromium-review.googlesource.com/1003632
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551074}
[modify] https://crrev.com/e0c6f89b58b03c45ebbf1c6abfbe34639f56b2f3/chrome/browser/resources/settings/downloads_page/add_smb_share_dialog.html

Comment 19 by dpa...@chromium.org, Jun 1 2018

Owner: dpa...@chromium.org
Status: Started (was: Available)
Remaining CL for settings-idle-load at https://chromium-review.googlesource.com/c/chromium/src/+/1081811.
Project Member

Comment 20 by bugdroid1@chromium.org, Jun 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/769968d29a78932d3c08ccf1bd669654268e2c7a

commit 769968d29a78932d3c08ccf1bd669654268e2c7a
Author: dpapad <dpapad@chromium.org>
Date: Mon Jun 04 20:20:38 2018

WebUI Polymer 2 migration: Remove settings-idle-load type extension.

This CL updates settings-idle-load for compatibility with Polymer 2, by
making it wrap a <template> instead of extending one.

Bug:  818279 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I122675b884ef3a9bfcf0fbc053cceddbb75cbfcf
Reviewed-on: https://chromium-review.googlesource.com/1081811
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564213}
[modify] https://crrev.com/769968d29a78932d3c08ccf1bd669654268e2c7a/chrome/browser/resources/settings/basic_page/basic_page.html
[modify] https://crrev.com/769968d29a78932d3c08ccf1bd669654268e2c7a/chrome/browser/resources/settings/controls/settings_idle_load.html
[modify] https://crrev.com/769968d29a78932d3c08ccf1bd669654268e2c7a/chrome/browser/resources/settings/controls/settings_idle_load.js
[modify] https://crrev.com/769968d29a78932d3c08ccf1bd669654268e2c7a/chrome/test/data/webui/settings/settings_idle_load_browsertest.js
[modify] https://crrev.com/769968d29a78932d3c08ccf1bd669654268e2c7a/chrome/test/data/webui/settings/settings_page_browsertest.js
[modify] https://crrev.com/769968d29a78932d3c08ccf1bd669654268e2c7a/ui/webui/resources/cr_elements/cr_lazy_render/cr_lazy_render.js

Comment 21 by dpa...@chromium.org, Jun 4 2018

Status: Fixed (was: Started)
►

Sign in to add a comment