New issue
Advanced search Search tips

Issue 818277 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

DCHECK failure in !has_pending_exception() in isolate.cc

Project Member Reported by ClusterFuzz, Mar 2 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4684384784089088

Fuzzer: mbarbella_js_mutation
Job Type: windows_asan_d8_dbg
Platform Id: windows

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  !has_pending_exception() in isolate.cc
  v8::platform::PrintStackTrace
  v8::internal::Isolate::Throw
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_d8_dbg&range=51672:51675

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4684384784089088

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 

Comment 1 by kenrb@chromium.org, Mar 2 2018

Labels: Security_Impact-Head M-67 Pri-1
Owner: jkummerow@chromium.org
Status: Assigned (was: Untriaged)
jkummerow@: Can you please take a look at this? This regression is likely linked to https://chromium.googlesource.com/v8/v8/+/7c79a9fd1e35d5272b5dbe57af92c7e0d2120ca3.
Labels: -Type-Bug-Security -Restrict-View-SecurityTeam -Security_Impact-Head -Security_Severity-High Type-Bug
Fix: https://chromium-review.googlesource.com/#/c/v8/v8/+/947254

In Release mode, this was harmless.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/62d1f78245b552ce7cb806de15d35ff29c867647

commit 62d1f78245b552ce7cb806de15d35ff29c867647
Author: Jakob Kummerow <jkummerow@chromium.org>
Date: Sat Mar 03 00:59:42 2018

[bigint] Fix throwing in Exponentiate()

When the multiplication steps fail, they have already thrown an
exception internally, so we should not throw another.
The power-of-two fast path erroneously did not throw at all for
a few input values.

Bug:  chromium:818277 
Change-Id: If90f6aa3e77fc72e3434daca3b898c77739933ab
Reviewed-on: https://chromium-review.googlesource.com/947254
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51711}
[modify] https://crrev.com/62d1f78245b552ce7cb806de15d35ff29c867647/src/objects/bigint.cc
[modify] https://crrev.com/62d1f78245b552ce7cb806de15d35ff29c867647/test/mjsunit/harmony/bigint/regressions.js

Status: Fixed (was: Assigned)
Project Member

Comment 5 by ClusterFuzz, Mar 3 2018

ClusterFuzz has detected this issue as fixed in range 51710:51711.

Detailed report: https://clusterfuzz.com/testcase?key=4684384784089088

Fuzzer: mbarbella_js_mutation
Job Type: windows_asan_d8_dbg
Platform Id: windows

Crash Type: DCHECK failure
Crash Address: 
Crash State:
  !has_pending_exception() in isolate.cc
  v8::platform::PrintStackTrace
  v8::internal::Isolate::Throw
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_d8_dbg&range=51672:51675
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_d8_dbg&range=51710:51711

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4684384784089088

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Mar 3 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 4684384784089088 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment