New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 818262 link

Starred by 1 user
Status: Fixed
Owner:
█ cmsy@google.com
Last visit > 30 days ago
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Pending downloads are listed as "Download pending..." in Downloads Home

Project Member Reported by cmsy@google.com, Mar 2 2018 
Chrome Version: Canary 66.0.3356.0
OS: Android

What steps will reproduce the problem?
(1) Go on airplane mode
(2) Download 1+ pages from NTP
(3) Open Downloads Home for the first time

What is the expected result?
Requests are listed as "Waiting for network..."

What happens instead?
Requests are listed as "Download pending..."

Note offline pages descriptive pending status and downloads foreground service must be enabled.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/811bce93ea479b58b56b27a24b7bbc1b4f30a8af

commit 811bce93ea479b58b56b27a24b7bbc1b4f30a8af
Author: Candice Sy <cmsy@google.com>
Date: Fri Mar 02 23:07:53 2018

Add PendingState to requests retrieved from request queue store

When Downloads Home is first launched, DownloadUIAdapter retrieves
offline page requests from the request queue store via
RequestCoordinator. PendingState, which is not saved in the store,
must be added to the request before it is shown on the UI.

Bug:  818262 
Change-Id: I9237b5f6e8fada835c8b120a74c81fdb3fe4a29b
Reviewed-on: https://chromium-review.googlesource.com/946682
Commit-Queue: Candice Sy <cmsy@google.com>
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540674}
[modify] https://crrev.com/811bce93ea479b58b56b27a24b7bbc1b4f30a8af/components/offline_pages/core/background/pending_state_updater.cc
[modify] https://crrev.com/811bce93ea479b58b56b27a24b7bbc1b4f30a8af/components/offline_pages/core/background/pending_state_updater.h
[modify] https://crrev.com/811bce93ea479b58b56b27a24b7bbc1b4f30a8af/components/offline_pages/core/background/request_coordinator.cc

Comment 2 by cmsy@google.com, Mar 3 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment