New issue
Advanced search Search tips

Issue 818253 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

13.4%-18.5% regression in system_health.common_desktop at 539932:540065

Project Member Reported by mustaq@chromium.org, Mar 2 2018

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=818253

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=a8d2f227a684de5c154f22b14b7340f9936661c48359c8aaac27bf5869307259


Bot(s) for this bug's original alert(s):

chromium-rel-win7-gpu-ati
chromium-rel-win7-gpu-nvidia
chromium-rel-win7-x64-dual
chromium-rel-win8-dual
Cc: wjmaclean@chromium.org wnwen@chromium.org pmarko@chromium.org kenrb@chromium.org bokan@chromium.org poromov@chromium.org agrieve@chromium.org xiy...@chromium.org atwilson@chromium.org
Owner: wnwen@chromium.org
Status: Assigned (was: Untriaged)
📍 Found significant differences after each of 3 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/14e8d0f4440000

Add device DMToken for affiliated user's policy requests. by poromov@chromium.org
https://chromium.googlesource.com/chromium/src/+/cbfc1f4ae00b331aad99f29148bc4bb40f5ff858

ScrollableArea rects need to be in coords of LocalRoot's Document. by wjmaclean@chromium.org
https://chromium.googlesource.com/chromium/src/+/5bed7ef3c3cfd01e4070792fdce590acbafab482

Revert "Supersize: Fix pak spurious deltas" by wnwen@chromium.org
https://chromium.googlesource.com/chromium/src/+/9b70a4435f46b08b4e5b19a0793a87a99f28045d

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Cc: -atwilson@chromium.org
Seems unlikely to be "Add device DMToken..." since that's a Chrome OS feature and the bots complaining are windows. Seems likely to be wjmaclean's change?

Comment 5 by wnwen@chromium.org, Mar 5 2018

Cc: -wnwen@chromium.org
Owner: ----
Status: Available (was: Assigned)
Pak files change is only for the supersize tool.

Comment 6 by wnwen@chromium.org, Mar 5 2018

Cc: -wjmaclean@chromium.org
Owner: wjmaclean@chromium.org
Status: Assigned (was: Available)
bokan@ - could changing the coordinate computations really lead to this sort of perf regression? Not having the coords in the right space isn't really an option, so if it *is* this, then is there a more efficient way to do the computations?

Comment 8 by bokan@chromium.org, Mar 5 2018

The coordinate computations certainly wouldn't - but if we fixed touch rects that might alter which thread scrolls get sent to so it could have an effect in ways like that.
Components: Speed>Metrics>SystemHealthRegressions
friendly ping from today's perf sheriff
any update, and action plan for this?
A friendly reminder for update.
CSM triage ping

Sign in to add a comment