New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 818238 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
no longer active
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

[PIP] Video doesn't appear in window.

Project Member Reported by apaci...@chromium.org, Mar 2 2018

Issue description

Video doesn't appear in PIP window when PIP is triggered. See "debug blue" colors.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79b2c906cb575f9f816d2c1f66e679d6dd690a34

commit 79b2c906cb575f9f816d2c1f66e679d6dd690a34
Author: Jennifer Apacible <apacible@chromium.org>
Date: Tue Mar 06 16:33:06 2018

[Picture in Picture] Fix video showing in window.

Currently, the video doesn't show in the window based on the bounds
set for the used SurfaceLayer. This change updates the initial bounds
to allow the OverlayWindow dictate what we want to show.

In the future when resizing work is landed, the SurfaceLayer size
should also be updated.

Bug:  818238 
Change-Id: Ia01c6810b7483700ae9ef8094554116a6072365a
Reviewed-on: https://chromium-review.googlesource.com/946669
Reviewed-by: CJ DiMeglio <lethalantidote@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541117}
[modify] https://crrev.com/79b2c906cb575f9f816d2c1f66e679d6dd690a34/chrome/browser/ui/overlay/overlay_surface_embedder.cc

Status: Fixed (was: Assigned)
Components: Internals>Media
Labels: Needs-Feedback
@apacible: Could you please help us with the sample steps to verify the issue from TE end?

Thanks!!
Components: Blink>Media>PictureInPicture

Sign in to add a comment