Enable Sole integration by default |
|||||||||||
Issue descriptionSince Sole is launching, it should be enabled by default. It is currently disabled by default, and can be turned on by Finch. However, in FRE, the Finch seeds wouldn't be there before the Sole integration is needed, so that the user might not see the customization specified by Sole configuration the first time.
,
Mar 2 2018
The CL is: https://chromium-review.googlesource.com/c/chromium/src/+/946649 Sorry about the super late request. I was waiting for the approval, and this got out of my mind for a while. Rationale: the Sole enabling bit takes effect one restarting after the Finsh seed or flags setting changes. If Sole is disabled by default, the browser customization specified by Sole config wouldn't be there after FRE, until the user restarts clank. Potential risk: This Finch config has been tested 50-50, so both enabling and disabling should work. Switching the default bit should be of low risk.
,
Mar 2 2018
This bug requires manual review: We are only 3 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 2 2018
Apply affected OS(s)
,
Mar 2 2018
,
Mar 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d269a1bbd03b84714e09499cabcaa483423b30fb commit d269a1bbd03b84714e09499cabcaa483423b30fb Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Date: Fri Mar 02 20:22:20 2018 Enable Sole integration by default TBR=tedchoc@chromium.org Bug: 818236 Change-Id: Ib7e74015c6cebb368bf9efdf8307ed13c1db8e4f Reviewed-on: https://chromium-review.googlesource.com/946649 Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#540603} [modify] https://crrev.com/d269a1bbd03b84714e09499cabcaa483423b30fb/chrome/browser/android/chrome_feature_list.cc
,
Mar 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/219101ecc0143651567d49340e80fb5b3e756b40 commit 219101ecc0143651567d49340e80fb5b3e756b40 Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Date: Fri Mar 02 22:17:29 2018 Amend "Enable Sole integration by default" The enabling bit is saved in SharedPref, so change that as well. TBR=tedchoc@chromium.org Bug: 818236 Change-Id: Idbbdf97d01e452d18db6b172cc709caa521146a7 Reviewed-on: https://chromium-review.googlesource.com/946881 Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#540658} [modify] https://crrev.com/219101ecc0143651567d49340e80fb5b3e756b40/chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java
,
Mar 2 2018
Chatted with cmasso, quote: "We have already cut the release build for M65, so your change is late. I can approve the merge just in case we have a respin and can include it." I'm cherry-picking just in case.
,
Mar 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/900114bd2eee6f436148edce8f9d9520a857b731 commit 900114bd2eee6f436148edce8f9d9520a857b731 Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Date: Fri Mar 02 22:33:47 2018 [Merge to M65] Enable Sole integration by default TBR=tedchoc@chromium.org Bug: 818236 Change-Id: Ib7e74015c6cebb368bf9efdf8307ed13c1db8e4f Reviewed-on: https://chromium-review.googlesource.com/946649 Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#540603}(cherry picked from commit d269a1bbd03b84714e09499cabcaa483423b30fb) Reviewed-on: https://chromium-review.googlesource.com/946710 Cr-Commit-Position: refs/branch-heads/3325@{#648} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/900114bd2eee6f436148edce8f9d9520a857b731/chrome/browser/android/chrome_feature_list.cc
,
Mar 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c06745f2249f1519c81ccc5b0c9ee49b6376cb0 commit 5c06745f2249f1519c81ccc5b0c9ee49b6376cb0 Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Date: Fri Mar 02 22:34:09 2018 [Merge to M65] Amend "Enable Sole integration by default" The enabling bit is saved in SharedPref, so change that as well. TBR=tedchoc@chromium.org Bug: 818236 Change-Id: Idbbdf97d01e452d18db6b172cc709caa521146a7 Reviewed-on: https://chromium-review.googlesource.com/946881 Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#540658}(cherry picked from commit 219101ecc0143651567d49340e80fb5b3e756b40) Reviewed-on: https://chromium-review.googlesource.com/946652 Cr-Commit-Position: refs/branch-heads/3325@{#649} Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369} [modify] https://crrev.com/5c06745f2249f1519c81ccc5b0c9ee49b6376cb0/chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java
,
Mar 2 2018
,
Mar 2 2018
M66 branched at 540276. Request merge to M66 as well.
,
Mar 3 2018
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0ba0ebcbc8a1db132b1373c320990c74eed6f76 commit c0ba0ebcbc8a1db132b1373c320990c74eed6f76 Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Date: Mon Mar 05 23:50:10 2018 [Merge to M66] Enable Sole integration by default TBR=tedchoc@chromium.org Bug: 818236 Change-Id: Ib7e74015c6cebb368bf9efdf8307ed13c1db8e4f Reviewed-on: https://chromium-review.googlesource.com/946649 Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#540603}(cherry picked from commit d269a1bbd03b84714e09499cabcaa483423b30fb) Reviewed-on: https://chromium-review.googlesource.com/949982 Cr-Commit-Position: refs/branch-heads/3359@{#19} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/c0ba0ebcbc8a1db132b1373c320990c74eed6f76/chrome/browser/android/chrome_feature_list.cc
,
Mar 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8254a55c482faae7a1fd28bb09f1b58b27c41e02 commit 8254a55c482faae7a1fd28bb09f1b58b27c41e02 Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Date: Mon Mar 05 23:50:33 2018 [Merge to M66] Amend "Enable Sole integration by default" The enabling bit is saved in SharedPref, so change that as well. TBR=tedchoc@chromium.org Bug: 818236 Change-Id: Idbbdf97d01e452d18db6b172cc709caa521146a7 Reviewed-on: https://chromium-review.googlesource.com/946881 Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#540658}(cherry picked from commit 219101ecc0143651567d49340e80fb5b3e756b40) Reviewed-on: https://chromium-review.googlesource.com/950002 Cr-Commit-Position: refs/branch-heads/3359@{#20} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/8254a55c482faae7a1fd28bb09f1b58b27c41e02/chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java
,
Mar 5 2018
,
Mar 6 2018
Seems to be in M65 already. |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by wychen@chromium.org
, Mar 2 2018