New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 818232 link

Starred by 2 users
Status: Verified
Owner:
█ ymalik@chromium.org
(currently inactive on Chromium)
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR: Crash when entering VR the first time after upgrading keyboard APK

Project Member Reported by ymalik@chromium.org, Mar 2 2018 
1) uninstall the Daydream Keyboard APK from the play store
2) Enter Chrome VR
3) Click on the omnibox, this should trigger a prompt to update the keyboard apk
4) Follow the prompt and update keyboard
5) Go back to chrome right after the install is complete and enter VR

Expected behavior: you enter VR and can use the keyboard now
Actual behavior: Chrome crashes

This only happens the first time after the update, and only sometimes.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a640bd55cb064875c2b80e23eda2441d1d6f2ec

commit 6a640bd55cb064875c2b80e23eda2441d1d6f2ec
Author: Yash Malik <ymalik@google.com>
Date: Fri Mar 02 20:29:40 2018

VR: Restart Chrome after keyboard updates

Bug:  818232 
Change-Id: I735f717445cc4e7c1329af836b37b31f1be3612b
Reviewed-on: https://chromium-review.googlesource.com/946683
Commit-Queue: Yash Malik <ymalik@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540607}
[modify] https://crrev.com/6a640bd55cb064875c2b80e23eda2441d1d6f2ec/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

Comment 2 by ericde@google.com, Mar 3 2018

Labels: Proj-VR Hotlist-VRB-MVP

Comment 3 by cjgrant@chromium.org, Mar 5 2018

Labels: Merge-Request-66
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 6 2018

Labels: -Merge-Request-66 Merge-Approved-66 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 7 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c35ac976fa2fadbe36a9f8e5a13b4d5c6807caa

commit 8c35ac976fa2fadbe36a9f8e5a13b4d5c6807caa
Author: Yash Malik <ymalik@google.com>
Date: Wed Mar 07 04:08:45 2018

VR: Restart Chrome after keyboard updates

Bug:  818232 
Change-Id: I735f717445cc4e7c1329af836b37b31f1be3612b
Reviewed-on: https://chromium-review.googlesource.com/946683
Commit-Queue: Yash Malik <ymalik@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#540607}(cherry picked from commit 6a640bd55cb064875c2b80e23eda2441d1d6f2ec)
Reviewed-on: https://chromium-review.googlesource.com/952746
Reviewed-by: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#54}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/8c35ac976fa2fadbe36a9f8e5a13b4d5c6807caa/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

Comment 6 by ymalik@chromium.org, Mar 7 2018

Status: Fixed (was: Assigned)

Comment 7 by dougman@chromium.org, Mar 14 2018

Labels: Test-Complete
Status: Verified (was: Fixed)
Verified this on 66.0.3359.28 and 67.0.3368.0
The failure is fixed on both.
Added test case "Update Keyboard Driver prompt" to the "2D UI handling Test Plan".
►

Sign in to add a comment