New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 818230 link

Starred by 1 user

Issue metadata

Status: Available
Merged: issue 818054
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: ----



Sign in to add a comment

testFindPythonDependencies and testFindPythonDependenciesWithNestedImport failure on chromeos

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Mar 2 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of oshima@google.com

amd64-generic-telemetry:14175 failed

Builders failed on: 
- amd64-generic-telemetry: 
  https://luci-milo.appspot.com/buildbot/chromiumos.chromium/amd64-generic-telemetry/14175


 
Cc: -oshima@google.com osh...@chromium.org erosky@chromium.org nednguyen@chromium.org
Owner: iannucci@chromium.org
Status: Assigned (was: Available)
started on https://luci-milo.appspot.com/buildbot/chromiumos.chromium/amd64-generic-telemetry/14173.

crrev.com/c/944899 looks culprit. iannucci@, can you look into this?

03/02 09:15:07.902 INFO |run_chromeos_tests:0052| [204/260] core.find_dependencies_unittest.FindDependenciesTest.testFindPythonDependencies queued
03/02 09:15:07.903 INFO |run_chromeos_tests:0052| [205/260] core.find_dependencies_unittest.FindDependenciesTest.testFindPythonDependencies failed unexpectedly 3.2389s:
03/02 09:15:07.903 INFO |run_chromeos_tests:0052|   Traceback (most recent call last):
03/02 09:15:07.904 INFO |run_chromeos_tests:0052|     File "/usr/local/telemetry/src/tools/perf/core/find_dependencies_unittest.py", line 29, in testFindPythonDependencies
03/02 09:15:07.904 INFO |run_chromeos_tests:0052|       cat_object_path})
03/02 09:15:07.905 INFO |run_chromeos_tests:0052|   AssertionError: Items in the second set but not the first:
03/02 09:15:07.905 INFO |run_chromeos_tests:0052|   '/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/testing/dependency_test_dir/other_animals/cat/cat'
03/02 09:15:07.905 INFO |run_chromeos_tests:0052|   '/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/testing/dependency_test_dir/dog/dog/dog_object.py'
03/02 09:15:07.906 INFO |run_chromeos_tests:0052|   '/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/testing/dependency_test_dir/other_animals/cat/cat/cat_object.py'
03/02 09:15:07.906 INFO |run_chromeos_tests:0052|   '/usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/testing/dependency_test_dir/other_animals/cat/cat/__init__.py'
03/02 09:15:07.941 INFO |run_chromeos_tests:0052| [205/260] core.find_dependencies_unittest.FindDependenciesTest.testFindPythonDependenciesWithNestedImport queued
03/02 09:15:07.942 INFO |run_chromeos_tests:0052| [206/260] core.find_dependencies_unittest.FindDependenciesTest.testFindPythonDependenciesWithNestedImport failed unexpectedly 0.0345s:
03/02 09:15:07.942 INFO |run_chromeos_tests:0052|   Traceback (most recent call last):
03/02 09:15:07.943 INFO |run_chromeos_tests:0052|     File "/usr/local/telemetry/src/tools/perf/core/find_dependencies_unittest.py", line 46, in testFindPythonDependenciesWithNestedImport
03/02 09:15:07.943 INFO |run_chromeos_tests:0052|       horn_module_path, horn_module_init_path, horn_object_path})
03/02 09:15:07.943 INFO |run_chromeos_tests:0052|   AssertionError: Items in the second set but not the first:
Mergedinto: 818054
Owner: ----
Status: Duplicate (was: Assigned)
Cc: achuith@chromium.org
Status: Available (was: Duplicate)
I'm going to revert and disable the test on chromeos. +achuith for longer term fix (maybe move this module to CrOS? Switch to isolate? :))
Components: Tests>Telemetry
Yup, we have a bug to move this module to chromeos; just need to find someone to work on it.
Summary: testFindPythonDependencies and testFindPythonDependenciesWithNestedImport failure on chromeos (was: amd64-generic-telemetry:14175 failed)
I don't quite understand why these fail on chromeos but not on other platforms? 
Labels: OS-Chrome
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03a17b1a9826e1a8dbe0f23ef37d89acb209497b

commit 03a17b1a9826e1a8dbe0f23ef37d89acb209497b
Author: Robert Iannucci <iannucci@chromium.org>
Date: Sat Mar 03 02:54:52 2018

[find_dependencies] Disable tests on CrOS.

Bug:  818054 ,818230
Change-Id: Ia3c395bf89845c683bba74b4944e5c673ae3a0b0
Reviewed-on: https://chromium-review.googlesource.com/946747
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: David Tu <dtu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540729}
[modify] https://crrev.com/03a17b1a9826e1a8dbe0f23ef37d89acb209497b/tools/perf/core/find_dependencies_unittest.py

Yeah, I don't either. The only thing I can think of would be that sys.prefix or sys.real_prefix is some subset of /usr/local/telemetry/src/third_party/catapult/telemetry/telemetry/internal/testing/dependency_test_dir/other_animals/cat/cat

Which has a lot of telemetry animals and cats...
Cc: nvaccaro@chromium.org x...@chromium.org mgild@chromium.org
Owner: iannucci@chromium.org
Status: Assigned (was: Available)
+iannucci@, this must be same as 818054?
yes, I had un-duped them to keep this one open specifically re: cros, though I didn't close the other one yet.
Cc: iannucci@chromium.org
Owner: ----
Status: Available (was: Assigned)
Getting back from leave; I'm not working on this so marking available (lmk if this needs my input though).
Cc: -iannucci@chromium.org iannu...@google.com

Comment 14 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 15 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Tests>Telemetry

Sign in to add a comment