Calling two mojom::Authenticator methods in quick succession results in DCHECK failure |
||
Issue description[9030:9030:0302/175528.272929:FATAL:authenticator.mojom.cc(384)] Check failed: !connected. Authenticator::MakeCredentialCallback was destroyed without first either being run or its corresponding binding being closed. It is an error to drop response callbacks which still correspond to an open interface pipe. #0 0x7fd1d04c749c base::debug::StackTrace::StackTrace() #1 0x7fd1d04f158c logging::LogMessage::~LogMessage() #2 0x7fd1cd820041 webauth::mojom::Authenticator_MakeCredential_ProxyToResponder::OnIsConnectedComplete() #3 0x7fd1cf6e7e9a mojo::(anonymous namespace)::ResponderThunk::IsConnectedAsync() #4 0x7fd1cd81ff26 _ZN4base8internal9BindStateIMN7webauth5mojom45Authenticator_MakeCredential_ProxyToResponderEFvNS3_19AuthenticatorStatusEN4mojo9StructPtrINS3_35MakeCredentialAuthenticatorResponseEEEEJNS0_13PassedWrapperINSt3__110unique_ptrIS4_NSD_14default_deleteIS4_EEEEEEEE7DestroyEPKNS0_13BindStateBaseE #5 0x7fd1cdfa3133 content::AuthenticatorImpl::InvokeCallbackAndCleanup() #6 0x7fd1cdfa23d6 content::AuthenticatorImpl::MakeCredential() #7 0x7fd1cd81e150 webauth::mojom::AuthenticatorStubDispatch::AcceptWithResponder() #8 0x7fd1cdfa7666 webauth::mojom::AuthenticatorStub<>::AcceptWithResponder() #9 0x7fd1cf6e533d mojo::InterfaceEndpointClient::HandleValidatedMessage() #10 0x7fd1cf6e4c66 mojo::FilterChain::Accept()
,
Mar 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be0eefc9e733a17b79e10689a95a3d125f71a8c8 commit be0eefc9e733a17b79e10689a95a3d125f71a8c8 Author: Kim Paulhamus <kpaulhamus@chromium.org> Date: Fri Mar 02 19:51:19 2018 [WebAuthN] Don't cleanup on pending requests Fix bug introduced when refactoring the cleanup logic. Duplicate requests shouldn't close any pending requests. Bug: 818219 Change-Id: I6da3851b7810b25b32c1e03f051e3be80a65dd28 Reviewed-on: https://chromium-review.googlesource.com/946558 Reviewed-by: Balazs Engedy <engedy@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#540589} [modify] https://crrev.com/be0eefc9e733a17b79e10689a95a3d125f71a8c8/content/browser/webauth/authenticator_impl.cc [modify] https://crrev.com/be0eefc9e733a17b79e10689a95a3d125f71a8c8/content/browser/webauth/webauth_browsertest.cc
,
Apr 2 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Mar 2 2018