New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 818218 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 828582



Sign in to add a comment

llvm-cov hangs when passing src/buildtools, src/build or src/third_party as SOURCES

Project Member Reported by liaoyuke@chromium.org, Mar 2 2018

Issue description

I was trying to implement a solution to exclude out/ and third_party/, so I first got a list of top level directories under src/, and then pass all of them to llvm-cov except for out/ and third_party, however, llvm-cov hangs. I bisected all the filters, and looks like src/buildtools/ is the culprit.

And the hang is reproducible using the following command.

/Users/liaoyuke/chromium/src/third_party/llvm-build/Release+Asserts/bin/llvm-cov export -summary-only -instr-profile=out/yuke/coverage.profdata out/coverage/url_unittests /Users/liaoyuke/chromium/src/buildtools/

One thing special about src/buildtools/ is that there are no executable source files in it, and I guess that might be the reason causing the hang.

While waiting for this issue to be fixed at the llvm side, I'll try to find another workaround.
 
Max, I assigned it to you, but if you don't have time, feel free to give it back to me, I can also take a look at it.
hmm, my guess may not be true, I tried src/docs, and it works
Summary: llvm-cov hangs when passing src/buildtools or src/third_party as SOURCES (was: llvm-cov hangs when passing SOURCES with no executable files in it)
One more strange behavior, not sure if it's related.

"time python tools/code_coverage/coverage.py url_unittests -c "out/coverage/url_unittests" -b out/coverage/ -o out/yuke -v"

real	0m11.583s
user	0m13.896s
sys	0m5.028s

Finishes within 20 seconds when filters are not specified, however,

"time python tools/code_coverage/coverage.py url_unittests -c "out/coverage/url_unittests" -b out/coverage/ -o out/yuke -f third_party/"

has been running over 5 minutes and still haven't finished.
Summary: llvm-cov hangs when passing src/buildtools, src/build or src/third_party as SOURCES (was: llvm-cov hangs when passing src/buildtools or src/third_party as SOURCES)
Here is a full list of filters that will cause llvm to hang:

src/build
src/buildtool
src/third_party

For now, I'll blacklist them in the script until this is fixed at llvm side.
Owner: liaoyuke@chromium.org
This issue seems pretty bad, I saw a few other cases where some filters cause llvm-cov to hang. I'll try to take a look this week, if I can't figure it out, I'll give it back to you next week when you're back :)
Status: Started (was: Assigned)
Forgot to mention, src/buildtools added libc++ as a third_party dependency, so this is why using src/buildtools as a filter hangs.
Blockedon: 828582
Status: Fixed (was: Started)

Sign in to add a comment