Issue metadata
Sign in to add a comment
|
No accessibility when using StyledLabel |
||||||||||||||||||||||
Issue descriptionIf a Views checkbox or radio button uses a StyledLabel for its label, it cannot currently be associated with that label, and does not get an accessible name. For example, there is a crash bubble dialog with a checkbox that has a styled label. The checkbox has no accessible name but the visible styled label says: "Help make Google Chrome better by sending crash reports and <ph name="UMA_LINK">$1<ex>usage statistics</ex></ph> to Google" In addition, a StyledLabel has no accessible information, and it cannot be associated with a textfield (although a regular label can).
,
Mar 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5f4e9d9f3568a4e5eb5e6a6d1ccc5a7eaedf218 commit d5f4e9d9f3568a4e5eb5e6a6d1ccc5a7eaedf218 Author: Aaron Leventhal <aleventhal@chromium.org> Date: Tue Mar 06 17:23:49 2018 Expose accessibility info for StyledLabel and associated controls A StyledLabel must have accessibility information exposed. When associated with a checkbox, radio or textfield, those controls should take their accessible name from it. Bug: 818216 Change-Id: I79293a93e469301a05d6e1c7f9b154922e37ed9c Reviewed-on: https://chromium-review.googlesource.com/946149 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#541132} [modify] https://crrev.com/d5f4e9d9f3568a4e5eb5e6a6d1ccc5a7eaedf218/chrome/browser/ui/views/session_crashed_bubble_view.cc [modify] https://crrev.com/d5f4e9d9f3568a4e5eb5e6a6d1ccc5a7eaedf218/ui/views/controls/button/checkbox.cc [modify] https://crrev.com/d5f4e9d9f3568a4e5eb5e6a6d1ccc5a7eaedf218/ui/views/controls/button/checkbox.h [modify] https://crrev.com/d5f4e9d9f3568a4e5eb5e6a6d1ccc5a7eaedf218/ui/views/controls/styled_label.cc [modify] https://crrev.com/d5f4e9d9f3568a4e5eb5e6a6d1ccc5a7eaedf218/ui/views/controls/styled_label.h [modify] https://crrev.com/d5f4e9d9f3568a4e5eb5e6a6d1ccc5a7eaedf218/ui/views/controls/textfield/textfield.cc [modify] https://crrev.com/d5f4e9d9f3568a4e5eb5e6a6d1ccc5a7eaedf218/ui/views/controls/textfield/textfield.h
,
Mar 6 2018
,
Mar 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8728bd6548da5aa7cd24ed8080235fd3ae3570be commit 8728bd6548da5aa7cd24ed8080235fd3ae3570be Author: Aaron Leventhal <aleventhal@chromium.org> Date: Tue Mar 06 21:45:21 2018 Unit tests for accessible labelled checkbox Bug: 818216 Change-Id: If959c872723ce79ba03adee13c247cf8382f8551 Reviewed-on: https://chromium-review.googlesource.com/951365 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#541202} [modify] https://crrev.com/8728bd6548da5aa7cd24ed8080235fd3ae3570be/ui/views/BUILD.gn [modify] https://crrev.com/8728bd6548da5aa7cd24ed8080235fd3ae3570be/ui/views/controls/button/checkbox.h [add] https://crrev.com/8728bd6548da5aa7cd24ed8080235fd3ae3570be/ui/views/controls/button/checkbox_unittest.cc |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by aleventhal@chromium.org
, Mar 2 2018