Various NPEs when shutting down VR during activity destruction. |
||||||
Issue descriptionCompositorView#onExitVr is crashing with a null native pointer. VrShellImpl#shutdown is crashing with null CompositorViewHolder and null ToolbarManager.
,
Mar 6 2018
,
Mar 7 2018
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7510507d0a5bb2744c15f9c1e3d016f3e5569a90 commit 7510507d0a5bb2744c15f9c1e3d016f3e5569a90 Author: Michael Thiessen <mthiesse@chromium.org> Date: Thu Mar 08 16:38:00 2018 VR: Fix NPEs shutting down VR during activity destruction. We're even hitting all of these in our tests, but I guess since they happen during shutdown after the test has passed, nothing cares? TBR=mthiesse@chromium.org (cherry picked from commit 7e877e77cf0bb411b33860aa86aa1aaa9ef86032) Bug: 818211 Change-Id: I1dc85763fe3c268b352452f6dd703e4996732ae6 Reviewed-on: https://chromium-review.googlesource.com/946524 Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#540830} Reviewed-on: https://chromium-review.googlesource.com/955725 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#101} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/7510507d0a5bb2744c15f9c1e3d016f3e5569a90/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorView.java [modify] https://crrev.com/7510507d0a5bb2744c15f9c1e3d016f3e5569a90/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
,
Mar 8 2018
,
Mar 16 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Mar 5 2018