Viz WebViewTest Failing With Wrong Focus |
|||||
Issue descriptionAcross Linux/Windows/CrOS Viz: --enable-features=VizDisplayCompositor Test Suite: browser_tests Test: WebViewTests/WebViewFocusTest.TouchFocusesEmbedder/0 The test is no longer waiting infinitely for frame submission. Which leads to a new focus based error: ../../chrome/browser/apps/guest_view/web_view_browsertest.cc:4526: Failure Value of: aura_webview->HasFocus() Actual: false Expected: true ../../chrome/browser/apps/guest_view/web_view_browsertest.cc:4528: Failure Value of: other_focusable_view->HasFocus() Actual: false Expected: true [1:1:0302/060501.711017:FATAL:browser_plugin.cc(580)] Check failed: !blink::WebInputEvent::IsTouchEventType(event.GetType()). #0 0x0000056cd6ec base::debug::StackTrace::StackTrace() #1 0x0000056ee3fc logging::LogMessage::~LogMessage() #2 0x00000a2da537 content::BrowserPlugin::HandleInputEvent() #3 0x0000090d69d8 blink::WebPluginContainerImpl::HandleTouchEvent() #4 0x0000090d60f8 blink::WebPluginContainerImpl::HandleEvent() #5 0x000009258ee1 blink::HTMLPlugInElement::DefaultEventHandler() #6 0x000008f595ca blink::EventDispatcher::DispatchEventPostProcess() #7 0x000008f58d3a blink::EventDispatcher::Dispatch() #8 0x00000908e3e0 blink::TouchEvent::DispatchEvent() #9 0x000008f57db3 blink::EventDispatcher::DispatchEvent() #10 0x0000094506b6 blink::TouchEventManager::DispatchTouchEventFromAccumulatdTouchPoints() #11 0x000009451c4d blink::TouchEventManager::FlushEvents() #12 0x000009444b69 blink::PointerEventManager::FlushEvents() #13 0x0000090b325b blink::WebViewImpl::DispatchBufferedTouchEvents() #14 0x00000a38afe0 blink::WebViewFrameWidget::DispatchBufferedTouchEvents() #15 0x00000a38e3ae content::RenderWidgetInputHandler::HandleTouchEvent() #16 0x00000a38e76b content::RenderWidgetInputHandler::HandleInputEvent() #17 0x00000a37ed7d content::RenderWidget::HandleInputEvent() #18 0x00000a374ce4 content::RenderViewImpl::HandleInputEvent() #19 0x00000a2fcc1e content::QueuedWebInputEvent::Dispatch() #20 0x00000a2fc2a7 content::MainThreadEventQueue::DispatchEvents() #21 0x000002826f6b _ZN4base8internal7InvokerINS0_9BindStateIMN13safe_browsing12_GLOBAL__N_112TestSBClientEFvvEJ13scoped_refptrIS5_EEEEFvvEE7RunOnceEPNS0_13BindStateBaseE #22 0x0000056cecff base::debug::TaskAnnotator::RunTask() #23 0x000005551296 blink::scheduler::internal::ThreadControllerImpl::DoWork() #24 0x000002198c48 _ZN4base8internal7InvokerINS0_9BindStateIMN12_GLOBAL__N_116SimpleHttpServerEFviEJNS_7WeakPtrIS4_EEiEEEFvvEE7RunOnceEPNS0_13BindStateBaseE #25 0x0000056cecff base::debug::TaskAnnotator::RunTask() #26 0x0000056f66c6 base::internal::IncomingTaskQueue::RunTask() #27 0x0000056f4b47 base::MessageLoop::RunTask() #28 0x0000056f4f6a base::MessageLoop::DeferOrRunPendingTask() #29 0x0000056f51fe base::MessageLoop::DoWork() #30 0x0000056f8bf9 base::MessagePumpDefault::Run() #31 0x0000056f43bc base::MessageLoop::Run() #32 0x000005727766 base::RunLoop::Run() #33 0x00000a3b3046 content::RendererMain() #34 0x000005696de4 content::RunZygote() #35 0x0000056975c4 content::RunNamedProcessTypeMain() #36 0x0000056986c3 content::ContentMainRunnerImpl::Run() #37 0x000007520c2a service_manager::Main() #38 0x000005696a54 content::ContentMain() #39 0x000005d68010 content::LaunchTests() #40 0x0000056c2244 LaunchChromeTests() #41 0x0000056c1d2e main #42 0x7f5c3106ff45 __libc_start_main #43 0x00000202802a _start riajiang@ could you help triage this?
,
Mar 2 2018
looks like it's not getting the expected touch event - I'll see if getting Viz hit-test working with OOP-D would fix this test case
,
Mar 12 2018
This was one of the hit testing failures discussed during triage today. It likely will just pass once hit testing works with viz
,
Apr 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9fb02122d52f011c6cbe7db0d9b740a10e73385f commit 9fb02122d52f011c6cbe7db0d9b740a10e73385f Author: Kevin McNee <mcnee@chromium.org> Date: Wed Apr 25 20:41:31 2018 Remove BrowserPlugin parameterization of WebView browsertests. WebViewTests and WebViewInteractiveTests now only run for the GuestViewCrossProcessFrames enabled case. Bug: 533069, 544782 , 627962, 796344 , 807116, 818161 , 818205 , 829846 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ic3a971b553fe343466a440ed4363389cd9e89214 Reviewed-on: https://chromium-review.googlesource.com/1000137 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#553727} [modify] https://crrev.com/9fb02122d52f011c6cbe7db0d9b740a10e73385f/chrome/browser/apps/guest_view/web_view_browsertest.cc [modify] https://crrev.com/9fb02122d52f011c6cbe7db0d9b740a10e73385f/chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc [modify] https://crrev.com/9fb02122d52f011c6cbe7db0d9b740a10e73385f/testing/buildbot/filters/mash.browser_tests.filter [modify] https://crrev.com/9fb02122d52f011c6cbe7db0d9b740a10e73385f/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter [modify] https://crrev.com/9fb02122d52f011c6cbe7db0d9b740a10e73385f/testing/buildbot/filters/viz.browser_tests.filter
,
Apr 26 2018
Note that this test has been renamed from WebViewTests/WebViewFocusTest.TouchFocusesEmbedder/0 to WebViewFocusBrowserPluginSpecificTest.TouchFocusesEmbedder
,
May 15 2018
,
May 16 2018
Passing on Linux now: % rr bt --enable-features=VizDisplayCompositor --gtest_filter=WebViewFocusBrowserPluginSpecificTest.TouchFocusesEmbedder ninja: Entering directory `out_desktop/Release' ninja: no work to do. IMPORTANT DEBUGGING NOTE: each test is run inside its own process. For debugging a test inside a debugger, use the --gtest_filter=<your_test_name> flag along with either --single_process (to run the test in one launcher/browser process) or --single-process (to do the above, and also run Chrome in single-process mode). Using sharding settings from environment. This is shard 0/1 Using 1 parallel jobs. Note: Google Test filter = WebViewFocusBrowserPluginSpecificTest.TouchFocusesEmbedder [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from WebViewFocusBrowserPluginSpecificTest, where TypeParam = [ RUN ] WebViewFocusBrowserPluginSpecificTest.TouchFocusesEmbedder [150202:150281:0516/134817.538175:ERROR:object_proxy.cc(616)] Failed to call method: org.freedesktop.Notifications.GetCapabilities: object_path= /org/freedesktop/Notifications: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.Notifications was not provided by any .service files [150202:150202:0516/134817.545521:WARNING:password_store_factory.cc(250)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options. [150202:150202:0516/134817.657583:WARNING:gaia_auth_fetcher.cc(902)] Could not reach Google Accounts servers: errno -11 [150202:150202:0516/134818.217854:INFO:CONSOLE(6)] "data: connected", source: chrome-extension://oehimjjakfjjammcipemkcpklmiekhcj/main.js (6) [150202:150202:0516/134818.219478:INFO:CONSOLE(6)] "onAppCommand, command = install-touch-handler", source: chrome-extension://oehimjjakfjjammcipemkcpklmiekhcj/guest.js (6) [150202:150202:0516/134818.220527:INFO:CONSOLE(6)] "g: onAppCommand, command = install-touch-handler", source: chrome-extension://oehimjjakfjjammcipemkcpklmiekhcj/main.js (6) [150202:150202:0516/134818.221288:INFO:CONSOLE(6)] "data: installed-touch-handler", source: chrome-extension://oehimjjakfjjammcipemkcpklmiekhcj/main.js (6) [150202:150212:0516/134818.298106:WARNING:discardable_shared_memory_manager.cc(431)] Some MojoDiscardableSharedMemoryManagerImpls are still alive. They will be leaked. [150202:150202:0516/134818.299713:WARNING:url_request_context_getter.cc(43)] URLRequestContextGetter leaking due to no owning thread. [150202:150202:0516/134818.301155:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown. [150202:150202:0516/134818.301178:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown. [150202:150506:0516/134818.305512:WARNING:internal_linux.cc(64)] Failed to read /proc/150234/stat [ OK ] WebViewFocusBrowserPluginSpecificTest.TouchFocusesEmbedder (2325 ms) [----------] 1 test from WebViewFocusBrowserPluginSpecificTest (2325 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (2325 ms total) [ PASSED ] 1 test. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jonr...@chromium.org
, Mar 2 2018