VR: NPE in VrShellImpl#uninitializeImeForVr |
||||||
Issue descriptionNot sure exactly how this happens, but if the WebContents is destroyed, we shutdown VR without a webContents. This leads to a NPE in uninitializeImeForVr, which assumes we always have a WebContents.
,
Mar 6 2018
,
Mar 7 2018
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/57f8e29f5872e8b811912aec28170727379ff7b0 commit 57f8e29f5872e8b811912aec28170727379ff7b0 Author: Michael Thiessen <mthiesse@chromium.org> Date: Thu Mar 08 16:35:31 2018 VR: Fix NPE in VrShellImpl#uninitializeImeForVr TBR=mthiesse@chromium.org (cherry picked from commit debe1f981a5a8d76044a81cde3ae7f497efc9a96) Bug: 818202 Change-Id: I451982f1773558b4cf11b985b861e21999819658 Reviewed-on: https://chromium-review.googlesource.com/946049 Reviewed-by: Yash Malik <ymalik@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#540541} Reviewed-on: https://chromium-review.googlesource.com/955780 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#100} Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276} [modify] https://crrev.com/57f8e29f5872e8b811912aec28170727379ff7b0/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
,
Mar 8 2018
,
Mar 12 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Mar 2 2018