New issue
Advanced search Search tips

Issue 818201 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

'cros flash' should check for update_engine, and start it if necessary

Project Member Reported by cmt...@chromium.org, Mar 2 2018

Issue description

I have recently had 'cros flash' fail several times because the update-engine service was not running on the DUT I was attempting to flash the image to.

I have been told that it would be possible for 'cros flash' to check for the service and start it if it's not running.

This would be a very nice feature to add to 'cros flash'.
 
Owner: adlr@chromium.org
Cc: ahass...@chromium.org
iiuc, update_engine is supposed to be started during boot and lives since then. 
If update_engine was not on after reboot (some times it takes a while to be brought up, but eventually it should) then we have to figure out what was the underlying problem that caused UE not to be brought up.

@dhaddock: almost all UE operations that we have now do a restart of UE at the beginning. So if for some reason UE is not brought up automatically during boot, it will be problematic because if it is shipped to users in that state, they will never get update. Can we add some test to just check if update_engine is running and healthy without actually restarting it after reboot? We also can have this as a part of another autotest.


Cc: dhadd...@chromium.org
Components: -Infra>Client>ChromeOS Internals>Installer
i think it's fine to pursue healthy system/autotests, but that wouldn't be in place of making cros flash smarter about recovering a system regardless of its current state
Owner: ahass...@chromium.org
Status: Assigned (was: Untriaged)
I will work on this!
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/1a4893f29618959cbf00212596a2c5a7bcdb774b

commit 1a4893f29618959cbf00212596a2c5a7bcdb774b
Author: Amin Hassani <ahassani@google.com>
Date: Fri Mar 09 03:29:08 2018

auto_updater: cros flash starts update_engine

If the update_engine is not running in the device, the cros flash fails
badly. This patch starts the update-engine service on the DUT if it was not
running.

BUG= chromium:818201 
TEST=stopped the update-engine service, and cros flashed succeeded.

Change-Id: I4797f8f26185f0487e486379caa72b3b73b2f2a5
Reviewed-on: https://chromium-review.googlesource.com/954413
Commit-Ready: Amin Hassani <ahassani@chromium.org>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/1a4893f29618959cbf00212596a2c5a7bcdb774b/lib/auto_updater_unittest.py
[modify] https://crrev.com/1a4893f29618959cbf00212596a2c5a7bcdb774b/lib/auto_updater.py

Status: Fixed (was: Assigned)

Sign in to add a comment