New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 818198 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-03-28
OS: iOS
Pri: 2
Type: Task
Q1

Blocked on:
issue 814421


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

Polish tab grid UI

Project Member Reported by edchin@chromium.org, Mar 2 2018

Issue description

Once UX delivers specs, 
this task tracks tweaking the cell, grid view controller, and tab grid view controller.
 
Labels: -small medium

Comment 2 by edchin@chromium.org, Mar 13 2018

NextAction: 2018-03-28
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2a9160bd017163e6acc76b1516cf736f20ce41e

commit e2a9160bd017163e6acc76b1516cf736f20ce41e
Author: edchin <edchin@chromium.org>
Date: Tue Mar 13 23:33:04 2018

[ios] Add tab grid close button asset

Bug:  818198 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I436c573c55149b9becfc4b83b3904e2973e0480b
Reviewed-on: https://chromium-review.googlesource.com/961123
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542949}
[modify] https://crrev.com/e2a9160bd017163e6acc76b1516cf736f20ce41e/ios/chrome/browser/ui/tab_grid/BUILD.gn
[modify] https://crrev.com/e2a9160bd017163e6acc76b1516cf736f20ce41e/ios/chrome/browser/ui/tab_grid/grid_cell.mm
[modify] https://crrev.com/e2a9160bd017163e6acc76b1516cf736f20ce41e/ios/chrome/browser/ui/tab_grid/grid_constants.h
[modify] https://crrev.com/e2a9160bd017163e6acc76b1516cf736f20ce41e/ios/chrome/browser/ui/tab_grid/grid_constants.mm
[add] https://crrev.com/e2a9160bd017163e6acc76b1516cf736f20ce41e/ios/chrome/browser/ui/tab_grid/resources/BUILD.gn
[add] https://crrev.com/e2a9160bd017163e6acc76b1516cf736f20ce41e/ios/chrome/browser/ui/tab_grid/resources/grid_close_cell.imageset/Contents.json
[add] https://crrev.com/e2a9160bd017163e6acc76b1516cf736f20ce41e/ios/chrome/browser/ui/tab_grid/resources/grid_close_cell.imageset/grid_close_cell.png
[add] https://crrev.com/e2a9160bd017163e6acc76b1516cf736f20ce41e/ios/chrome/browser/ui/tab_grid/resources/grid_close_cell.imageset/grid_close_cell@2x.png
[add] https://crrev.com/e2a9160bd017163e6acc76b1516cf736f20ce41e/ios/chrome/browser/ui/tab_grid/resources/grid_close_cell.imageset/grid_close_cell@3x.png

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9aed7f3fb57441792fb495a7eb38fde74d64989

commit c9aed7f3fb57441792fb495a7eb38fde74d64989
Author: edchin <edchin@chromium.org>
Date: Wed Mar 14 00:09:32 2018

[ios] Add new tab floating button asset

Bug:  818198 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I0c0f042a32cf11617e7eb8a2e3ebbf8e004d0532
Reviewed-on: https://chromium-review.googlesource.com/961587
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542956}
[modify] https://crrev.com/c9aed7f3fb57441792fb495a7eb38fde74d64989/ios/chrome/browser/ui/tab_grid/BUILD.gn
[modify] https://crrev.com/c9aed7f3fb57441792fb495a7eb38fde74d64989/ios/chrome/browser/ui/tab_grid/resources/BUILD.gn
[add] https://crrev.com/c9aed7f3fb57441792fb495a7eb38fde74d64989/ios/chrome/browser/ui/tab_grid/resources/tab_grid_new_tab_fab.imageset/Contents.json
[add] https://crrev.com/c9aed7f3fb57441792fb495a7eb38fde74d64989/ios/chrome/browser/ui/tab_grid/resources/tab_grid_new_tab_fab.imageset/tab_grid_new_tab_fab.png
[add] https://crrev.com/c9aed7f3fb57441792fb495a7eb38fde74d64989/ios/chrome/browser/ui/tab_grid/resources/tab_grid_new_tab_fab.imageset/tab_grid_new_tab_fab@2x.png
[add] https://crrev.com/c9aed7f3fb57441792fb495a7eb38fde74d64989/ios/chrome/browser/ui/tab_grid/resources/tab_grid_new_tab_fab.imageset/tab_grid_new_tab_fab@3x.png
[modify] https://crrev.com/c9aed7f3fb57441792fb495a7eb38fde74d64989/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21f85b49f288281bd1895d80163b29bdc60308c4

commit 21f85b49f288281bd1895d80163b29bdc60308c4
Author: edchin <edchin@chromium.org>
Date: Wed Mar 14 17:24:49 2018

[ios] Refactor tab grid toolbars and buttons configuration

The configuration of the toolbars and buttons has gotten
unwieldy so this CL attempts to simplify the code.

This CL also adds assets for the new tab button.

Bug:  818198 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I705ac71ac0c09bc2fea613247a2c043e5cd7ac39
Reviewed-on: https://chromium-review.googlesource.com/961662
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543115}
[modify] https://crrev.com/21f85b49f288281bd1895d80163b29bdc60308c4/ios/chrome/browser/ui/tab_grid/BUILD.gn
[modify] https://crrev.com/21f85b49f288281bd1895d80163b29bdc60308c4/ios/chrome/browser/ui/tab_grid/resources/BUILD.gn
[rename] https://crrev.com/21f85b49f288281bd1895d80163b29bdc60308c4/ios/chrome/browser/ui/tab_grid/resources/new_tab_floating_button.imageset/Contents.json
[rename] https://crrev.com/21f85b49f288281bd1895d80163b29bdc60308c4/ios/chrome/browser/ui/tab_grid/resources/new_tab_floating_button.imageset/new_tab_floating_button.png
[rename] https://crrev.com/21f85b49f288281bd1895d80163b29bdc60308c4/ios/chrome/browser/ui/tab_grid/resources/new_tab_floating_button.imageset/new_tab_floating_button@2x.png
[rename] https://crrev.com/21f85b49f288281bd1895d80163b29bdc60308c4/ios/chrome/browser/ui/tab_grid/resources/new_tab_floating_button.imageset/new_tab_floating_button@3x.png
[copy] https://crrev.com/21f85b49f288281bd1895d80163b29bdc60308c4/ios/chrome/browser/ui/tab_grid/resources/new_tab_floating_button_incognito.imageset/Contents.json
[add] https://crrev.com/21f85b49f288281bd1895d80163b29bdc60308c4/ios/chrome/browser/ui/tab_grid/resources/new_tab_floating_button_incognito.imageset/new_tab_floating_button_incognito.png
[add] https://crrev.com/21f85b49f288281bd1895d80163b29bdc60308c4/ios/chrome/browser/ui/tab_grid/resources/new_tab_floating_button_incognito.imageset/new_tab_floating_button_incognito@2x.png
[add] https://crrev.com/21f85b49f288281bd1895d80163b29bdc60308c4/ios/chrome/browser/ui/tab_grid/resources/new_tab_floating_button_incognito.imageset/new_tab_floating_button_incognito@3x.png
[modify] https://crrev.com/21f85b49f288281bd1895d80163b29bdc60308c4/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a504f9410bfb04d8f802a65ea023808305d93529

commit a504f9410bfb04d8f802a65ea023808305d93529
Author: edchin <edchin@chromium.org>
Date: Thu Mar 15 00:28:12 2018

[ios] Clean up tab grid toolbars

Removes dead and unnecessary code.

Bug:  818198 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I468a5018ec794b4c921f569362d37f1da3d1d6a5
Reviewed-on: https://chromium-review.googlesource.com/963319
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543253}
[modify] https://crrev.com/a504f9410bfb04d8f802a65ea023808305d93529/ios/chrome/browser/ui/tab_grid/tab_grid_bottom_toolbar.h
[modify] https://crrev.com/a504f9410bfb04d8f802a65ea023808305d93529/ios/chrome/browser/ui/tab_grid/tab_grid_bottom_toolbar.mm
[modify] https://crrev.com/a504f9410bfb04d8f802a65ea023808305d93529/ios/chrome/browser/ui/tab_grid/tab_grid_top_toolbar.mm
[modify] https://crrev.com/a504f9410bfb04d8f802a65ea023808305d93529/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm
[modify] https://crrev.com/a504f9410bfb04d8f802a65ea023808305d93529/ios/showcase/tab_grid/sc_toolbars_view_controller.mm

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b7db89996a4b60845bd715f5052cb194b9c1565

commit 2b7db89996a4b60845bd715f5052cb194b9c1565
Author: edchin <edchin@chromium.org>
Date: Thu Mar 15 00:58:53 2018

[ios] Add tab grid toolbar button assets

This CL also renames some other assets for naming consistency.

Bug:  818198 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I1b603f16740e5ac5279533ea39db6f9d3ab1088a
Reviewed-on: https://chromium-review.googlesource.com/962832
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543265}
[modify] https://crrev.com/2b7db89996a4b60845bd715f5052cb194b9c1565/ios/chrome/browser/ui/tab_grid/BUILD.gn
[modify] https://crrev.com/2b7db89996a4b60845bd715f5052cb194b9c1565/ios/chrome/browser/ui/tab_grid/grid_cell.mm
[modify] https://crrev.com/2b7db89996a4b60845bd715f5052cb194b9c1565/ios/chrome/browser/ui/tab_grid/resources/BUILD.gn
[rename] https://crrev.com/2b7db89996a4b60845bd715f5052cb194b9c1565/ios/chrome/browser/ui/tab_grid/resources/grid_cell_close_button.imageset/Contents.json
[rename] https://crrev.com/2b7db89996a4b60845bd715f5052cb194b9c1565/ios/chrome/browser/ui/tab_grid/resources/grid_cell_close_button.imageset/grid_cell_close_button.png
[rename] https://crrev.com/2b7db89996a4b60845bd715f5052cb194b9c1565/ios/chrome/browser/ui/tab_grid/resources/grid_cell_close_button.imageset/grid_cell_close_button@2x.png
[rename] https://crrev.com/2b7db89996a4b60845bd715f5052cb194b9c1565/ios/chrome/browser/ui/tab_grid/resources/grid_cell_close_button.imageset/grid_cell_close_button@3x.png
[copy] https://crrev.com/2b7db89996a4b60845bd715f5052cb194b9c1565/ios/chrome/browser/ui/tab_grid/resources/new_tab_toolbar_button.imageset/Contents.json
[add] https://crrev.com/2b7db89996a4b60845bd715f5052cb194b9c1565/ios/chrome/browser/ui/tab_grid/resources/new_tab_toolbar_button.imageset/new_tab_toolbar_button.png
[add] https://crrev.com/2b7db89996a4b60845bd715f5052cb194b9c1565/ios/chrome/browser/ui/tab_grid/resources/new_tab_toolbar_button.imageset/new_tab_toolbar_button@2x.png
[add] https://crrev.com/2b7db89996a4b60845bd715f5052cb194b9c1565/ios/chrome/browser/ui/tab_grid/resources/new_tab_toolbar_button.imageset/new_tab_toolbar_button@3x.png
[copy] https://crrev.com/2b7db89996a4b60845bd715f5052cb194b9c1565/ios/chrome/browser/ui/tab_grid/resources/new_tab_toolbar_button_incognito.imageset/Contents.json
[add] https://crrev.com/2b7db89996a4b60845bd715f5052cb194b9c1565/ios/chrome/browser/ui/tab_grid/resources/new_tab_toolbar_button_incognito.imageset/new_tab_toolbar_button_incognito.png
[add] https://crrev.com/2b7db89996a4b60845bd715f5052cb194b9c1565/ios/chrome/browser/ui/tab_grid/resources/new_tab_toolbar_button_incognito.imageset/new_tab_toolbar_button_incognito@2x.png
[add] https://crrev.com/2b7db89996a4b60845bd715f5052cb194b9c1565/ios/chrome/browser/ui/tab_grid/resources/new_tab_toolbar_button_incognito.imageset/new_tab_toolbar_button_incognito@3x.png
[modify] https://crrev.com/2b7db89996a4b60845bd715f5052cb194b9c1565/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69cfe36acdc99feaa10a23056405e80d1bc8a44a

commit 69cfe36acdc99feaa10a23056405e80d1bc8a44a
Author: edchin <edchin@chromium.org>
Date: Thu Mar 15 20:03:18 2018

[ios] Clean up and polish colors in GridCell

This CL cleans up GridCell and updates the colors.

Bug:  818198 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Id080667cf704af3d33745ab9019f1556693f80e5
Reviewed-on: https://chromium-review.googlesource.com/963724
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543477}
[modify] https://crrev.com/69cfe36acdc99feaa10a23056405e80d1bc8a44a/ios/chrome/browser/ui/tab_grid/grid_cell.mm
[modify] https://crrev.com/69cfe36acdc99feaa10a23056405e80d1bc8a44a/ios/chrome/browser/ui/tab_grid/grid_constants.h
[modify] https://crrev.com/69cfe36acdc99feaa10a23056405e80d1bc8a44a/ios/chrome/browser/ui/tab_grid/grid_constants.mm
[modify] https://crrev.com/69cfe36acdc99feaa10a23056405e80d1bc8a44a/ios/chrome/browser/ui/tab_grid/grid_theme.h

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d4b93700f5337442a4ea98ac4b2ee9b00dfc40a

commit 5d4b93700f5337442a4ea98ac4b2ee9b00dfc40a
Author: edchin <edchin@chromium.org>
Date: Fri Mar 16 19:52:02 2018

[ios] Polish tab grid (part 1)

This CL moves magic numbers to constants files:

- Various dimensions in GridCell
- Margins and height of TabGridTopToolbar
- Margins and height of TabGridBottomToolbar

This CL also changes the toolbar classes to use
|-willMoveToSuperview:| to setup views instead of
|-init|.

Bug:  818198 ,  822524 

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib4dcfd344c29c3e0ccee103b6002dd6e1d14fb30
Reviewed-on: https://chromium-review.googlesource.com/965576
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543790}
[modify] https://crrev.com/5d4b93700f5337442a4ea98ac4b2ee9b00dfc40a/ios/chrome/browser/ui/tab_grid/BUILD.gn
[modify] https://crrev.com/5d4b93700f5337442a4ea98ac4b2ee9b00dfc40a/ios/chrome/browser/ui/tab_grid/grid_cell.mm
[modify] https://crrev.com/5d4b93700f5337442a4ea98ac4b2ee9b00dfc40a/ios/chrome/browser/ui/tab_grid/grid_constants.h
[modify] https://crrev.com/5d4b93700f5337442a4ea98ac4b2ee9b00dfc40a/ios/chrome/browser/ui/tab_grid/grid_constants.mm
[modify] https://crrev.com/5d4b93700f5337442a4ea98ac4b2ee9b00dfc40a/ios/chrome/browser/ui/tab_grid/tab_grid_bottom_toolbar.h
[modify] https://crrev.com/5d4b93700f5337442a4ea98ac4b2ee9b00dfc40a/ios/chrome/browser/ui/tab_grid/tab_grid_bottom_toolbar.mm
[add] https://crrev.com/5d4b93700f5337442a4ea98ac4b2ee9b00dfc40a/ios/chrome/browser/ui/tab_grid/tab_grid_constants.h
[add] https://crrev.com/5d4b93700f5337442a4ea98ac4b2ee9b00dfc40a/ios/chrome/browser/ui/tab_grid/tab_grid_constants.mm
[modify] https://crrev.com/5d4b93700f5337442a4ea98ac4b2ee9b00dfc40a/ios/chrome/browser/ui/tab_grid/tab_grid_top_toolbar.h
[modify] https://crrev.com/5d4b93700f5337442a4ea98ac4b2ee9b00dfc40a/ios/chrome/browser/ui/tab_grid/tab_grid_top_toolbar.mm
[modify] https://crrev.com/5d4b93700f5337442a4ea98ac4b2ee9b00dfc40a/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm

Summary: Polish tab grid UI (was: Tweak tab grid UI with assets and redlines from UX)
Project Member

Comment 11 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c4d192fbe0fc49b2fc793baae78fafc3e0b3cce

commit 9c4d192fbe0fc49b2fc793baae78fafc3e0b3cce
Author: edchin <edchin@chromium.org>
Date: Fri Mar 16 22:40:55 2018

[ios] Miscellaneous polishing on tab grid

- sets grid background color
- sets colors for empty state
- switches done and close all buttons for bottom toolbar

Bug:  818198 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iaae31633889c8f013c5ea1da59176f75186df434
Reviewed-on: https://chromium-review.googlesource.com/967278
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543850}
[modify] https://crrev.com/9c4d192fbe0fc49b2fc793baae78fafc3e0b3cce/ios/chrome/browser/ui/tab_grid/grid_constants.h
[modify] https://crrev.com/9c4d192fbe0fc49b2fc793baae78fafc3e0b3cce/ios/chrome/browser/ui/tab_grid/grid_view_controller.mm
[modify] https://crrev.com/9c4d192fbe0fc49b2fc793baae78fafc3e0b3cce/ios/chrome/browser/ui/tab_grid/tab_grid_bottom_toolbar.mm
[modify] https://crrev.com/9c4d192fbe0fc49b2fc793baae78fafc3e0b3cce/ios/chrome/browser/ui/tab_grid/tab_grid_constants.h
[modify] https://crrev.com/9c4d192fbe0fc49b2fc793baae78fafc3e0b3cce/ios/chrome/browser/ui/tab_grid/tab_grid_constants.mm
[modify] https://crrev.com/9c4d192fbe0fc49b2fc793baae78fafc3e0b3cce/ios/chrome/browser/ui/tab_grid/tab_grid_top_toolbar.mm
[modify] https://crrev.com/9c4d192fbe0fc49b2fc793baae78fafc3e0b3cce/ios/chrome/browser/ui/tab_grid/tab_grid_view_controller.mm

Labels: -medium large
This is turning out to be much longer task than expected. It's not difficult. But it requires many iterations and CLs. Moving to large size.
Project Member

Comment 13 by bugdroid1@chromium.org, Mar 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05d29274a7d4ad32e2cb36b61afb92b2d9b6c23e

commit 05d29274a7d4ad32e2cb36b61afb92b2d9b6c23e
Author: edchin <edchin@chromium.org>
Date: Tue Mar 20 01:41:23 2018

[ios] Expand tappable region of grid cell close button

Bug:  818198 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I5ae016579a179f2bbb9f1c9c5f7bd96db2a71f3d
Reviewed-on: https://chromium-review.googlesource.com/969924
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544256}
[modify] https://crrev.com/05d29274a7d4ad32e2cb36b61afb92b2d9b6c23e/ios/chrome/browser/ui/tab_grid/grid_cell.mm
[modify] https://crrev.com/05d29274a7d4ad32e2cb36b61afb92b2d9b6c23e/ios/chrome/browser/ui/tab_grid/grid_constants.h
[modify] https://crrev.com/05d29274a7d4ad32e2cb36b61afb92b2d9b6c23e/ios/chrome/browser/ui/tab_grid/grid_constants.mm

Project Member

Comment 14 by bugdroid1@chromium.org, Mar 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93b949aa25ddfc5f96bea6fe7fdee90ee09a50f8

commit 93b949aa25ddfc5f96bea6fe7fdee90ee09a50f8
Author: edchin <edchin@chromium.org>
Date: Tue Mar 20 17:31:17 2018

[ios] Polish tab grid layout and cell size

Configuration of cell sizes and layout constants is now in
grid_constants.h.

Bug:  818198 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4c1358ae504610aef3f6db3473ef8b6147ed0496
Reviewed-on: https://chromium-review.googlesource.com/967873
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544422}
[modify] https://crrev.com/93b949aa25ddfc5f96bea6fe7fdee90ee09a50f8/ios/chrome/browser/ui/tab_grid/grid_constants.h
[modify] https://crrev.com/93b949aa25ddfc5f96bea6fe7fdee90ee09a50f8/ios/chrome/browser/ui/tab_grid/grid_constants.mm
[modify] https://crrev.com/93b949aa25ddfc5f96bea6fe7fdee90ee09a50f8/ios/chrome/browser/ui/tab_grid/grid_layout.h
[modify] https://crrev.com/93b949aa25ddfc5f96bea6fe7fdee90ee09a50f8/ios/chrome/browser/ui/tab_grid/grid_layout.mm

Status: Fixed (was: Started)
I'm happy with how far we've come in the static tab grid UI.
With my untrained eye, it matches the specs/mocks pretty well. 
I'm marking this phase of polish complete. 

In Q2, we can have further testing and feedback from UX. 
Note: iPhone 8 Plus mocks were not delivered and therefore 
the itemSize and positioning looks a bit off on that device. 
It's a very easy tweak to take another pass in Q2. 
The NextAction date has arrived: 2018-03-28

Sign in to add a comment