New issue
Advanced search Search tips

Issue 818196 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
smcgruer@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 772407



Sign in to add a comment

Web Animations: updating current time should exit if new current time is unresolved

Project Member Reported by smcgruer@chromium.org, Mar 2 2018 
https://www.w3.org/TR/web-animations-1/#silently-set-the-current-time

"""
If seek time is an unresolved time value, then perform the following steps.

  i. If the current time is resolved, then throw a TypeError.
  ii. Abort these steps.
"""

Currently our code does not do this, as far as I know. See http://output.jsbin.com/xeyiwux
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8992f6f763a1c6bfc43cc89eef1568c93ec7205

commit f8992f6f763a1c6bfc43cc89eef1568c93ec7205
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Tue Mar 13 01:20:45 2018

Web Animations: Early-exit from setCurrentTime if new time is null

The spec says that setting the current time to null should throw if the
existing currentTime is non-null, or do nothing otherwise.

Bug: 818196
Change-Id: Iac89e46d6b884c924c88b603fbec77b61a337ce2
Reviewed-on: https://chromium-review.googlesource.com/946050
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542682}
[modify] https://crrev.com/f8992f6f763a1c6bfc43cc89eef1568c93ec7205/third_party/WebKit/LayoutTests/external/wpt/web-animations/timing-model/animations/setting-the-current-time-of-an-animation-expected.txt
[modify] https://crrev.com/f8992f6f763a1c6bfc43cc89eef1568c93ec7205/third_party/WebKit/LayoutTests/external/wpt/web-animations/timing-model/animations/setting-the-current-time-of-an-animation.html
[modify] https://crrev.com/f8992f6f763a1c6bfc43cc89eef1568c93ec7205/third_party/WebKit/Source/core/animation/Animation.cpp
[modify] https://crrev.com/f8992f6f763a1c6bfc43cc89eef1568c93ec7205/third_party/WebKit/Source/core/animation/Animation.h
[modify] https://crrev.com/f8992f6f763a1c6bfc43cc89eef1568c93ec7205/third_party/WebKit/Source/core/animation/Animation.idl

Comment 2 by smcgruer@chromium.org, Mar 13 2018 

The above CL actually doesn't fix much of the issue, due to an existing bug in Animation::CalculateCurrentTime(). For some reason, Animation::CalculateCurrentTime() never returns unresolved even when start_time_ is unresolved, despite what the spec says. Fixing this breaks a bunch of other tests though, so needs a closer look.

Comment 3 by smcgruer@chromium.org, Mar 31 2018

Blocking: 772407

Comment 4 by smcgruer@chromium.org, Mar 31 2018

Cc: smcgruer@chromium.org
Owner: ----
Status: Available (was: Assigned)
►

Sign in to add a comment