BrowserNonClientFrameViewAshTest.HeaderVisibilityInOverviewAndSplitview* flaky and disabled |
|||||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of grt@chromium.org https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=BrowserNonClientFrameViewAshTest.HeaderVisibilityInOverviewAndSplitview* both browser_tests and mus_browser_tests
,
Mar 5 2018
,
Mar 8 2018
,
Mar 14 2018
,
Mar 14 2018
,
Mar 22 2018
+xdai assign to xdai who was author of test
,
Nov 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/974e90b0c0e27f2358bdb661c6d2e41405715072 commit 974e90b0c0e27f2358bdb661c6d2e41405715072 Author: Evan Stade <estade@chromium.org> Date: Tue Nov 20 22:35:33 2018 Fix and enable ash browser test BrowserNonClientFrameViewAshTest.HeaderVisibilityInOverviewAndSplitview This test was disabled due to flake (classic Ash), which I can't repro now. But while it was disabled, it quit passing because some updates to the test broke it, and because the home launcher now means that tablet mode affects the visibility of caption buttons. This fixes the test for all configurations including multi process Mash. Bug: 818170 Change-Id: Ia0a029f52872b84f6ce6d37c1e433719c243eb56 Reviewed-on: https://chromium-review.googlesource.com/c/1327529 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#609831} [modify] https://crrev.com/974e90b0c0e27f2358bdb661c6d2e41405715072/ash/public/interfaces/shell_test_api.mojom [modify] https://crrev.com/974e90b0c0e27f2358bdb661c6d2e41405715072/ash/shell_test_api.cc [modify] https://crrev.com/974e90b0c0e27f2358bdb661c6d2e41405715072/ash/shell_test_api.h [modify] https://crrev.com/974e90b0c0e27f2358bdb661c6d2e41405715072/chrome/browser/ui/ash/system_tray_client.cc [modify] https://crrev.com/974e90b0c0e27f2358bdb661c6d2e41405715072/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
,
Dec 11
The test has been re-enabled in #7. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Mar 2 2018