New issue
Advanced search Search tips

Issue 818170 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

BrowserNonClientFrameViewAshTest.HeaderVisibilityInOverviewAndSplitview* flaky and disabled

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Mar 2 2018

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a11312fb3f6b0ae0eed68d004c07332ffc3977a

commit 9a11312fb3f6b0ae0eed68d004c07332ffc3977a
Author: Greg Thompson <grt@chromium.org>
Date: Fri Mar 02 14:14:30 2018

Disable BrowserNonClientFrameViewAshTest.HeaderVisibilityInOverviewAndSplitview/* due to flakes.

BUG= 818170 
TBR=grt@chromium.org

Change-Id: If59a726f649a32efe7498405e29c0335e3231f09
Reviewed-on: https://chromium-review.googlesource.com/946248
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540511}
[modify] https://crrev.com/9a11312fb3f6b0ae0eed68d004c07332ffc3977a/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc

Components: UI>Shell
Labels: -Sheriff-Chromium
Cc: afakhry@chromium.org alancutter@chromium.org
Summary: BrowserNonClientFrameViewAshTest.HeaderVisibilityInOverviewAndSplitview* flaky and disabled (was: BrowserNonClientFrameViewAshTest.HeaderVisibilityInOverviewAndSplitview* flaky)
Components: -UI>Shell UI>Shell>WindowManager>Splitscreen UI>Shell>OverviewMode
Owner: sammiequon@chromium.org
Status: Assigned (was: Available)
Cc: sammiequon@chromium.org
Owner: x...@chromium.org
+xdai

assign to xdai who was author of test
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/974e90b0c0e27f2358bdb661c6d2e41405715072

commit 974e90b0c0e27f2358bdb661c6d2e41405715072
Author: Evan Stade <estade@chromium.org>
Date: Tue Nov 20 22:35:33 2018

Fix and enable ash browser test

BrowserNonClientFrameViewAshTest.HeaderVisibilityInOverviewAndSplitview

This test was disabled due to flake (classic Ash), which I can't repro
now. But while it was disabled, it quit passing because some updates
to the test broke it, and because the home launcher now means that
tablet mode affects the visibility of caption buttons. This fixes the
test for all configurations including multi process Mash.

Bug:  818170 
Change-Id: Ia0a029f52872b84f6ce6d37c1e433719c243eb56
Reviewed-on: https://chromium-review.googlesource.com/c/1327529
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609831}
[modify] https://crrev.com/974e90b0c0e27f2358bdb661c6d2e41405715072/ash/public/interfaces/shell_test_api.mojom
[modify] https://crrev.com/974e90b0c0e27f2358bdb661c6d2e41405715072/ash/shell_test_api.cc
[modify] https://crrev.com/974e90b0c0e27f2358bdb661c6d2e41405715072/ash/shell_test_api.h
[modify] https://crrev.com/974e90b0c0e27f2358bdb661c6d2e41405715072/chrome/browser/ui/ash/system_tray_client.cc
[modify] https://crrev.com/974e90b0c0e27f2358bdb661c6d2e41405715072/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc

Status: Fixed (was: Assigned)
The test has been re-enabled in #7. 

Sign in to add a comment