New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 818160 link

Starred by 1 user
Status: Fixed
Owner:
█ gsennton@chromium.org
Last visit > 30 days ago
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Make sure WebView 66 does not break the WebView Support Library

Project Member Reported by gsennton@chromium.org, Mar 2 2018 
Right now (around the time of the branch point for 66) the chromium-side of the support library is somewhat implemented but not entirely - so using the current ToT WebView will most likely break the WebView Support Library.
We should make sure WebView 66 does not break the support library.

I think the easiest way to do this is to remove (only in 66) the entry-point for the support library into chromium code, then 66 should be treated like all other WebView versions that are not compatible with the support library.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 8 2018

Labels: merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bbd673c5f0947386e55f6310a223501c40fec84

commit 0bbd673c5f0947386e55f6310a223501c40fec84
Author: Gustav Sennton <gsennton@google.com>
Date: Thu Mar 08 13:12:30 2018

[Android WebView] remove the entry-point for the support library.

WebView 66 is not compatible with the WebView Support Library. To ensure
we fail to use WebView 66 together with the Support Library in a
reasonable/expected way, we remove the entry-point
(SupportLibReflectionUtil) the support library uses to call into the
WebView code. By doing so we make sure the support library treats
WebView 66 just like any of the previously released WebView APKs.

Bug:  818160 
Change-Id: I5ad1f904f83a8299f03d05bb8295fc8406ee0425
Reviewed-on: https://chromium-review.googlesource.com/953004
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#92}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/0bbd673c5f0947386e55f6310a223501c40fec84/android_webview/support_library/BUILD.gn
[delete] https://crrev.com/63438275f6f15b0a0fef74c82aea0e5d8a69e622/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibReflectionUtil.java

Comment 2 by gsennton@chromium.org, Mar 9 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment