New issue
Advanced search Search tips

Issue 818158 link

Starred by 1 user
Status: Fixed
Owner:
oprypin@chromium.org
Closed: Mar 2018
Cc:
machenb...@chromium.org
jbudorick@chromium.org
oprypin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

LKGR finder recipe fails (red) when the revision is stale

Project Member Reported by oprypin@chromium.org, Mar 2 2018 
Example:
https://build.chromium.org/p/client.webrtc.fyi/builders/WebRTC%20lkgr%20finder/builds/39861/steps/calculate%20webrtc%20lkgr

The recipe successfully finds the LKGR, sends an email that it's outdated, but then also goes red and sends another email that the build failed. I think having both emails is unnecessary and it dulls the signal for when the LKGR finder might actually fail.

Suggested fix: Make the LKGR finder return a different status code for non-fatal failures, and then don't fail the build in the recipe.

Let me know if you think it's a good idea; I'll send CLs to move in this direction.

Comment 1 by machenb...@chromium.org, Mar 2 2018 

I also think the baked-in email is enough...

But I wonder where do you get an email about the failed build from? If e.g. gatekeeper or mail notifier, maybe you should just switch it off there? In V8, I don't get a second email.

Comment 2 Deleted

Comment 3 by oprypin@chromium.org, Mar 2 2018 

https://cs.chromium.org/webrtc-infra
g/webrtc-infra/A_tXvX8TsGs

I think disabling emails would mean missing actual failures of the LKGR finder

Comment 4 by vadimsh@chromium.org, Mar 7 2018

Components: -Infra Infra>Client>WebRTC
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/7a4722137440999d5e0230a75edc8ad63463823b

commit 7a4722137440999d5e0230a75edc8ad63463823b
Author: Oleh Prypin <oprypin@webrtc.org>
Date: Thu Mar 08 08:20:24 2018

LKGR finder: Don't fail the build if the LKGR is just stale

These are not real failures so they shouldn't be as prominent,
and the script already sends a custom email for stale LKGR anyway.

Bug:  chromium:818158 
Change-Id: I3d50db3cef15f20da963afd90659470c7cc72f11
Reviewed-on: https://chromium-review.googlesource.com/947970
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Oleh Prypin <oprypin@chromium.org>

[modify] https://crrev.com/7a4722137440999d5e0230a75edc8ad63463823b/recipes/recipes/lkgr_finder.py
[modify] https://crrev.com/7a4722137440999d5e0230a75edc8ad63463823b/infra/services/lkgr_finder/__main__.py
[add] https://crrev.com/7a4722137440999d5e0230a75edc8ad63463823b/recipes/recipes/lkgr_finder.expected/webrtc_lkgr_stale.json

Comment 6 by oprypin@chromium.org, Mar 21 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment