New issue
Advanced search Search tips

Issue 818136 link

Starred by 2 users
Status: Fixed
Owner:
thomasanderson@chromium.org
Closed: Mar 2018
Cc:
e...@chromium.org
drott@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 787020


Sign in to add a comment

blink_platform_unittests fails some HarfBuzzShaperTest tests on gLinux

Project Member Reported by toyoshim@chromium.org, Mar 2 2018 
Now sure if this happens only on my machine, but after upgrading to gLinux, it start failing.

[42712:42783:0302/191956.610712:15410506558:ERROR:kill_posix.cc(84)] Unable to terminate process group 43726: No such process (3)
[ RUN      ] HarfBuzzShaperTest.ResolveCandidateRunsDevanagariCommonLatinCommon
../../third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp:173: Failure
Expected equality of these values:
  1u
    Which is: 1
  num_glyphs
    Which is: 3
[  FAILED  ] HarfBuzzShaperTest.ResolveCandidateRunsDevanagariCommonLatinCommon (51 ms)
[2375/2376] HarfBuzzShaperTest.ResolveCandidateRunsDevanagariCommonLatinCommon (51 ms)
[42712:42783:0302/191956.805280:15410701126:ERROR:kill_posix.cc(84)] Unable to terminate process group 43728: No such process (3)
[ RUN      ] HarfBuzzShaperTest.ResolveCandidateRunsDevanagariCommon
../../third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp:153: Failure
Expected equality of these values:
  1u
    Which is: 1
  num_glyphs
    Which is: 3
[  FAILED  ] HarfBuzzShaperTest.ResolveCandidateRunsDevanagariCommon (35 ms)
[2376/2376] HarfBuzzShaperTest.ResolveCandidateRunsDevanagariCommon (35 ms)
Retrying 2 tests (retry #2)
[42712:42783:0302/191957.032888:15410928734:ERROR:kill_posix.cc(84)] Unable to terminate process group 43730: No such process (3)
[ RUN      ] HarfBuzzShaperTest.ResolveCandidateRunsDevanagariCommonLatinCommon
../../third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp:173: Failure
Expected equality of these values:
  1u
    Which is: 1
  num_glyphs
    Which is: 3
[  FAILED  ] HarfBuzzShaperTest.ResolveCandidateRunsDevanagariCommonLatinCommon (51 ms)
[2377/2378] HarfBuzzShaperTest.ResolveCandidateRunsDevanagariCommonLatinCommon (51 ms)
[42712:42783:0302/191957.293990:15411189836:ERROR:kill_posix.cc(84)] Unable to terminate process group 43732: No such process (3)
[ RUN      ] HarfBuzzShaperTest.ResolveCandidateRunsDevanagariCommon
../../third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp:153: Failure
Expected equality of these values:
  1u
    Which is: 1
  num_glyphs
    Which is: 3
[  FAILED  ] HarfBuzzShaperTest.ResolveCandidateRunsDevanagariCommon (46 ms)
[2378/2378] HarfBuzzShaperTest.ResolveCandidateRunsDevanagariCommon (46 ms)
Retrying 2 tests (retry #3)
[42712:42783:0302/191957.555660:15411451507:ERROR:kill_posix.cc(84)] Unable to terminate process group 43734: No such process (3)
[ RUN      ] HarfBuzzShaperTest.ResolveCandidateRunsDevanagariCommonLatinCommon
../../third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp:173: Failure
Expected equality of these values:
  1u
    Which is: 1
  num_glyphs
    Which is: 3
[  FAILED  ] HarfBuzzShaperTest.ResolveCandidateRunsDevanagariCommonLatinCommon (43 ms)
[2379/2380] HarfBuzzShaperTest.ResolveCandidateRunsDevanagariCommonLatinCommon (43 ms)
[42712:42783:0302/191957.816813:15411712659:ERROR:kill_posix.cc(84)] Unable to terminate process group 43736: No such process (3)
[ RUN      ] HarfBuzzShaperTest.ResolveCandidateRunsDevanagariCommon
../../third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp:153: Failure
Expected equality of these values:
  1u
    Which is: 1
  num_glyphs
    Which is: 3
[  FAILED  ] HarfBuzzShaperTest.ResolveCandidateRunsDevanagariCommon (50 ms)
[2380/2380] HarfBuzzShaperTest.ResolveCandidateRunsDevanagariCommon (50 ms)
2 tests failed:
    HarfBuzzShaperTest.ResolveCandidateRunsDevanagariCommon (../../third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp:143)
    HarfBuzzShaperTest.ResolveCandidateRunsDevanagariCommonLatinCommon (../../third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp:163)
Tests took 7 seconds.
./out/Release/blink_platform_unittests  28.98s user 8.18s system 473% cpu 7.840 total

Comment 1 by e...@chromium.org, Mar 7 2018

Cc: drott@chromium.org e...@chromium.org
Status: Available (was: Untriaged)
Interesting, thanks for filing.

Comment 2 by drott@chromium.org, Mar 9 2018 

We'll have improvements in deterministically selecting fonts in unit tests after https://chromium-review.googlesource.com/c/chromium/src/+/938578 - toyoshim@, you could try experimentally applying that CL.

Comment 3 by toyoshim@chromium.org, Mar 12 2018

Owner: drott@chromium.org
Status: Started (was: Available)
Nice!
I just confirmed that the issue still exists on trunk, and the problem can be fixed with your CL!!

Comment 4 by toyoshim@chromium.org, Mar 12 2018

Blockedon: 787020

Comment 5 by drott@chromium.org, Mar 12 2018

Owner: thomasanderson@chromium.org
thomasanderson@, mind if I assign this to you, since your CL https://chromium-review.googlesource.com/c/chromium/src/+/938578 addresses this issue?

Comment 6 by toyoshim@chromium.org, Mar 12 2018 

Ah, it isn't your CL.

Thomas: thank you for working on that CL!
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44027d41f779d62af9def030160ad2015c0d851f

commit 44027d41f779d62af9def030160ad2015c0d851f
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Thu Mar 15 17:14:53 2018

Run linux tests with deterministic font configuration

This CL sets up a common font environment for all tests to run under.  In
particular:
* All gtests and layout tests start with the same font config.
* The font config is isolated from any system font settings.

These changes were necessary:
* Moved fontconfig_util_linux.* into //base so that SetUpFontconfig() could be
  called during common test setup.
* Made DejaVu Sans the fallback sans font instead of Arial (ie the system font
  matched when the font family is set to 'sans').  The gtests used to use DejaVu
  Sans for this font (usually), but the layout tests used Arial.  I sided with
  the gtests in this case because it's easier to rebaseline the layout tests
  than to fix a slew of gtests.
* Added DejaVu Sans Bold to test_fonts.  Some gtests expected a bold default
  font.
* Moved third_party/content_shell_test_fonts to third_party/test_fonts.
* Fixed gtests broken by the new config.
* Rebaselined layout tests.
* Use bundled fontconfig for ChromeOS, matching the behavior on Linux.  (Only
  for desktop ChromeOS builds.  Real ChromeOS builds will still use the system
  fontconfig.)

Additionally, building the fontconfig cache is a nontrivial task.  It can take
~600ms when done from scratch.  To fix this, fontconfig cache files are saved to
the out directory.  Fontconfig initialization takes < 1ms with this
optimization, and the initialization only needs to happen once per test suite,
not at the beginning of each test.  Finally, to prevent the 600ms from being
added to the first test suite to run, the cache files are generated as part of
the build.

The tests still pull in system fonts from msttcorefonts, but those should soon
be replaced by alternatives in third_party/test_fonts.  Once this is done, this
should fix font related test failures caused by differences between Linux
systems or system font configurations.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_32_ng;master.tryserver.chromium.linux:linux_arm
BUG= 787020 , 818136 

Change-Id: If6bcbd35bddf86dec3f02d105d8be551b898e9b2
Reviewed-on: https://chromium-review.googlesource.com/938578
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543414}
[modify] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/DEPS
[modify] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/base/test/BUILD.gn
[add] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/base/test/fontconfig_util_linux.cc
[add] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/base/test/fontconfig_util_linux.h
[add] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/base/test/generate_fontconfig_caches.cc
[modify] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/base/test/test_suite.cc
[modify] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/build/compiled_action.gni
[modify] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/chrome/test/data/plugin_power_saver/poster_tests.html
[modify] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/chrome/test/data/plugin_power_saver/small_cross_origin.html
[modify] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/content/browser/linux_ipc_browsertest.cc
[modify] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/content/shell/app/blink_test_platform_support_linux.cc
[modify] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/content/shell/test_runner/BUILD.gn
[delete] https://crrev.com/be8ffb1b1c877bf1ef29b8a0044cc13b81b130c5/content/shell/test_runner/resources/fonts/fonts.conf
[modify] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/content/test/data/accessibility/html/ins.html
[modify] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/content/test/data/cross_site_iframe_factory.html
[modify] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/docs/layout_tests_linux.md
[modify] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/headless/lib/dom_tree_extraction_expected_nodes.txt
[modify] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/headless/lib/dom_tree_extraction_expected_styles.txt
[modify] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/headless/test/data/iframe.html
[modify] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/third_party/WebKit/LayoutTests/platform/linux/fast/forms/text-control-intrinsic-widths-expected.txt
[modify] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/third_party/WebKit/LayoutTests/platform/linux/fast/forms/validation-bubble-appearance-edge-expected.png
[modify] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/third_party/WebKit/LayoutTests/platform/linux/fast/forms/validation-bubble-appearance-iframe-expected.png
[modify] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/third_party/WebKit/LayoutTests/platform/linux/fast/forms/validation-bubble-appearance-rtl-ui-expected.png
[modify] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/third_party/WebKit/LayoutTests/platform/linux/inspector-protocol/layout-fonts/generic-system-ui-expected.txt
[modify] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/third_party/WebKit/LayoutTests/platform/linux/virtual/scalefactor150/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png
[modify] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/third_party/WebKit/LayoutTests/platform/linux/virtual/scalefactor200/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png
[modify] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/third_party/WebKit/LayoutTests/platform/linux/virtual/scalefactor200withzoom/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png
[delete] https://crrev.com/be8ffb1b1c877bf1ef29b8a0044cc13b81b130c5/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/scalefactor150/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png
[delete] https://crrev.com/be8ffb1b1c877bf1ef29b8a0044cc13b81b130c5/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/scalefactor200withzoom/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png
[delete] https://crrev.com/be8ffb1b1c877bf1ef29b8a0044cc13b81b130c5/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/scalefactor150/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png
[delete] https://crrev.com/be8ffb1b1c877bf1ef29b8a0044cc13b81b130c5/third_party/WebKit/LayoutTests/platform/mac-mac10.11/virtual/scalefactor200withzoom/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png
[add] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/scalefactor150/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png
[add] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/third_party/WebKit/LayoutTests/platform/mac-mac10.12/virtual/scalefactor200withzoom/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png
[delete] https://crrev.com/be8ffb1b1c877bf1ef29b8a0044cc13b81b130c5/third_party/WebKit/LayoutTests/platform/mac-retina/virtual/scalefactor150/fast/hidpi/static/validation-bubble-appearance-hidpi-expected.png
[add] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/third_party/WebKit/LayoutTests/platform/mac-retina/webaudio/DynamicsCompressor/dynamicscompressor-clear-internal-state-expected.txt
[modify] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp
[modify] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/android.py
[modify] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
[modify] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/fuchsia.py
[delete] https://crrev.com/be8ffb1b1c877bf1ef29b8a0044cc13b81b130c5/third_party/content_shell_fonts/.gitignore
[delete] https://crrev.com/be8ffb1b1c877bf1ef29b8a0044cc13b81b130c5/third_party/content_shell_fonts/BUILD.gn
[delete] https://crrev.com/be8ffb1b1c877bf1ef29b8a0044cc13b81b130c5/third_party/content_shell_fonts/OWNERS
[delete] https://crrev.com/be8ffb1b1c877bf1ef29b8a0044cc13b81b130c5/third_party/content_shell_fonts/content_shell_test_fonts.tar.gz.sha1
[modify] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/third_party/fontconfig/fontconfig.gni
[add] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/third_party/test_fonts/.gitignore
[add] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/third_party/test_fonts/BUILD.gn
[rename] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/third_party/test_fonts/LICENSE
[add] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/third_party/test_fonts/OWNERS
[rename] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/third_party/test_fonts/README.chromium
[add] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/third_party/test_fonts/test_fonts.tar.gz.sha1
[modify] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/ui/gfx/BUILD.gn
[modify] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/ui/gfx/font_render_params_linux_unittest.cc
[modify] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/ui/gfx/platform_font_linux_unittest.cc
[modify] https://crrev.com/44027d41f779d62af9def030160ad2015c0d851f/ui/gfx/render_text_unittest.cc
[delete] https://crrev.com/be8ffb1b1c877bf1ef29b8a0044cc13b81b130c5/ui/gfx/test/fontconfig_util_linux.cc
[delete] https://crrev.com/be8ffb1b1c877bf1ef29b8a0044cc13b81b130c5/ui/gfx/test/fontconfig_util_linux.h

Comment 8 by thomasanderson@chromium.org, Mar 15 2018

Status: Fixed (was: Started)
►

Sign in to add a comment