Issue metadata
Sign in to add a comment
|
Regression: hit testing doesn't work |
||||||||||||||||||||||
Issue description- on chromevox.com, get the location of the feedback link - call AutomationNode.prototype.hitTestWithReply (on an instance) with the left/top of the link and pass it a callback result: the resulting node is not the same as the feedback link
,
Mar 2 2018
,
May 26 2018
,
May 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b356f98c4759bc1d603e0f19256f35521bbf7d9d commit b356f98c4759bc1d603e0f19256f35521bbf7d9d Author: Dominic Mazzoni <dmazzoni@chromium.org> Date: Tue May 29 20:49:01 2018 Fix hitTestWithReply by making the action map global. The problem was that if you call hitTestWithReply on a node in one tree (like the desktop, typically the most logical place to call it), it was storing the callback in a map specific to that try. But then when the hit test result came back via an event on the correct target node, that node might be in a different tree - and that tree had its own map from action IDs to callbacks. Tested by manually calling desktop.hitTestWithReply with coordinates in the middle of the feedback link on the www.chromevox.com homepage. Bug: 818108 Change-Id: I5b995f381f6e260ddcb0f7a1f58a64d0682af949 Reviewed-on: https://chromium-review.googlesource.com/1074490 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#562578} [modify] https://crrev.com/b356f98c4759bc1d603e0f19256f35521bbf7d9d/chrome/renderer/resources/extensions/automation/automation_node.js
,
May 29 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dtseng@chromium.org
, Mar 2 2018