Patch under review: https://chromium-review.googlesource.com/c/chromium/src/+/950684

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db331fe0cd8a5a25e09a7b1a33d8ea3e0391de66

commit db331fe0cd8a5a25e09a7b1a33d8ea3e0391de66
Author: Yash Malik <ymalik@google.com>
Date: Tue Mar 06 12:38:23 2018

VR: Fix selection and composition diffs

This CL fixes two separate bugs::
1) We weren't sending empty commit messages when the user pressed backspace on
   selected text. As a result, the keyboard would not see an ack and freeze.
2) We incorrectly assumed that we wouldn't see a new composition while there is
   an existing composition. This is not true as the keyboard can coalesce
   events.

Bug:  818104 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ifdb28f06fe445a901b3ef32504f5f2c65b933243
Reviewed-on: https://chromium-review.googlesource.com/950684
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541082}
[modify] https://crrev.com/db331fe0cd8a5a25e09a7b1a33d8ea3e0391de66/chrome/browser/vr/model/text_input_info.cc
[modify] https://crrev.com/db331fe0cd8a5a25e09a7b1a33d8ea3e0391de66/chrome/browser/vr/model/text_input_info_unittest.cc

Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2d7bf08b3d1075902348531671b7b4e5f4a84c8

commit d2d7bf08b3d1075902348531671b7b4e5f4a84c8
Author: Yash Malik <ymalik@google.com>
Date: Thu Mar 08 11:23:01 2018

VR: Fix selection and composition diffs

This CL fixes two separate bugs::
1) We weren't sending empty commit messages when the user pressed backspace on
   selected text. As a result, the keyboard would not see an ack and freeze.
2) We incorrectly assumed that we wouldn't see a new composition while there is
   an existing composition. This is not true as the keyboard can coalesce
   events.

Bug:  818104 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ifdb28f06fe445a901b3ef32504f5f2c65b933243
Reviewed-on: https://chromium-review.googlesource.com/950684
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#541082}(cherry picked from commit db331fe0cd8a5a25e09a7b1a33d8ea3e0391de66)
Reviewed-on: https://chromium-review.googlesource.com/955362
Reviewed-by: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#89}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/d2d7bf08b3d1075902348531671b7b4e5f4a84c8/chrome/browser/vr/model/text_input_info.cc
[modify] https://crrev.com/d2d7bf08b3d1075902348531671b7b4e5f4a84c8/chrome/browser/vr/model/text_input_info_unittest.cc

Verified on builds 66.0.3359.28 and 67.0.3368.0  
Test case "Edit text after text selection" to "2D UI Handling Test Plan"