New issue
Advanced search Search tips

Issue 818083 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

notificationclose event not fired after closing notification with tag

Reported by ja...@onesignal.com, Mar 2 2018

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3282.186 Safari/537.36

Steps to reproduce the problem:
1. Visit the notification test generator URL specified below these steps. Verify that the box for "notificationclose event" is checked. Also verify that the tag selection box is set to either "tag-1" or "tag-2".
2. Allow site notification permissions if you see the browser permission request.
3. Click "Display Notification".
4. Quickly click the body of the notification (triggering an internal "notificationclick" event). Do not swipe away the notification, click the Close button, or the let the notification expire.
5. Once again, click "Display Notification".
6. For macOS-style native notifications, hover over the notification to see the "Close" and "Settings" button, and then click the "Close" button. For legacy Chrome-style notifications, click the top-right X button.
7. Observe that no page alert appears (the "notificationclose" event has not been fired).

Notification Test Generator URL: https://tests.peter.sh/notification-generator/#tag=1;;notificationCloseEvent=true;;action=4

What is the expected behavior?
Each time the "Close" button is clicked on the notification, a "notificationclose" event should be fired.

What went wrong?
When a notification with a tag value has its body clicked and a new notification with the same tag value is closed, the "notificationclose" event does not fire.

Did this work before? N/A 

Does this work in other browsers? Yes

Chrome version: 64.0.3282.186  Channel: stable
OS Version: OS X 10.11.6
Flash Version: 

1. This behavior does not appear if the notification doesn't have a tag.

2. Clicking the notification body for a series of notifications before finally clicking Close only loses the first "notificationclose" event, and subsequent "notificationclose" events are fired.

3. On Mac OS X, this behavior is consistent regardless of whether macOS native-style notifications or legacy Chrome-style notifications are set (e.g. "Enable native notifications" set to Default or Disabled in chrome://flags).

Version Information
-------------------
Google Chrome 64.0.3282.186 (Official Build) (64-bit)
Revision	9611116ee79c63602f452e4fae2242a61cf0672d-refs/branch-heads/3282@{#694}
Operating System: Mac OS X 10.11.6
 
Components: UI>Notifications
Labels: Needs-Triage-M64

Comment 2 by lgrey@chromium.org, Mar 2 2018

Cc: bever...@google.com
Labels: Triaged-ET Needs-Feedback
Tested the issue on chrome reported version 64.0.3282.186 using Mac 10.12.6 with steps mentioned below:
1) Launched chrome, navigated to URL: https://tests.peter.sh/notification-generator/#tag=1;;notificationCloseEvent=true;;action=4 and clicked on Allow
2) Clicked on "Display the Notification", Notification appears at top left corner, clicked on body of the notification, notification disappears
3) Again clicked on "Display the Notification", notification appears and hovered the mouse over notification, able to see "close" and "settings" button, clicked on "close" button, notification disappears
4) Again clicked on "Display the Notification", able to see notification

@Reporter: Please find the attached screen cast for your reference and let us know if we missed anything in reproducing the issue. Try to test this issue by creating new person with no apps and extensions in it and let us know if the issue still persists.

Thanks!
818083.mp4
1.5 MB View Download
Hi viswa,

Please use the full link "https://tests.peter.sh/notification-generator/#tag=1;;notificationCloseEvent=true;;action=4" which has the "notificationclose event" checkbox selected and the "Tag" dropdown set to "tag-1". Both these settings must be set to reproduce the issue.

For step #7, "observe that no page alert appears" refers to Peter's JavaScript alert dialog that notifies the user the Close button has been clicked: https://i.imgur.com/McPapCh.png. The issue is that, when following the described steps #1 - #7, you won't see an alert after clicking Close. The expected behavior is that clicking Close should always show that alert. The alert dialog is tied to the "notificationclose" event, which isn't firing and is causing the dialog to not appear.
Project Member

Comment 5 by sheriffbot@chromium.org, Mar 6 2018

Cc: viswa.karala@chromium.org
Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by peter@chromium.org, Mar 7 2018

Cc: -bever...@google.com peter@chromium.org
Please use my Chromium address.
Owner: peter@chromium.org
Status: Assigned (was: Unconfirmed)
Mac triage: assigning to beverloo@ for further triage or investigation.
Labels: Hotlist-DesktopUIChecked Hotlist-DesktopUIValid
*** Mass UI Triage *** 

Able to reproduce the issue on Mac on latest canary and also on early M60 build, this is a non-regression issue.

Sign in to add a comment