New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 818055 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Remove "Exit Fullscreen" Touch Bar Button

Project Member Reported by spqc...@chromium.org, Mar 2 2018

Issue description

Some stuff requires the ESC key when in fullscreen.
Remove the "exit fullscreen" button
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2ae6ac5bd18c9a3615c60a474617638704fe329

commit f2ae6ac5bd18c9a3615c60a474617638704fe329
Author: spqchan <spqchan@chromium.org>
Date: Fri Mar 02 22:03:27 2018

[Mac] Remove the "Exit Fullscreen" Touch Bar Button

Bug:  818055 
Change-Id: Ia0f8ee535c45ede4047e02f068def70e538b8524
Reviewed-on: https://chromium-review.googlesource.com/946740
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540648}
[modify] https://crrev.com/f2ae6ac5bd18c9a3615c60a474617638704fe329/chrome/browser/ui/cocoa/browser_window_touch_bar.mm
[modify] https://crrev.com/f2ae6ac5bd18c9a3615c60a474617638704fe329/chrome/browser/ui/cocoa/browser_window_touch_bar_unittest.mm

Status: Fixed (was: Assigned)
Labels: Merge-Request-65
Status: Assigned (was: Fixed)
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 2 2018

Labels: -Merge-Request-65 Merge-Review-65 Hotlist-Merge-Review
This bug requires manual review: We are only 3 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Before we approve merge to M65, could you pls confirm followings?

Is this M65 regression and critical to merge?
Is the change well baked/verified in Canary, having enough automation tests coverage and safe to merge? (Change just landed so not in canary yet)
Any other imp details to justify the merge.

Please note M65 is going to stable next week so merge bar is very high. Thank you.

No, it's not critical. Since we're 3 days from stable, I think we should just punt this to M66
Labels: -Merge-Review-65 Merge-Rejected-65 M-66
Rejecting merge to M65 based on comment #6. Please request a merge to M66.
Labels: Merge-Request-66
Project Member

Comment 9 by sheriffbot@chromium.org, Mar 3 2018

Labels: -Merge-Request-66 Merge-Approved-66 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Pls merge your change to M66 branch 3359 ASAP so we can pick it up for next M66 Dev release. Thank you.
Pls merge your change to M66 branch 3359 ASAP so we can pick it up for next M66 Dev release. Thank you.
Project Member

Comment 12 by bugdroid1@chromium.org, Mar 5 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72afd0dfb454a663e82778634a00a9c65284c4e0

commit 72afd0dfb454a663e82778634a00a9c65284c4e0
Author: spqchan <spqchan@chromium.org>
Date: Mon Mar 05 19:14:33 2018

[Mac] Remove the "Exit Fullscreen" Touch Bar Button

(cherry picked from commit f2ae6ac5bd18c9a3615c60a474617638704fe329)

Bug:  818055 
Change-Id: Ia0f8ee535c45ede4047e02f068def70e538b8524
Reviewed-on: https://chromium-review.googlesource.com/946740
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#540648}
Reviewed-on: https://chromium-review.googlesource.com/949566
Reviewed-by: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#15}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/72afd0dfb454a663e82778634a00a9c65284c4e0/chrome/browser/ui/cocoa/browser_window_touch_bar.mm
[modify] https://crrev.com/72afd0dfb454a663e82778634a00a9c65284c4e0/chrome/browser/ui/cocoa/browser_window_touch_bar_unittest.mm

Status: Fixed (was: Assigned)

Sign in to add a comment