[Findit] bug when identify first failures for a failed test step |
||
Issue descriptionExample: https://findit-for-me.appspot.com/waterfall/failure?url=https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20MSan%20Tests/8204 It seems for some continuous test failures, the first failure information is only updated to current_failure - 1.
,
Mar 2 2018
I think there is a bug at detect first failure part. Because of the bug, Findit didn't realize the task at 8195, since it thought the first failure is 8203.
,
Mar 2 2018
If so, how could we explain the problem in my comment #1: even the Swarming tasks are run and completed, those tests are still in "Unclassified failures" section.
,
Mar 2 2018
That should be a separate bug in UI
,
Mar 2 2018
I don't think so. The pipeline is not completed yet. https://findit-for-me.appspot.com/_ah/pipeline/status?root=c80624579b464a478b06b51e536401df&auto=false#pipeline-0b1afaa4423a442b8331ea0aa6a1c2d8 Not sure why the analysis is marked as completed on UI though.
,
Mar 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/1fc117c9cf0fbf963ef6839a7045e512a9eacf55 commit 1fc117c9cf0fbf963ef6839a7045e512a9eacf55 Author: Chan <chanli@chromium.org> Date: Fri Mar 02 19:16:44 2018 [Findit] Traverse previous builds backwards to get first failure at test level. The change on traverse previous builds when getting first failures at step level make the builds in failure_info['builds'] in ascending order instead of descending order, so later when we traverse failure_info['builds'], we were not checking backwards as intended. Which cause a bug when getting first failures for each failed test. Bug: 818049 Change-Id: If03b05b1fdc77811393fda33e9e32c033d9636df Reviewed-on: https://chromium-review.googlesource.com/945072 Commit-Queue: Chan Li <chanli@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> [modify] https://crrev.com/1fc117c9cf0fbf963ef6839a7045e512a9eacf55/appengine/findit/services/test_failure/ci_test_failure.py [modify] https://crrev.com/1fc117c9cf0fbf963ef6839a7045e512a9eacf55/appengine/findit/services/test_failure/test/ci_test_failure_test.py
,
Mar 5 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by st...@chromium.org
, Mar 2 2018