New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 818049 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit] bug when identify first failures for a failed test step

Project Member Reported by chanli@chromium.org, Mar 2 2018

Issue description

Example: https://findit-for-me.appspot.com/waterfall/failure?url=https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20MSan%20Tests/8204

It seems for some continuous test failures, the first failure information is only updated to current_failure - 1. 


 

Comment 1 by st...@chromium.org, Mar 2 2018

The 1st-time failure had the Swarming task: https://findit-for-me.appspot.com/waterfall/failure?url=https%3A%2F%2Fluci-milo.appspot.com%2Fbuildbot%2Fchromium.memory%2FLinux+MSan+Tests%2F8195

As the Swarming task is completed, might be a problem in getting back the result.
I think there is a bug at detect first failure part. Because of the bug, Findit didn't realize the task at 8195, since it thought the first failure is 8203.

Comment 3 by st...@chromium.org, Mar 2 2018

If so, how could we explain the problem in my comment #1: even the Swarming tasks are run and completed, those tests are still in "Unclassified failures" section.
That should be a separate bug in UI 

Comment 5 by st...@chromium.org, Mar 2 2018

I don't think so. The pipeline is not completed yet. https://findit-for-me.appspot.com/_ah/pipeline/status?root=c80624579b464a478b06b51e536401df&auto=false#pipeline-0b1afaa4423a442b8331ea0aa6a1c2d8

Not sure why the analysis is marked as completed on UI though.
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/1fc117c9cf0fbf963ef6839a7045e512a9eacf55

commit 1fc117c9cf0fbf963ef6839a7045e512a9eacf55
Author: Chan <chanli@chromium.org>
Date: Fri Mar 02 19:16:44 2018

[Findit] Traverse previous builds backwards to get first failure at test level.

The change on traverse previous builds when getting first failures at step level make the builds in failure_info['builds'] in ascending order instead of descending order, so later when we traverse failure_info['builds'], we were not checking backwards as intended. Which cause a bug when getting first failures for each failed test.


Bug:  818049 
Change-Id: If03b05b1fdc77811393fda33e9e32c033d9636df
Reviewed-on: https://chromium-review.googlesource.com/945072
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Shuotao Gao <stgao@chromium.org>

[modify] https://crrev.com/1fc117c9cf0fbf963ef6839a7045e512a9eacf55/appengine/findit/services/test_failure/ci_test_failure.py
[modify] https://crrev.com/1fc117c9cf0fbf963ef6839a7045e512a9eacf55/appengine/findit/services/test_failure/test/ci_test_failure_test.py

Status: Verified (was: Started)

Sign in to add a comment