Update media/test/data/README to a README.md file |
||
Issue descriptionThe current test/data/README is a bit harder to read, and has inconsistent style/structure etc. Proposal: 1. change the file to a .md file for readability 2. Enforce a consistent style, e.g. ## foo.webm Tool: FFmpeg Command line: ffmpeg -i .... Note: Use a secret key "foo"
,
Sep 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/811c335a8bf874a33d4edb1972c67e77bc54ca4d commit 811c335a8bf874a33d4edb1972c67e77bc54ca4d Author: Xiaohan Wang <xhwang@chromium.org> Date: Tue Sep 18 19:41:28 2018 media: Add presubmit for updating README when changing test files I found some test files were added without updating the README file. So adding this presubmit check to remind people to do so. Here's an example of the warning when updating test files without updating the README file: ----------------------------------------- ~/chromium/src$ git cl presubmit --upload Running presubmit upload checks ... ** Presubmit Warnings ** When updating files in media/test/data, please also update media/test/data/README: media/test/data/vorbis-asd \ media/test/data/vorbis-packet-0 \ media/test/data/vorbis-packet-0_for_test Presubmit checks took 1.4s to calculate. ----------------------------------------- Bug: 818048 Change-Id: Ibc8b5d82aa7b0fd2688a01b736a57d8bf0e11e29 Reviewed-on: https://chromium-review.googlesource.com/1229497 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#592149} [add] https://crrev.com/811c335a8bf874a33d4edb1972c67e77bc54ca4d/media/test/PRESUBMIT.py
,
Oct 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f0257d49eae32a43d024b63855eb57db4c025caf commit f0257d49eae32a43d024b63855eb57db4c025caf Author: Xiaohan Wang <xhwang@chromium.org> Date: Mon Oct 01 22:42:13 2018 media: Convert media/test/data/README to a markdown doc This makes it easy to organize the doc and find files. This CL does minimal reordering of the files listed in the current README, with some rough grouping. It is expected that we'll improve the structure of the file gradually over time. Bug: 818048 Change-Id: I8f19fa388d6cd599fc32824b91d184bd49b2767a Reviewed-on: https://chromium-review.googlesource.com/1253207 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#595609} [modify] https://crrev.com/f0257d49eae32a43d024b63855eb57db4c025caf/media/test/PRESUBMIT.py [delete] https://crrev.com/9cb89c1171e1f5dec93ff94595fde5d83a761c78/media/test/data/README [add] https://crrev.com/f0257d49eae32a43d024b63855eb57db4c025caf/media/test/data/README.md
,
Oct 2
|
||
►
Sign in to add a comment |
||
Comment 1 by xhw...@chromium.org
, Mar 2 2018