Green SSL Lock goes away after downloading passkit file |
||||||
Issue descriptionApp Version (from "Chrome Settings > About Chrome"): ToT iOS Version: 11.2 Device: iPhone Steps to reproduce: 1.) Load google.com Load https://www.passsource.com/pass/create.php?hashedSerialNumber=eNortjIysVKy9DUsM071cg5x9gpMdNMOMkjTzy0PtLVVsgZcMJGzCOk,&download=true Observed behavior: SSL lock goes away Expected behavior: SSL lock for google.com should stay
,
May 31 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f64c46743b40945ff1dc46b177cf3ffebb69950b commit f64c46743b40945ff1dc46b177cf3ffebb69950b Author: Eugene But <eugenebut@google.com> Date: Thu May 31 16:34:51 2018 Do not reset SSL status if the load failed because it was rejected. A pending NavigationItem is not committed for kWebKitErrorFrameLoadInterruptedByPolicyChange errors, so there is no need to reset SSLStatus for the last committed item. Also moved cancelled error handling to the top to group CFNetwork and WebKit error handling. Bug: 818037 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I955f7c49fd7863f5e60433d5ced1c45437ec9a2e Reviewed-on: https://chromium-review.googlesource.com/1080169 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#563270} [modify] https://crrev.com/f64c46743b40945ff1dc46b177cf3ffebb69950b/ios/web/web_state/ui/crw_web_controller.mm
,
May 31 2018
,
Jun 5 2018
Verified in: App Version: 69.0.3450.0 canary Devices: iPhone 7, iPhone 8 Plus, iPhone X iOS Versions: 10.3.3, 11.4, 11.4.1 beta SSL lock stays even after downloading passkit file.
,
Jun 13 2018
,
Jun 13 2018
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 14 2018
Issue 852533 has been merged into this issue.
,
Jun 15 2018
Approved!
,
Jun 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b52027c62e665d72b755a11da8babacc03b4f302 commit b52027c62e665d72b755a11da8babacc03b4f302 Author: Eugene But <eugenebut@google.com> Date: Mon Jun 18 16:40:06 2018 Do not reset SSL status if the load failed because it was rejected. A pending NavigationItem is not committed for kWebKitErrorFrameLoadInterruptedByPolicyChange errors, so there is no need to reset SSLStatus for the last committed item. Also moved cancelled error handling to the top to group CFNetwork and WebKit error handling. TBR=eugenebut@google.com (cherry picked from commit f64c46743b40945ff1dc46b177cf3ffebb69950b) Bug: 818037 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I955f7c49fd7863f5e60433d5ced1c45437ec9a2e Reviewed-on: https://chromium-review.googlesource.com/1080169 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by: Mohammad Refaat <mrefaat@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#563270} Reviewed-on: https://chromium-review.googlesource.com/1104782 Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#397} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/b52027c62e665d72b755a11da8babacc03b4f302/ios/web/web_state/ui/crw_web_controller.mm
,
Jun 27 2018
Verified the issue on the build 68.0.3440.40 beta tested on iPhone7+(iOS11.4). SSL icon is displayed after downloding passkit. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by eugene...@chromium.org
, May 30 2018Labels: -M-66 M-68
Owner: eugene...@chromium.org
Status: Started (was: Assigned)