clang-format produced code that (choose all that apply):
- Riles my finely honed stylistic dander
- No sane human would ever choose
Here's the code before formatting:
Example 1:
static constexpr std::array<PrefetchItemState, 6> kFinalizableStates = {{
PrefetchItemState::NEW_REQUEST,
PrefetchItemState::SENT_GENERATE_PAGE_BUNDLE,
PrefetchItemState::AWAITING_GCM,
PrefetchItemState::RECEIVED_GCM,
PrefetchItemState::SENT_GET_OPERATION,
PrefetchItemState::RECEIVED_BUNDLE,
}};
Example 2:
static constexpr std::array<PrefetchItemState, 11>
kOrderedPrefetchItemStates = {{
PrefetchItemState::NEW_REQUEST,
PrefetchItemState::SENT_GENERATE_PAGE_BUNDLE,
PrefetchItemState::AWAITING_GCM,
PrefetchItemState::RECEIVED_GCM,
PrefetchItemState::SENT_GET_OPERATION,
PrefetchItemState::RECEIVED_BUNDLE,
PrefetchItemState::DOWNLOADING,
PrefetchItemState::DOWNLOADED,
PrefetchItemState::IMPORTING,
PrefetchItemState::FINISHED,
PrefetchItemState::ZOMBIE}};
Here's the code after formatting:
Example 1:
static constexpr std::array<PrefetchItemState, 6> kFinalizableStates = {{
PrefetchItemState::NEW_REQUEST,
PrefetchItemState::SENT_GENERATE_PAGE_BUNDLE,
PrefetchItemState::AWAITING_GCM, PrefetchItemState::RECEIVED_GCM,
PrefetchItemState::SENT_GET_OPERATION, PrefetchItemState::RECEIVED_BUNDLE,
}};
Example 2:
static constexpr std::array<PrefetchItemState, 11>
kOrderedPrefetchItemStates = {
{PrefetchItemState::NEW_REQUEST,
PrefetchItemState::SENT_GENERATE_PAGE_BUNDLE,
PrefetchItemState::AWAITING_GCM, PrefetchItemState::RECEIVED_GCM,
PrefetchItemState::SENT_GET_OPERATION,
PrefetchItemState::RECEIVED_BUNDLE, PrefetchItemState::DOWNLOADING,
PrefetchItemState::DOWNLOADED, PrefetchItemState::IMPORTING,
PrefetchItemState::FINISHED, PrefetchItemState::ZOMBIE}};
Here's how it ought to look:
I'd say the same as before formatting. And note that this same block of text is kept formatted just like to the original version if single curly brackets are used to wrap these initialization lists instead of double (which was requited because of iOS-specific formatting style).
Code review link for full files/context:
https://chromium-review.googlesource.com/c/chromium/src/+/944716
Comment 1 by smaier@chromium.org
, Nov 27static constexpr std::array<PrefetchItemState, 6> kFinalizableStates = {{ PrefetchItemState::NEW_REQUEST, PrefetchItemState::SENT_GENERATE_PAGE_BUNDLE, PrefetchItemState::AWAITING_GCM, PrefetchItemState::RECEIVED_GCM, PrefetchItemState::SENT_GET_OPERATION, PrefetchItemState::RECEIVED_BUNDLE, }}; static constexpr std::array<PrefetchItemState, 11> kOrderedPrefetchItemStates = { {PrefetchItemState::NEW_REQUEST, PrefetchItemState::SENT_GENERATE_PAGE_BUNDLE, PrefetchItemState::AWAITING_GCM, PrefetchItemState::RECEIVED_GCM, PrefetchItemState::SENT_GET_OPERATION, PrefetchItemState::RECEIVED_BUNDLE, PrefetchItemState::DOWNLOADING, PrefetchItemState::DOWNLOADED, PrefetchItemState::IMPORTING, PrefetchItemState::FINISHED, PrefetchItemState::ZOMBIE}}; This one is half fixed? The first one looks good, the second doesn't.