New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 818012 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

text suggestion UI shows up monocularly in chrome

Project Member Reported by vollick@chromium.org, Mar 1 2018

Issue description

 - type asdf on google.com
 - double click / long click on the text
 - a context menu w/ "Add to Dictionary" appears

 

Comment 1 by ericde@google.com, Mar 2 2018

Labels: Hotlist-VRB-MVP
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81fbecf043498381aee81cf88bcc1164393fecc2

commit 81fbecf043498381aee81cf88bcc1164393fecc2
Author: Ian Vollick <vollick@chromium.org>
Date: Wed Mar 07 16:38:27 2018

[vr] Disable text suggestions in immersive mode

This feature is not currently supported, though we hope to add support
soon. This work is tracked in crbug.com/779126

Bug:  818012 
Change-Id: Ib677f7ea62b9f681ba494c27367b286a122dd10f
Reviewed-on: https://chromium-review.googlesource.com/944543
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541461}
[modify] https://crrev.com/81fbecf043498381aee81cf88bcc1164393fecc2/third_party/WebKit/Source/core/editing/suggestion/TextSuggestionController.cpp

Labels: Merge-Request-66
Project Member

Comment 4 by sheriffbot@chromium.org, Mar 8 2018

Labels: -Merge-Request-66 Merge-Approved-66 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 9 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec7cb992986ebdb3992d04c8dd927dfd7af42028

commit ec7cb992986ebdb3992d04c8dd927dfd7af42028
Author: Ian Vollick <vollick@chromium.org>
Date: Fri Mar 09 02:36:58 2018

[vr] Disable text suggestions in immersive mode

This feature is not currently supported, though we hope to add support
soon. This work is tracked in crbug.com/779126

Bug:  818012 
Change-Id: Ib677f7ea62b9f681ba494c27367b286a122dd10f
Reviewed-on: https://chromium-review.googlesource.com/944543
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#541461}(cherry picked from commit 81fbecf043498381aee81cf88bcc1164393fecc2)
Reviewed-on: https://chromium-review.googlesource.com/956767
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#129}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/ec7cb992986ebdb3992d04c8dd927dfd7af42028/third_party/WebKit/Source/core/editing/suggestion/TextSuggestionController.cpp

Status: Fixed (was: Started)
Labels: Test-Complete
Status: Verified (was: Fixed)
Verified in builds 66.0.3359.28 and 67.0.3368.0.
Text suggestions are disabled.

Sign in to add a comment