New issue
Advanced search Search tips

Issue 817974 link

Starred by 1 user
Status: Fixed
Owner:
chengx@chromium.org
Closed: Mar 2018
Cc:
grt@chromium.org
brucedaw...@chromium.org
finnur@chromium.org
peter@chromium.org
scottmg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 734095



Sign in to add a comment

Add crash reporting support for notification_helper.exe

Project Member Reported by chengx@chromium.org, Mar 1 2018 
OS: Win10

The work to implement the Windows 10 native notification into Chrome is in progress. Many of the code pieces have been implemented.To handle notification activation, we introduced a new EXE named notification_helper. Since this is a new EXE, we need to add crash reporting support for it.

Comment 1 by thestig@google.com, Mar 5 2018

Components: Internals>CrashReporting
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e13fa8e454198c8bd0b37e89c63893a2dc9441c0

commit e13fa8e454198c8bd0b37e89c63893a2dc9441c0
Author: Xi Cheng <chengx@chromium.org>
Date: Wed Mar 07 02:07:10 2018

[notification_helper.exe] Add crash reporting support

This CL enables crash reporting for notification_helper.exe by reusing the
crashpad handler embedded in chrome.exe. A new crash reporter client is
implemented for the notification_helper process as in class
NotificationHelperCrashReporterClient.

Bug:  734095 ,  817974 
Change-Id: I279e1d7c8e1741fd09af9db9d4915d69b92e56c9
Reviewed-on: https://chromium-review.googlesource.com/924981
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Jianzhou Feng <jzfeng@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541283}
[modify] https://crrev.com/e13fa8e454198c8bd0b37e89c63893a2dc9441c0/chrome/app/chrome_crash_reporter_client_win.cc
[modify] https://crrev.com/e13fa8e454198c8bd0b37e89c63893a2dc9441c0/chrome/app/chrome_crash_reporter_client_win.h
[modify] https://crrev.com/e13fa8e454198c8bd0b37e89c63893a2dc9441c0/chrome/installer/setup/installer_crash_reporting.cc
[modify] https://crrev.com/e13fa8e454198c8bd0b37e89c63893a2dc9441c0/components/crash/content/app/crashpad.cc
[modify] https://crrev.com/e13fa8e454198c8bd0b37e89c63893a2dc9441c0/components/crash/content/app/crashpad.h
[modify] https://crrev.com/e13fa8e454198c8bd0b37e89c63893a2dc9441c0/components/crash/content/app/crashpad_mac.mm
[modify] https://crrev.com/e13fa8e454198c8bd0b37e89c63893a2dc9441c0/components/crash/content/app/crashpad_win.cc
[modify] https://crrev.com/e13fa8e454198c8bd0b37e89c63893a2dc9441c0/headless/lib/headless_content_main_delegate.cc
[modify] https://crrev.com/e13fa8e454198c8bd0b37e89c63893a2dc9441c0/notification_helper/BUILD.gn
[modify] https://crrev.com/e13fa8e454198c8bd0b37e89c63893a2dc9441c0/notification_helper/DEPS
[modify] https://crrev.com/e13fa8e454198c8bd0b37e89c63893a2dc9441c0/notification_helper/notification_activator.cc
[modify] https://crrev.com/e13fa8e454198c8bd0b37e89c63893a2dc9441c0/notification_helper/notification_helper.cc
[add] https://crrev.com/e13fa8e454198c8bd0b37e89c63893a2dc9441c0/notification_helper/notification_helper_crash_reporter_client.cc
[add] https://crrev.com/e13fa8e454198c8bd0b37e89c63893a2dc9441c0/notification_helper/notification_helper_crash_reporter_client.h
[add] https://crrev.com/e13fa8e454198c8bd0b37e89c63893a2dc9441c0/notification_helper/notification_helper_util.cc
[add] https://crrev.com/e13fa8e454198c8bd0b37e89c63893a2dc9441c0/notification_helper/notification_helper_util.h

Comment 3 by chengx@chromium.org, Mar 8 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment