New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 817973 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 819430

Blocking:
issue 687695



Sign in to add a comment

"LayerTreeHostTestEarlyDamageCheckStops.RunMultiThread_DelegatingRenderer" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Mar 1 2018

Issue description

"LayerTreeHostTestEarlyDamageCheckStops.RunMultiThread_DelegatingRenderer" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 6 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyUwsSBUZsYWtlIkhMYXllclRyZWVIb3N0VGVzdEVhcmx5RGFtYWdlQ2hlY2tTdG9wcy5SdW5NdWx0aVRocmVhZF9EZWxlZ2F0aW5nUmVuZGVyZXIM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Issue 813924 has been merged into this issue.
Blocking: 687695
Owner: jamwalla@chromium.org
Blockedon: 819430
Labels: -Sheriff-Chromium

Comment 5 by boliu@chromium.org, Mar 12 2018

Status: Fixed (was: Untriaged)
These two should fix test flakes here:
https://chromium-review.googlesource.com/953208
https://chromium-review.googlesource.com/933292
Those are in and still getting flakes. see  issue 822473 

Comment 7 by danakj@chromium.org, Mar 28 2018

Cc: jamwalla@chromium.org boliu@chromium.org
 Issue 822473  has been merged into this issue.

Comment 8 by danakj@chromium.org, Mar 28 2018

Status: Assigned (was: Fixed)
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b905ac3f67f31eb3d07da528c45dfb54fe469c4b

commit b905ac3f67f31eb3d07da528c45dfb54fe469c4b
Author: Yuly Novikov <ynovikov@chromium.org>
Date: Wed Mar 28 19:24:25 2018

Disable LayerTreeHostTestEarlyDamageCheckStops on all platforms

Flaky on linux_chromium_tsan_rel_ng, should be flaky everywhere else.

BUG= 822473 , 817973 

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0fe8b29e74d763ec36f91bfcb7fa2c347006d125
Reviewed-on: https://chromium-review.googlesource.com/984348
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546561}
[modify] https://crrev.com/b905ac3f67f31eb3d07da528c45dfb54fe469c4b/cc/trees/layer_tree_host_unittest.cc

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37d6e09b6eb97174e550b7971088bccd5c87f1f8

commit 37d6e09b6eb97174e550b7971088bccd5c87f1f8
Author: James Wallace-Lee <jamwalla@chromium.org>
Date: Fri Apr 20 16:58:46 2018

Deflake LayerTreeHostTestEarlyDamageCheckStops

Deflake LayerTreeHostTestEarlyDamageCheckStops by calling
PostSetNeedsCommitToMainThread in each frame. The failed on tsan builds
because PostSetneedsCommitToMainThread was only called after a frame
invalidated, and so the test would time out halfway through when an
invalidate was skipped and no new BeginFrame occurred.

Bug:  817973 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia6469126b05da939eaa58b5fbc73558ebf686786
Reviewed-on: https://chromium-review.googlesource.com/1020363
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552358}
[modify] https://crrev.com/37d6e09b6eb97174e550b7971088bccd5c87f1f8/cc/trees/layer_tree_host_unittest.cc

Sign in to add a comment