New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 817954 link

Starred by 2 users
Status: Fixed
Owner:
u...@chromium.org
Closed: Mar 2018
Cc:
█ stefan.p...@gmail.com
alph@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DevTools heap snapshot does not show variable names in the global context

Project Member Reported by u...@chromium.org, Mar 1 2018 
Heap snapshot for the following script shows retaining path without variable name in global context (foo):
class Foo {}
const foo = new Foo();

"7 in system / Context" should be "foo in system / Context".
global_retaining_path.html
84 bytes View Download
global-retaining-path.png
16.0 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/29471bdb366c7c30001e0ea19cbe624a3a6814bf

commit 29471bdb366c7c30001e0ea19cbe624a3a6814bf
Author: Ulan Degenbaev <ulan@chromium.org>
Date: Thu Mar 15 11:20:26 2018

[heap-profiler] Annotate "const/let" refs in top level script context.

This patch extends ExtractContextReferences to handle all declaration
contexts, not only function/module/eval contexts.

Bug:  chromium:817954 
Change-Id: Ibe2827a9d6b2939552da26a60df959c9b22ea059
Reviewed-on: https://chromium-review.googlesource.com/962763
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51945}
[modify] https://crrev.com/29471bdb366c7c30001e0ea19cbe624a3a6814bf/src/profiler/heap-snapshot-generator.cc
[modify] https://crrev.com/29471bdb366c7c30001e0ea19cbe624a3a6814bf/test/cctest/test-heap-profiler.cc

Comment 2 by u...@chromium.org, Mar 21 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment