New issue
Advanced search Search tips

Issue 817951 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

[CRD iOS] In session settings menu becomes huge

Project Member Reported by yuweih@chromium.org, Mar 1 2018

Issue description

That's a regression. Check out the attached screen shots.
 
Before.png
163 KB View Download
Now.png
159 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0794eb01584b83d82e76ce824b5724b2ea9007b

commit d0794eb01584b83d82e76ce824b5724b2ea9007b
Author: Yuwei Huang <yuweih@chromium.org>
Date: Fri Mar 02 01:48:02 2018

[CRD iOS] Fix huge settings icon

A recent change in material components has fixed the size of the list
item icon to 40x40, which makes the icons look huge in our settings
menu. See  crbug.com/817951 

This CL fixes this by implementing our own collection cell with our
desired image size. Here is how it looks after the change:
https://drive.google.com/file/d/10tNCxyy_BLBeBQ3CllLfy033KFx2iClL/view?usp=sharing

Bug:  817951 
Change-Id: I77782669b08da3932721e27f468bc77615debd9a
Reviewed-on: https://chromium-review.googlesource.com/944708
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540406}
[modify] https://crrev.com/d0794eb01584b83d82e76ce824b5724b2ea9007b/remoting/ios/app/settings/BUILD.gn
[modify] https://crrev.com/d0794eb01584b83d82e76ce824b5724b2ea9007b/remoting/ios/app/settings/remoting_settings_view_controller.mm
[add] https://crrev.com/d0794eb01584b83d82e76ce824b5724b2ea9007b/remoting/ios/app/settings/settings_view_cell.h
[add] https://crrev.com/d0794eb01584b83d82e76ce824b5724b2ea9007b/remoting/ios/app/settings/settings_view_cell.mm

Status: Fixed (was: Assigned)
Labels: Merge-Request-66
Oops.. Looks like this hadn't got into branch 3359.

This is a minor UX change for the Chrome Remote Desktop iOS client and doesn't affect the Chrome browser.
Status: Started (was: Fixed)
Project Member

Comment 5 by sheriffbot@chromium.org, Mar 6 2018

Labels: -Merge-Request-66 Merge-Approved-66 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M66. Please go ahead and merge the CL to branch 3359 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), josafat@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 6 2018

Labels: -merge-approved-66 merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb1dce195be05a70a77237d72ce250dbd8739a3b

commit eb1dce195be05a70a77237d72ce250dbd8739a3b
Author: Yuwei Huang <yuweih@chromium.org>
Date: Tue Mar 06 23:26:37 2018

[CRD iOS] Fix huge settings icon

A recent change in material components has fixed the size of the list
item icon to 40x40, which makes the icons look huge in our settings
menu. See  crbug.com/817951 

This CL fixes this by implementing our own collection cell with our
desired image size. Here is how it looks after the change:
https://drive.google.com/file/d/10tNCxyy_BLBeBQ3CllLfy033KFx2iClL/view?usp=sharing

Bug:  817951 
Change-Id: I77782669b08da3932721e27f468bc77615debd9a
Reviewed-on: https://chromium-review.googlesource.com/944708
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540406}(cherry picked from commit d0794eb01584b83d82e76ce824b5724b2ea9007b)

TBR=jamiewalch@chromium.org

Change-Id: I77782669b08da3932721e27f468bc77615debd9a
Reviewed-on: https://chromium-review.googlesource.com/952402
Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#42}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/eb1dce195be05a70a77237d72ce250dbd8739a3b/remoting/ios/app/settings/BUILD.gn
[modify] https://crrev.com/eb1dce195be05a70a77237d72ce250dbd8739a3b/remoting/ios/app/settings/remoting_settings_view_controller.mm
[add] https://crrev.com/eb1dce195be05a70a77237d72ce250dbd8739a3b/remoting/ios/app/settings/settings_view_cell.h
[add] https://crrev.com/eb1dce195be05a70a77237d72ce250dbd8739a3b/remoting/ios/app/settings/settings_view_cell.mm

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verifed Fixed in 67.3396.22

Sign in to add a comment