New issue
Advanced search Search tips

Issue 817930 link

Starred by 1 user
Status: Fixed
Owner:
drott@chromium.org
Closed: Mar 2018
Cc:
drott@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

fast/text/mac-system-ui-trak.html fails on Mac 10.13

Project Member Reported by robertma@chromium.org, Mar 1 2018 
I'm not sure if this test is expected to pass on Mac 10.13. It's passing currently on Mac 10.12 and Retina (which is Mac 10.11 at the moment), but not on Mac 10.10 & 10.11 (marked as WontFix in NeverFixTests).

Filing this bug to triage, also as a placeholder for an expectation line.


Example failure:
https://test-results.appspot.com/data/layout_results/Chromium_Mac_10_13/1363/layout-test-results/fast/text/mac-system-ui-trak-actual.txt

Comment 1 by e...@chromium.org, Mar 1 2018

Owner: drott@chromium.org
Status: Assigned (was: Untriaged)
Looks like a rounding issue, test probably needs to be updated.

Comment 2 by drott@chromium.org, Mar 2 2018 

Thanks for the report, Rober. 

I am not sure, I have to take look. Might be that tracking is not getting activated or that we need new reference data from Safari.

Comment 3 by drott@chromium.org, Mar 2 2018 

SFNSText's trak table has changed, test updated for Mac OS 10.13 and disabled the older ones, CL up in  https://chromium-review.googlesource.com/c/chromium/src/+/945729

Comment 4 by drott@chromium.org, Mar 2 2018

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a013693273e9154f48efb3263105bd7e45132d57

commit a013693273e9154f48efb3263105bd7e45132d57
Author: Dominik Röttsches <drott@chromium.org>
Date: Fri Mar 02 11:22:42 2018

Update Mac trak table test to SFNSText on Mac OS 10.13

Disable the test for older Mac OS as we can't maintain multiple
versions.

Bug:  817930 
Change-Id: I42d7cc1c84e0e02618b69fddcab7c73f93396c1c
Reviewed-on: https://chromium-review.googlesource.com/945729
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540492}
[modify] https://crrev.com/a013693273e9154f48efb3263105bd7e45132d57/third_party/WebKit/LayoutTests/NeverFixTests
[modify] https://crrev.com/a013693273e9154f48efb3263105bd7e45132d57/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/a013693273e9154f48efb3263105bd7e45132d57/third_party/WebKit/LayoutTests/fast/text/mac-system-ui-trak.html

Comment 6 by drott@chromium.org, Mar 2 2018

Status: Fixed (was: Started)
►

Sign in to add a comment